diff mbox

[LIVEPATCH-BUILD-TOOLS,1/2] Fix getopt parsing of long options

Message ID 1469026184-15320-1-git-send-email-ross.lagerwall@citrix.com (mailing list archive)
State New, archived
Headers show

Commit Message

Ross Lagerwall July 20, 2016, 2:49 p.m. UTC 
---
 livepatch-build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Konrad Rzeszutek Wilk July 21, 2016, 2:33 p.m. UTC | #1 
On Wed, Jul 20, 2016 at 03:49:43PM +0100, Ross Lagerwall wrote:

What happend to your SoB?

The patch is fine otherwise.
> ---
>  livepatch-build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/livepatch-build b/livepatch-build
> index 7395b49..d9d9da3 100755
> --- a/livepatch-build
> +++ b/livepatch-build
> @@ -185,7 +185,7 @@ usage() {
>  
>  find_tools || die "can't find supporting tools"
>  
> -options=$(getopt -o hs:p:c:o:j:k:d -l "help,srcdir:patch:config:output:cpus:,skip:,debug,xen-debug,xen-syms:,depends:,prelink" -- "$@") || die "getopt failed"
> +options=$(getopt -o hs:p:c:o:j:k:d -l "help,srcdir:,patch:,config:,output:,cpus:,skip:,debug,xen-debug,xen-syms:,depends:,prelink" -- "$@") || die "getopt failed"
>  
>  eval set -- "$options"
>  
> -- 
> 2.7.4
>
diff mbox

Patch

diff --git a/livepatch-build b/livepatch-build
index 7395b49..d9d9da3 100755
--- a/livepatch-build
+++ b/livepatch-build
@@ -185,7 +185,7 @@  usage() {
 
 find_tools || die "can't find supporting tools"
 
-options=$(getopt -o hs:p:c:o:j:k:d -l "help,srcdir:patch:config:output:cpus:,skip:,debug,xen-debug,xen-syms:,depends:,prelink" -- "$@") || die "getopt failed"
+options=$(getopt -o hs:p:c:o:j:k:d -l "help,srcdir:,patch:,config:,output:,cpus:,skip:,debug,xen-debug,xen-syms:,depends:,prelink" -- "$@") || die "getopt failed"
 
 eval set -- "$options"