| Message ID | 1470272876-29435-1-git-send-email-bob.liu@oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Aug 04, 2016 at 09:07:56AM +0800, Bob Liu wrote: > When specifying a serial list in domain config, users of > libxl_console_get_tty cannot get the tty path of a second specified pty serial, > since right now it always returns the tty path of serial 0. > > Signed-off-by: Bob Liu <bob.liu@oracle.com> Acked-by: Wei Liu <wei.liu2@citrix.com> Ian, I think this is a backport candidate. > --- > v2: Rename the patch title. > --- > tools/libxl/libxl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c > index 2cf7451..00af286 100644 > --- a/tools/libxl/libxl.c > +++ b/tools/libxl/libxl.c > @@ -1795,7 +1795,7 @@ int libxl_console_get_tty(libxl_ctx *ctx, uint32_t domid, int cons_num, > > switch (type) { > case LIBXL_CONSOLE_TYPE_SERIAL: > - tty_path = GCSPRINTF("%s/serial/0/tty", dom_path); > + tty_path = GCSPRINTF("%s/serial/%d/tty", dom_path, cons_num); > break; > case LIBXL_CONSOLE_TYPE_PV: > if (cons_num == 0) > -- > 1.7.10.4 >
On Thu, Aug 04, 2016 at 09:07:45AM +0100, Wei Liu wrote: > On Thu, Aug 04, 2016 at 09:07:56AM +0800, Bob Liu wrote: > > When specifying a serial list in domain config, users of > > libxl_console_get_tty cannot get the tty path of a second specified pty serial, > > since right now it always returns the tty path of serial 0. > > > > Signed-off-by: Bob Liu <bob.liu@oracle.com> > > Acked-by: Wei Liu <wei.liu2@citrix.com> > > Ian, I think this is a backport candidate. > Pushed.
Wei Liu writes ("Re: [PATCH v2] libxl: return any serial tty path in libxl_console_get_tty"):
> On Thu, Aug 04, 2016 at 09:07:45AM +0100, Wei Liu wrote:
> > Ian, I think this is a backport candidate.
Queued, thanks.
Ian.
diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c index 2cf7451..00af286 100644 --- a/tools/libxl/libxl.c +++ b/tools/libxl/libxl.c @@ -1795,7 +1795,7 @@ int libxl_console_get_tty(libxl_ctx *ctx, uint32_t domid, int cons_num, switch (type) { case LIBXL_CONSOLE_TYPE_SERIAL: - tty_path = GCSPRINTF("%s/serial/0/tty", dom_path); + tty_path = GCSPRINTF("%s/serial/%d/tty", dom_path, cons_num); break; case LIBXL_CONSOLE_TYPE_PV: if (cons_num == 0)
When specifying a serial list in domain config, users of libxl_console_get_tty cannot get the tty path of a second specified pty serial, since right now it always returns the tty path of serial 0. Signed-off-by: Bob Liu <bob.liu@oracle.com> --- v2: Rename the patch title. --- tools/libxl/libxl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)