diff mbox

[OSSTEST,RFC,08/14] Introduce ts-xtf-install

Message ID 1470300360-4435-9-git-send-email-wei.liu2@citrix.com (mailing list archive)
State New, archived
Headers show

Commit Message

Wei Liu Aug. 4, 2016, 8:45 a.m. UTC 
Extract XTF to the desire location.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
 ts-xtf-install | 41 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)
 create mode 100755 ts-xtf-install

Comments

Ian Jackson Aug. 4, 2016, 11:54 a.m. UTC | #1 
Wei Liu writes ("[OSSTEST PATCH RFC 08/14] Introduce ts-xtf-install"):
> Extract XTF to the desire location.
...                           ^
> +    $xtfdir = get_runvar('xtfdir', $r{xtfbuildjob});
> +    die "xtfdir not set?" if !$xtfdir;

I don't understand the purpose of this xtfdir variable.

Surely the extracting job should just put it wherever it wants.

Ian.
Wei Liu Aug. 4, 2016, 11:58 a.m. UTC | #2 
On Thu, Aug 04, 2016 at 12:54:41PM +0100, Ian Jackson wrote:
> Wei Liu writes ("[OSSTEST PATCH RFC 08/14] Introduce ts-xtf-install"):
> > Extract XTF to the desire location.
> ...                           ^
> > +    $xtfdir = get_runvar('xtfdir', $r{xtfbuildjob});
> > +    die "xtfdir not set?" if !$xtfdir;
> 
> I don't understand the purpose of this xtfdir variable.
> 
> Surely the extracting job should just put it wherever it wants.
> 

No, it can't.

It has to be in the location specified during build because there are
hard-coded paths inside test case config files.

Wei.

> Ian.
diff mbox

Patch

diff --git a/ts-xtf-install b/ts-xtf-install
new file mode 100755
index 0000000..81e5864
--- /dev/null
+++ b/ts-xtf-install
@@ -0,0 +1,41 @@ 
+#!/usr/bin/perl -w
+# This is part of "osstest", an automated testing framework for Xen.
+# Copyright (C) 2016 Citrix Inc.
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU Affero General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+use strict qw(vars);
+use DBI;
+use Osstest;
+use Osstest::TestSupport;
+
+tsreadconfig();
+
+our ($whhost) = @ARGV;
+$whhost ||= 'host';
+
+our $ho= selecthost($whhost);
+
+sub extract () {
+    my $xtfdir;
+    my %distpath;
+
+    $xtfdir = get_runvar('xtfdir', $r{xtfbuildjob});
+    die "xtfdir not set?" if !$xtfdir;
+
+    target_extract_jobdistpath($ho, "xtf", "path_xtfdist",
+                               $r{xtfbuildjob}, \%distpath);
+}
+
+extract();