From patchwork Thu Aug 4 15:16:39 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Vrabel X-Patchwork-Id: 9263785 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D2BE86048F for ; Thu, 4 Aug 2016 15:19:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C2BF327FC0 for ; Thu, 4 Aug 2016 15:19:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B4FED283E4; Thu, 4 Aug 2016 15:19:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 522F827FC0 for ; Thu, 4 Aug 2016 15:19:43 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bVKOC-0006ye-NL; Thu, 04 Aug 2016 15:16:52 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bVKOB-0006yG-PI for xen-devel@lists.xenproject.org; Thu, 04 Aug 2016 15:16:51 +0000 Received: from [85.158.139.211] by server-11.bemta-5.messagelabs.com id DE/82-12614-36C53A75; Thu, 04 Aug 2016 15:16:51 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprNIsWRWlGSWpSXmKPExsXitHRDpG5SzOJ wgxt79Cy+b5nM5MDocfjDFZYAxijWzLyk/IoE1ozJd/8yFvSxVPT1bmdqYNzG3MXIySEh4C9x 88YOMJtNQEfi8ZIZ7F2MHBwiAioSt/cagISZBaokrlz6zApiCwv4SNz+eZ0NpIQFqGT15yiQM K+Am8TMZ9MYISbKSZw//hNsIqeAu8SeRTvBWoWAak5N28kIYatIfFy7ihWiV1Di5MwnLBCrJC QOvngBdRm3xO3TU5knMPLNQlI2C0nZAkamVYwaxalFZalFukaGeklFmekZJbmJmTm6hgamerm pxcWJ6ak5iUnFesn5uZsYgQFVz8DAuIPx7mS/Q4ySHExKorwzAhaHC/El5adUZiQWZ8QXleak Fh9ilOHgUJLgnRAFlBMsSk1PrUjLzAGGNkxagoNHSYS3BiTNW1yQmFucmQ6ROsWoy7Hgx+21T EIsefl5qVLivPNAigRAijJK8+BGwOLsEqOslDAvIwMDgxBPQWpRbmYJqvwrRnEORiVh3hMgU3 gy80rgNr0COoIJ6IgTBgtAjihJREhJNTAWc9jMX7tH+pHz2VvtR1LCW3ONIgy9J25MS2X8sbK qZ7vgPlG2bwl6GqdUFRXO/LoRUmRiHrLfTmFppc9SQ64XOok7L/beLAo3yGNMXCsksoep7cp7 jzTvlpVbjuwt0Gt5u/c478TzomtSdYTWTGz/zbJ2FYvA0Qmse0JYzzrqxPLekUu8U6jEUpyRa KjFXFScCACiJKDCrgIAAA== X-Env-Sender: prvs=017fdc70d=david.vrabel@citrix.com X-Msg-Ref: server-4.tower-206.messagelabs.com!1470323808!53015107!2 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 8.77; banners=-,-,- X-VirusChecked: Checked Received: (qmail 13733 invoked from network); 4 Aug 2016 15:16:50 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-4.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 4 Aug 2016 15:16:50 -0000 X-IronPort-AV: E=Sophos;i="5.28,470,1464652800"; d="scan'208";a="370353134" From: David Vrabel To: Date: Thu, 4 Aug 2016 16:16:39 +0100 Message-ID: <1470323800-9481-2-git-send-email-david.vrabel@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1470323800-9481-1-git-send-email-david.vrabel@citrix.com> References: <1470323800-9481-1-git-send-email-david.vrabel@citrix.com> MIME-Version: 1.0 X-DLP: MIA2 Cc: Juergen Gross , Boris Ostrovsky , David Vrabel Subject: [Xen-devel] [PATCHv2 1/2] xen/prvicmd: use ENOTTY if the IOCTL is not supported X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP The standard return value for ioctl(2) where the cmd is not supported is ENOTTY, not EINVAL. Signed-off-by: David Vrabel Reviewed-by: Juergen Gross --- drivers/xen/privcmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c index 702040f..ac76bc4 100644 --- a/drivers/xen/privcmd.c +++ b/drivers/xen/privcmd.c @@ -572,7 +572,7 @@ static long privcmd_ioctl(struct file *file, break; default: - ret = -EINVAL; + ret = -ENOTTY; break; }