From patchwork Wed Aug 10 07:35:27 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Razvan Cojocaru X-Patchwork-Id: 9272773 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D371D600CA for ; Wed, 10 Aug 2016 07:38:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B1E8326222 for ; Wed, 10 Aug 2016 07:38:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A67F52838E; Wed, 10 Aug 2016 07:38:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 2344826222 for ; Wed, 10 Aug 2016 07:38:42 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bXO3C-0005sM-F7; Wed, 10 Aug 2016 07:35:42 +0000 Received: from mail6.bemta6.messagelabs.com ([85.158.143.247]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bXO3B-0005sG-7k for xen-devel@lists.xen.org; Wed, 10 Aug 2016 07:35:41 +0000 Received: from [193.109.254.147] by server-6.bemta-6.messagelabs.com id BD/E2-11175-C49DAA75; Wed, 10 Aug 2016 07:35:40 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprEIsWRWlGSWpSXmKPExsUSfTxjoa7PzVX hBk+fMlks+biYxYHR4+ju30wBjFGsmXlJ+RUJrBnHPu5kLfjEWfF9xkrGBsZn7F2MnBxCAh4S X3Y1M0HYaxklmueHdDFyAdnXGCW6l7yDK3o7YzITRGI/o8SiExNZQRJsAoYSqze2sIHYIgLSE tc+X2YEsZkFXCXOXT/AAmILCwRIPH0/B6yGRUBV4siEw2C9vAKeEh0d08BsCQE5iZPHJkPZOR K3r08AsjmAbCmJ/61KIHslBLpZJHrXr2CCqJGReDTxJtsERoEFjAyrGNWLU4vKUot0TfSSijL TM0pyEzNzdA0NzPRyU4uLE9NTcxKTivWS83M3MQLDigEIdjB2X/Y/xCjJwaQkymu5ZVW4EF9S fkplRmJxRnxRaU5q8SFGGQ4OJQne+9eBcoJFqempFWmZOcAAh0lLcPAoifCq3wBK8xYXJOYWZ 6ZDpE4xKkqJ8y4A6RMASWSU5sG1waLqEqOslDAvI9AhQjwFqUW5mSWo8q8YxTkYlYR5eUHG82 TmlcBNfwW0mAlocZLqCpDFJYkIKakGxpUZgVE/Hp2N98+//ZxvgpqM5OaWbYcCNhwOURXxazi Wb64T175ZqW+fzM/LJ8tuqi+1mPPgVLL69x+zZQOCvzxd93BlIJ+ot/m644zpJ49lfODRiLkU X/ExS4zh0PPWhZ7vj2esy5rAGPK/qdG+eUPAj5ePBeryMm69s3biEZM//8buem2JkxJLcUaio RZzUXEiAJGAZdulAgAA X-Env-Sender: rcojocaru@bitdefender.com X-Msg-Ref: server-15.tower-27.messagelabs.com!1470814539!316536!1 X-Originating-IP: [91.199.104.161] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 8.84; banners=-,-,- X-VirusChecked: Checked Received: (qmail 32355 invoked from network); 10 Aug 2016 07:35:39 -0000 Received: from mx01.bbu.dsd.mx.bitdefender.com (HELO mx01.bbu.dsd.mx.bitdefender.com) (91.199.104.161) by server-15.tower-27.messagelabs.com with DHE-RSA-AES128-GCM-SHA256 encrypted SMTP; 10 Aug 2016 07:35:39 -0000 Received: (qmail 17742 invoked from network); 10 Aug 2016 10:35:38 +0300 Received: from unknown (HELO mx-sr.buh.bitdefender.com) (10.17.80.103) by mx01.bbu.dsd.mx.bitdefender.com with AES256-GCM-SHA384 encrypted SMTP; 10 Aug 2016 10:35:38 +0300 Received: from smtp03.buh.bitdefender.org (smtp.bitdefender.biz [10.17.80.77]) by mx-sr.buh.bitdefender.com (Postfix) with ESMTP id 402987FBF2 for ; Wed, 10 Aug 2016 10:35:38 +0300 (EEST) Received: (qmail 16393 invoked from network); 10 Aug 2016 10:35:38 +0300 Received: from xen.dsd.ro (HELO xen.dsd.bitdefender.biz) (rcojocaru@bitdefender.com@10.10.14.109) by smtp03.buh.bitdefender.org with AES128-SHA256 encrypted SMTP; 10 Aug 2016 10:35:38 +0300 From: Razvan Cojocaru To: xen-devel@lists.xen.org Date: Wed, 10 Aug 2016 10:35:27 +0300 Message-Id: <1470814527-12929-1-git-send-email-rcojocaru@bitdefender.com> X-Mailer: git-send-email 1.9.1 X-BitDefender-Scanner: Clean, Agent: BitDefender qmail 3.1.6 on smtp03.buh.bitdefender.org, sigver: 7.66771 X-BitDefender-Spam: No (0) X-BitDefender-SpamStamp: Build: [Engines: 2.15.6.911, Dats: 430070, Stamp: 3], Multi: [Enabled, t: (0.000008, 0.001506)], BW: [Enabled, t: (0.000007,0.000001)], RBL DNSBL: [Disabled], APM: [Enabled, Score: 500, t: (0.002528), Flags: 85D2ED72; NN_NO_CONTENT_TYPE; NN_NO_LINK_NMD; NN_LEGIT_BITDEFENDER; NN_LEGIT_S_SQARE_BRACKETS; NN_LEGIT_MAILING_LIST_TO], SGN: [Enabled, t: (0.018948)], URL: [Enabled, t: (0.000005)], RTDA: [Enabled, t: (0.012843), Hit: No, Details: v2.3.10; Id: 2m1gheo.1apn4djpa.dp1s], total: 0(775) X-BitDefender-CF-Stamp: none Cc: tamas@tklengyel.com, Razvan Cojocaru Subject: [Xen-devel] [PATCH V2] common/vm_event: synchronize vCPU state in vm_event_resume() X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Vm_event_vcpu_pause() needs to use vcpu_pause_nosync() in order for the current vCPU to not get stuck. A consequence of this is that the custom vm_event response handlers will not always see the real vCPU state in v->arch.user_regs. This patch makes sure that the state is always synchronized in vm_event_resume, before any handlers have been called. This problem especially affects vm_event_set_registers(). Signed-off-by: Razvan Cojocaru --- Changes since V1: - Only call sync_vcpu_execstate() when the vCPU is paused. --- xen/common/vm_event.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/xen/common/vm_event.c b/xen/common/vm_event.c index 941345b..53cab90 100644 --- a/xen/common/vm_event.c +++ b/xen/common/vm_event.c @@ -388,6 +388,13 @@ void vm_event_resume(struct domain *d, struct vm_event_domain *ved) v = d->vcpu[rsp.vcpu_id]; /* + * Make sure the vCPU state has been synchronized for the custom + * handlers. + */ + if ( atomic_read(&v->vm_event_pause_count) ) + sync_vcpu_execstate(v); + + /* * In some cases the response type needs extra handling, so here * we call the appropriate handlers. */