diff mbox

[7/9] x86/mtrr: drop unused positive_have_wrcomb()

Message ID 1471390109-10407-8-git-send-email-cardoe@cardoe.com (mailing list archive)
State New, archived
Headers show

Commit Message

Douglas Goldstein Aug. 16, 2016, 11:28 p.m. UTC 
Unused function, gone.

Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
---
 xen/arch/x86/cpu/mtrr/generic.c | 5 -----
 xen/arch/x86/cpu/mtrr/mtrr.h    | 2 --
 2 files changed, 7 deletions(-)

Comments

Jan Beulich Aug. 17, 2016, 1:21 p.m. UTC | #1 
>>> On 17.08.16 at 01:28, <cardoe@cardoe.com> wrote:
> Unused function, gone.
> 
> Signed-off-by: Doug Goldstein <cardoe@cardoe.com>

Acked-by: Jan Beulich <jbeulich@suse.com>

But perhaps worth getting folded into the one dropping have_wrcomb()
(the acks for both patches can be retained for the merged result).

Jan
diff mbox

Patch

diff --git a/xen/arch/x86/cpu/mtrr/generic.c b/xen/arch/x86/cpu/mtrr/generic.c
index 1d67035..012aca4 100644
--- a/xen/arch/x86/cpu/mtrr/generic.c
+++ b/xen/arch/x86/cpu/mtrr/generic.c
@@ -555,8 +555,3 @@  int mtrr_generic_have_wrcomb(void)
 	rdmsrl(MSR_MTRRcap, config);
 	return (config & (1ULL << 10));
 }
-
-int positive_have_wrcomb(void)
-{
-	return 1;
-}
diff --git a/xen/arch/x86/cpu/mtrr/mtrr.h b/xen/arch/x86/cpu/mtrr/mtrr.h
index 9391fc5..9405cbc 100644
--- a/xen/arch/x86/cpu/mtrr/mtrr.h
+++ b/xen/arch/x86/cpu/mtrr/mtrr.h
@@ -22,8 +22,6 @@  void mtrr_generic_set(unsigned int reg, unsigned long base,
         unsigned long size, mtrr_type type);
 int mtrr_generic_have_wrcomb(void);
 
-extern int positive_have_wrcomb(void);
-
 /* library functions for processor-specific routines */
 struct set_mtrr_context {
 	unsigned long flags;