From patchwork Mon Aug 29 06:48:45 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Juergen Gross X-Patchwork-Id: 9303117 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 627F66086B for ; Mon, 29 Aug 2016 06:52:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 67A8528797 for ; Mon, 29 Aug 2016 06:52:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5C45D2880D; Mon, 29 Aug 2016 06:52:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 0D22E287EA for ; Mon, 29 Aug 2016 06:52:13 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1beGOC-000212-Qi; Mon, 29 Aug 2016 06:49:48 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1beGOB-0001zw-0N for xen-devel@lists.xenproject.org; Mon, 29 Aug 2016 06:49:47 +0000 Received: from [85.158.137.68] by server-12.bemta-3.messagelabs.com id 23/0C-09160-A0BD3C75; Mon, 29 Aug 2016 06:49:46 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrKLMWRWlGSWpSXmKPExsVyuP0Ovy7n7cP hBl3ntC2+b5nM5MDocfjDFZYAxijWzLyk/IoE1oxLP1YwFlwTqLj+cwNLA+Mr3i5GTg4JASOJ txP/MXUxcnEICSxklPj4t5kZJMEmoCqx4fopVhBbRMBRYnXbUlaQImaBGcwSDV17mUASwgIJE lcePwCzWYAajh9rByri4OAVsJdo7iyGWCAncX3mdLASTgEHiZ9bG8DmCwGVbL90jWUCI/cCRo ZVjOrFqUVlqUW6pnpJRZnpGSW5iZk5uoYGxnq5qcXFiempOYlJxXrJ+bmbGIHerWdgYNzBePm r0yFGSQ4mJVHeOyIHw4X4kvJTKjMSizPii0pzUosPMcpwcChJ8B65eThcSLAoNT21Ii0zBxhm MGkJDh4lEd4QkDRvcUFibnFmOkTqFKOilDjvNJCEAEgiozQPrg0W2pcYZaWEeRkZGBiEeApSi 3IzS1DlXzGKczAqCfNOAZnCk5lXAjf9FdBiJqDFDK/3gywuSURISTUw2r3htP4RsWlhxLP1nP 513gZFR4Kzc29PDDwiH23DtWp5ytKEK/GnPoVazjF/LWDd5Hh/ze+dkR5suvourTdO5p48NC3 W83omn+lXeeGo87Y/b09pkfpvdzWy69tjrXMf+zc25Nexi/YHKzHHVrArfvnWbxo7sV3f1sRK U+hHvF5NmY68xU8lluKMREMt5qLiRADH4si/aAIAAA== X-Env-Sender: jgross@suse.com X-Msg-Ref: server-4.tower-31.messagelabs.com!1472453385!7587109!1 X-Originating-IP: [195.135.220.15] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 8.84; banners=-,-,- X-VirusChecked: Checked Received: (qmail 36721 invoked from network); 29 Aug 2016 06:49:45 -0000 Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by server-4.tower-31.messagelabs.com with DHE-RSA-CAMELLIA256-SHA encrypted SMTP; 29 Aug 2016 06:49:45 -0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id CE471AC27; Mon, 29 Aug 2016 06:49:42 +0000 (UTC) From: Juergen Gross To: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Date: Mon, 29 Aug 2016 08:48:45 +0200 Message-Id: <1472453327-19050-5-git-send-email-jgross@suse.com> X-Mailer: git-send-email 2.6.6 In-Reply-To: <1472453327-19050-1-git-send-email-jgross@suse.com> References: <1472453327-19050-1-git-send-email-jgross@suse.com> Cc: Juergen Gross , jeremy@goop.org, jdelvare@suse.com, peterz@infradead.org, hpa@zytor.com, akataria@vmware.com, x86@kernel.org, rusty@rustcorp.com.au, virtualization@lists.linux-foundation.org, chrisw@sous-sol.org, mingo@redhat.com, david.vrabel@citrix.com, Douglas_Warzecha@dell.com, pali.rohar@gmail.com, boris.ostrovsky@oracle.com, tglx@linutronix.de, linux@roeck-us.net Subject: [Xen-devel] [PATCH v6 4/6] xen: add xen_pin_vcpu() to support calling functions on a dedicated pcpu X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Some hardware models (e.g. Dell Studio 1555 laptops) require calls to the firmware to be issued on cpu 0 only. As Dom0 might have to use these calls, add xen_pin_vcpu() to achieve this functionality. In case either the domain doesn't have the privilege to make the related hypercall or the hypervisor isn't supporting it, issue a warning once and disable further pinning attempts. Signed-off-by: Juergen Gross Acked-by: David Vrabel --- V5: less wordy messages as requested by David Vrabel --- arch/x86/xen/enlighten.c | 40 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 40 insertions(+) diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c index b86ebb1..bc9aaba 100644 --- a/arch/x86/xen/enlighten.c +++ b/arch/x86/xen/enlighten.c @@ -1925,6 +1925,45 @@ static void xen_set_cpu_features(struct cpuinfo_x86 *c) } } +static void xen_pin_vcpu(int cpu) +{ + static bool disable_pinning; + struct sched_pin_override pin_override; + int ret; + + if (disable_pinning) + return; + + pin_override.pcpu = cpu; + ret = HYPERVISOR_sched_op(SCHEDOP_pin_override, &pin_override); + + /* Ignore errors when removing override. */ + if (cpu < 0) + return; + + switch (ret) { + case -ENOSYS: + pr_warn("Unable to pin on physical cpu %d. In case of problems consider vcpu pinning.\n", + cpu); + disable_pinning = true; + break; + case -EPERM: + WARN(1, "Trying to pin vcpu without having privilege to do so\n"); + disable_pinning = true; + break; + case -EINVAL: + case -EBUSY: + pr_warn("Physical cpu %d not available for pinning. Check Xen cpu configuration.\n", + cpu); + break; + case 0: + break; + default: + WARN(1, "rc %d while trying to pin vcpu\n", ret); + disable_pinning = true; + } +} + const struct hypervisor_x86 x86_hyper_xen = { .name = "Xen", .detect = xen_platform, @@ -1933,6 +1972,7 @@ const struct hypervisor_x86 x86_hyper_xen = { #endif .x2apic_available = xen_x2apic_para_available, .set_cpu_features = xen_set_cpu_features, + .pin_vcpu = xen_pin_vcpu, }; EXPORT_SYMBOL(x86_hyper_xen);