From patchwork Thu Sep 1 19:21:47 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Cooper X-Patchwork-Id: 9309543 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1BA0860756 for ; Thu, 1 Sep 2016 19:24:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E1A34294D5 for ; Thu, 1 Sep 2016 19:24:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D614F29504; Thu, 1 Sep 2016 19:24:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 371D3294D5 for ; Thu, 1 Sep 2016 19:24:15 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bfXYp-0008UG-EW; Thu, 01 Sep 2016 19:22:03 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bfXYo-0008U8-Kh for xen-devel@lists.xen.org; Thu, 01 Sep 2016 19:22:02 +0000 Received: from [85.158.137.68] by server-7.bemta-3.messagelabs.com id 7C/2E-03271-9DF78C75; Thu, 01 Sep 2016 19:22:01 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprEIsWRWlGSWpSXmKPExsXitHRDpO7N+hP hBj8XyVos+biYxYHR4+ju30wBjFGsmXlJ+RUJrBnXXi9iLNjDUdH09CFrA+Ni9i5GTg4JAX+J 30e2MYPYbAL6ErtffGICsUUE1CVOd1xk7WLk4mAWmM4osb5jESNIQlggTuLSr9VgRSwCKhJbL mwGa+YV8JT4f20L1FA5ifPHf4LFOQW8JN79+g3WKwRUs/DwEhYIW03iWv8ldoheQYmTM5+AxZ kFJCQOvnjBDDGHW+L26anMExj5ZiEpm4WkbAEj0ypGjeLUorLUIl1DC72kosz0jJLcxMwcXUM DY73c1OLixPTUnMSkYr3k/NxNjMCwqmdgYNzB+Pu05yFGSQ4mJVHe/fknwoX4kvJTKjMSizPi i0pzUosPMcpwcChJ8LLUAeUEi1LTUyvSMnOAAQ6TluDgURLhbQdJ8xYXJOYWZ6ZDpE4xKkqJ8 x4CSQiAJDJK8+DaYFF1iVFWSpiXkYGBQYinILUoN7MEVf4VozgHo5Iw7y2QKTyZeSVw018BLW YCWlxy7TjI4pJEhJRUA6OCSd7Cr58cZj9r8tLN+5plHm3iYnd6e15R6lrh32zbxeqv1W/Rm7D vozlDuOynb5dcOZafWr/27YsjT1JyTqU3/DnWwqcm/Umz2fGe074MuRamIsPD+1VeGX1T/LnT 4dJzndz7Qc897noGmFd7rredZ++/Wu/CO4ZJq71Xhrbxtp8zZD/jpanEUpyRaKjFXFScCADyM l23pQIAAA== X-Env-Sender: prvs=0454396dc=Andrew.Cooper3@citrix.com X-Msg-Ref: server-10.tower-31.messagelabs.com!1472757719!57849085!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 8.84; banners=-,-,- X-VirusChecked: Checked Received: (qmail 60935 invoked from network); 1 Sep 2016 19:22:00 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-10.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 1 Sep 2016 19:22:00 -0000 X-IronPort-AV: E=Sophos;i="5.30,268,1470700800"; d="scan'208";a="375841451" From: Andrew Cooper To: Xen-devel Date: Thu, 1 Sep 2016 20:21:47 +0100 Message-ID: <1472757707-11885-2-git-send-email-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1472757707-11885-1-git-send-email-andrew.cooper3@citrix.com> References: <1472757707-11885-1-git-send-email-andrew.cooper3@citrix.com> MIME-Version: 1.0 X-DLP: MIA2 Cc: George Dunlap , Andrew Cooper , Tim Deegan , Jan Beulich Subject: [Xen-devel] [PATCH 2/2] xen/trace: Turn the stub debugtrace_{dump, printk}() macros into functions X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP This allows printf format checking to be performed, and for debugtrace_printk() to evaluate its arguments, even if debugtrace is disabled at compile time. No intended change. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich --- CC: Jan Beulich CC: Tim Deegan CC: George Dunlap --- xen/include/xen/lib.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/xen/include/xen/lib.h b/xen/include/xen/lib.h index d04864e..0008d63 100644 --- a/xen/include/xen/lib.h +++ b/xen/include/xen/lib.h @@ -68,8 +68,10 @@ extern void debugtrace_dump(void); extern void debugtrace_printk(const char *fmt, ...) __attribute__ ((format (printf, 1, 2))); #else -#define debugtrace_dump() ((void)0) -#define debugtrace_printk(_f, ...) ((void)0) +static inline void debugtrace_dump(void) {}; +static inline void + __attribute__ ((format (printf, 1, 2))) +debugtrace_printk(const char *fmt, ...) {}; #endif /* Allows us to use '%p' as general-purpose machine-word format char. */