diff mbox

xen/arm: smpboot: drop unneeded code when identifying cpuinfo

Message ID 1472809301-31011-1-git-send-email-peng.fan@nxp.com (mailing list archive)
State New, archived
Headers show

Commit Message

Peng Fan Sept. 2, 2016, 9:41 a.m. UTC 
The current_cpu_data indicates the cpuinfo for the current cpu.
There is no need to fill the current_cpu_data from boot_cpu_data,
because the following call to identify_cpu will override it.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
Cc: Julien Grall <julien.grall@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>
---
 xen/arch/arm/smpboot.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Julien Grall Sept. 9, 2016, 4:38 p.m. UTC | #1 
Hello Peng,

On 02/09/16 10:41, Peng Fan wrote:
> The current_cpu_data indicates the cpuinfo for the current cpu.
> There is no need to fill the current_cpu_data from boot_cpu_data,
> because the following call to identify_cpu will override it.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> Cc: Julien Grall <julien.grall@arm.com>
> Cc: Stefano Stabellini <sstabellini@kernel.org>

Acked-by: Julien Grall <julien.grall@arm.com>

Regards,

> ---
>  xen/arch/arm/smpboot.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c
> index d56b91d..90ad1d0 100644
> --- a/xen/arch/arm/smpboot.c
> +++ b/xen/arch/arm/smpboot.c
> @@ -288,7 +288,6 @@ void start_secondary(unsigned long boot_phys_offset,
>
>      set_processor_id(cpuid);
>
> -    current_cpu_data = boot_cpu_data;
>      identify_cpu(&current_cpu_data);
>
>      init_traps();
>
diff mbox

Patch

diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c
index d56b91d..90ad1d0 100644
--- a/xen/arch/arm/smpboot.c
+++ b/xen/arch/arm/smpboot.c
@@ -288,7 +288,6 @@  void start_secondary(unsigned long boot_phys_offset,
 
     set_processor_id(cpuid);
 
-    current_cpu_data = boot_cpu_data;
     identify_cpu(&current_cpu_data);
 
     init_traps();