diff mbox

mini-os: add comments in Config.mk regarding new config options

Message ID 1473075810-2510-1-git-send-email-jgross@suse.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jürgen Groß Sept. 5, 2016, 11:43 a.m. UTC
Add some comment in Config.mk what to do in case of adding new config
options.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 Config.mk | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Samuel Thibault Sept. 5, 2016, 1:23 p.m. UTC | #1
Juergen Gross, on Mon 05 Sep 2016 13:43:30 +0200, wrote:
> Add some comment in Config.mk what to do in case of adding new config
> options.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

> ---
>  Config.mk | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Config.mk b/Config.mk
> index 0e405bf..0baedd1 100644
> --- a/Config.mk
> +++ b/Config.mk
> @@ -152,6 +152,11 @@ CFLAGS += -flto
>  LDFLAGS-$(clang) += -plugin LLVMgold.so
>  endif
>  
> +# When adding a new CONFIG_ option please make sure the test configurations
> +# under arch/*/testbuild/ are updated accordingly. Especially
> +# arch/*/testbuild/*-yes and arch/*/testbuild/*-no should set ALL possible
> +# CONFIG_ variables.
> +
>  # Configuration defaults
>  ifeq ($(TARGET_ARCH_FAM),x86)
>  CONFIG_PARAVIRT ?= y
> -- 
> 2.6.6
>
Wei Liu Sept. 5, 2016, 1:47 p.m. UTC | #2
On Mon, Sep 05, 2016 at 03:23:10PM +0200, Samuel Thibault wrote:
> Juergen Gross, on Mon 05 Sep 2016 13:43:30 +0200, wrote:
> > Add some comment in Config.mk what to do in case of adding new config
> > options.
> > 
> > Signed-off-by: Juergen Gross <jgross@suse.com>
> 
> Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> 

Pushed.
diff mbox

Patch

diff --git a/Config.mk b/Config.mk
index 0e405bf..0baedd1 100644
--- a/Config.mk
+++ b/Config.mk
@@ -152,6 +152,11 @@  CFLAGS += -flto
 LDFLAGS-$(clang) += -plugin LLVMgold.so
 endif
 
+# When adding a new CONFIG_ option please make sure the test configurations
+# under arch/*/testbuild/ are updated accordingly. Especially
+# arch/*/testbuild/*-yes and arch/*/testbuild/*-no should set ALL possible
+# CONFIG_ variables.
+
 # Configuration defaults
 ifeq ($(TARGET_ARCH_FAM),x86)
 CONFIG_PARAVIRT ?= y