From patchwork Wed Sep 7 18:59:14 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Boris Ostrovsky X-Patchwork-Id: 9319809 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 650C160752 for ; Wed, 7 Sep 2016 19:07:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5CA9929416 for ; Wed, 7 Sep 2016 19:07:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4D06929417; Wed, 7 Sep 2016 19:07:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 9051E29417 for ; Wed, 7 Sep 2016 19:07:47 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bhiAA-0004IP-4w; Wed, 07 Sep 2016 19:05:34 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bhiA8-0004Ff-9e for xen-devel@lists.xen.org; Wed, 07 Sep 2016 19:05:32 +0000 Received: from [85.158.139.211] by server-9.bemta-5.messagelabs.com id 05/82-13924-BF460D75; Wed, 07 Sep 2016 19:05:31 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrHLMWRWlGSWpSXmKPExsXSO6nOVfdXyoV wg88X9SyWfFzM4sDocXT3b6YAxijWzLyk/IoE1oz/p7pYC1YrVZx9vpalgfG1RBcjF4eQwCQm iRmvl7JCOJ8ZJdZPa2GBcDYwSlzteACV6WGUmDVvJ5DDycEmYCRx9uh0RhBbREBa4trny4wgR cwClxgl5l08zgSSEBYIkFi4eipYEYuAqsSNlgfMIDavgJfEs9sHwQZJCChITHn4HizOKeAtsf HLYXYQWwio5v2TVcwQNcYS7W8vsk1g5FvAyLCKUaM4tagstUjXyEgvqSgzPaMkNzEzR9fQwFQ vN7W4ODE9NScxqVgvOT93EyMwXOoZGBh3MO5p9zvEKMnBpCTKu431QrgQX1J+SmVGYnFGfFFp TmrxIUYZDg4lCd6uZKCcYFFqempFWmYOMHBh0hIcPEoivBtB0rzFBYm5xZnpEKlTjIpS4rzLQ BICIImM0jy4Nli0XGKUlRLmZWRgYBDiKUgtys0sQZV/xSjOwagkzFsFMoUnM68EbvoroMVMQI uFTp0HWVySiJCSamDMsZ7T57BLtDHT6UvsvtrghMkrU15x3HDuP8q9Rlr+g5m+bGSrd0dUtHC Kwxor0Surr9+z+lSw64awX8kmGRPTrhWxE77F5BzqTBXVcT/5iF8/fkbtgoCbPh4e2r8SY4Uv cu9NvK62Tjz+acUNCUnPBJbtohOmG/5OWX3ofPvBBfn/vq1Ydl2JpTgj0VCLuag4EQBdJYN+k QIAAA== X-Env-Sender: boris.ostrovsky@oracle.com X-Msg-Ref: server-4.tower-206.messagelabs.com!1473275129!58413030!1 X-Originating-IP: [141.146.126.69] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogMTQxLjE0Ni4xMjYuNjkgPT4gMjc3MjE4\n X-StarScan-Received: X-StarScan-Version: 8.84; banners=-,-,- X-VirusChecked: Checked Received: (qmail 34503 invoked from network); 7 Sep 2016 19:05:30 -0000 Received: from aserp1040.oracle.com (HELO aserp1040.oracle.com) (141.146.126.69) by server-4.tower-206.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 7 Sep 2016 19:05:30 -0000 Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u87J5KEo026869 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 7 Sep 2016 19:05:20 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id u87J5J9L004170 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 7 Sep 2016 19:05:19 GMT Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by userv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u87J5Dqo009600; Wed, 7 Sep 2016 19:05:18 GMT Received: from ovs104.us.oracle.com (/10.149.76.204) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 07 Sep 2016 12:05:07 -0700 From: Boris Ostrovsky To: xen-devel@lists.xen.org Date: Wed, 7 Sep 2016 14:59:14 -0400 Message-Id: <1473274769-19129-5-git-send-email-boris.ostrovsky@oracle.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1473274769-19129-1-git-send-email-boris.ostrovsky@oracle.com> References: <1473274769-19129-1-git-send-email-boris.ostrovsky@oracle.com> X-Source-IP: aserv0022.oracle.com [141.146.126.234] Cc: wei.liu2@citrix.com, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, julien.grall@arm.com, jbeulich@suse.com, zhaoshenglong@huawei.com, boris.ostrovsky@oracle.com, roger.pau@citrix.com Subject: [Xen-devel] [PATCH v3 04/19] acpi/hvmloader: Make providing IOAPIC in MADT optional X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Signed-off-by: Boris Ostrovsky Reviewed-by: Jan Beulich --- tools/firmware/hvmloader/acpi/build.c | 70 ++++++++++++++++++--------------- tools/firmware/hvmloader/acpi/libacpi.h | 1 + tools/firmware/hvmloader/util.c | 2 +- 3 files changed, 40 insertions(+), 33 deletions(-) diff --git a/tools/firmware/hvmloader/acpi/build.c b/tools/firmware/hvmloader/acpi/build.c index 80386b9..7e7c11f 100644 --- a/tools/firmware/hvmloader/acpi/build.c +++ b/tools/firmware/hvmloader/acpi/build.c @@ -99,43 +99,49 @@ static struct acpi_20_madt *construct_madt(const struct acpi_config *config, madt->lapic_addr = LAPIC_BASE_ADDRESS; madt->flags = ACPI_PCAT_COMPAT; - intsrcovr = (struct acpi_20_madt_intsrcovr *)(madt + 1); - for ( i = 0; i < 16; i++ ) - { - memset(intsrcovr, 0, sizeof(*intsrcovr)); - intsrcovr->type = ACPI_INTERRUPT_SOURCE_OVERRIDE; - intsrcovr->length = sizeof(*intsrcovr); - intsrcovr->source = i; - - if ( i == 0 ) - { - /* ISA IRQ0 routed to IOAPIC GSI 2. */ - intsrcovr->gsi = 2; - intsrcovr->flags = 0x0; - } - else if ( PCI_ISA_IRQ_MASK & (1U << i) ) - { - /* PCI: active-low level-triggered. */ - intsrcovr->gsi = i; - intsrcovr->flags = 0xf; - } - else + if ( config->table_flags & ACPI_HAS_IOAPIC ) + { + intsrcovr = (struct acpi_20_madt_intsrcovr *)(madt + 1); + for ( i = 0; i < 16; i++ ) { - /* No need for a INT source override structure. */ - continue; + memset(intsrcovr, 0, sizeof(*intsrcovr)); + intsrcovr->type = ACPI_INTERRUPT_SOURCE_OVERRIDE; + intsrcovr->length = sizeof(*intsrcovr); + intsrcovr->source = i; + + if ( i == 0 ) + { + /* ISA IRQ0 routed to IOAPIC GSI 2. */ + intsrcovr->gsi = 2; + intsrcovr->flags = 0x0; + } + else if ( PCI_ISA_IRQ_MASK & (1U << i) ) + { + /* PCI: active-low level-triggered. */ + intsrcovr->gsi = i; + intsrcovr->flags = 0xf; + } + else + { + /* No need for a INT source override structure. */ + continue; + } + + intsrcovr++; } - intsrcovr++; - } + io_apic = (struct acpi_20_madt_ioapic *)intsrcovr; + memset(io_apic, 0, sizeof(*io_apic)); + io_apic->type = ACPI_IO_APIC; + io_apic->length = sizeof(*io_apic); + io_apic->ioapic_id = IOAPIC_ID; + io_apic->ioapic_addr = ioapic_base_address; - io_apic = (struct acpi_20_madt_ioapic *)intsrcovr; - memset(io_apic, 0, sizeof(*io_apic)); - io_apic->type = ACPI_IO_APIC; - io_apic->length = sizeof(*io_apic); - io_apic->ioapic_id = IOAPIC_ID; - io_apic->ioapic_addr = ioapic_base_address; + lapic = (struct acpi_20_madt_lapic *)(io_apic + 1); + } + else + lapic = (struct acpi_20_madt_lapic *)(madt + 1); - lapic = (struct acpi_20_madt_lapic *)(io_apic + 1); info->nr_cpus = hvminfo->nr_vcpus; info->madt_lapic0_addr = (uint32_t)lapic; for ( i = 0; i < hvminfo->nr_vcpus; i++ ) diff --git a/tools/firmware/hvmloader/acpi/libacpi.h b/tools/firmware/hvmloader/acpi/libacpi.h index cc57a9c..b089cc5 100644 --- a/tools/firmware/hvmloader/acpi/libacpi.h +++ b/tools/firmware/hvmloader/acpi/libacpi.h @@ -30,6 +30,7 @@ #define ACPI_HAS_SSDT_S3 (1<<5) #define ACPI_HAS_SSDT_S4 (1<<6) #define ACPI_HAS_TCPA (1<<7) +#define ACPI_HAS_IOAPIC (1<<8) struct acpi_numa { diff --git a/tools/firmware/hvmloader/util.c b/tools/firmware/hvmloader/util.c index 8875675..aa5fc20 100644 --- a/tools/firmware/hvmloader/util.c +++ b/tools/firmware/hvmloader/util.c @@ -919,7 +919,7 @@ void hvmloader_acpi_build_tables(struct acpi_config *config, if ( !strncmp(xenstore_read("platform/acpi_s4", "1"), "1", 1) ) config->table_flags |= ACPI_HAS_SSDT_S4; - config->table_flags |= ACPI_HAS_TCPA; + config->table_flags |= (ACPI_HAS_TCPA | ACPI_HAS_IOAPIC); config->tis_hdr = (uint16_t *)ACPI_TIS_HDR_ADDRESS;