diff mbox

[1/2] tools/libxc: Don't leak foreign mappings when loading modules

Message ID 1475229664-10992-1-git-send-email-andrew.cooper3@citrix.com (mailing list archive)
State New, archived
Headers show

Commit Message

Andrew Cooper Sept. 30, 2016, 10:01 a.m. UTC 
Spotted by Coverity

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
CC: Wei Liu <wei.liu2@citrix.com>
CC: Boris Ostrovsky <boris.ostrovsky@oracle.com>
---
 tools/libxc/xc_dom_core.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Wei Liu Sept. 30, 2016, 10:15 a.m. UTC | #1 
On Fri, Sep 30, 2016 at 11:01:03AM +0100, Andrew Cooper wrote:
> Spotted by Coverity
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Wei Liu <wei.liu2@citrix.com>

> ---
> CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
> CC: Wei Liu <wei.liu2@citrix.com>
> CC: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> ---
>  tools/libxc/xc_dom_core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/libxc/xc_dom_core.c b/tools/libxc/xc_dom_core.c
> index 5326d36..e177667 100644
> --- a/tools/libxc/xc_dom_core.c
> +++ b/tools/libxc/xc_dom_core.c
> @@ -1119,6 +1119,7 @@ static int xc_dom_load_acpi(struct xc_dom_image *dom)
>          }
>  
>          memcpy(ptr, dom->acpi_modules[i].data, dom->acpi_modules[i].length);
> +        munmap(ptr, XC_PAGE_SIZE * num_pages);
>  
>          free(extents);
>          i++;
> -- 
> 2.1.4
>
diff mbox

Patch

diff --git a/tools/libxc/xc_dom_core.c b/tools/libxc/xc_dom_core.c
index 5326d36..e177667 100644
--- a/tools/libxc/xc_dom_core.c
+++ b/tools/libxc/xc_dom_core.c
@@ -1119,6 +1119,7 @@  static int xc_dom_load_acpi(struct xc_dom_image *dom)
         }
 
         memcpy(ptr, dom->acpi_modules[i].data, dom->acpi_modules[i].length);
+        munmap(ptr, XC_PAGE_SIZE * num_pages);
 
         free(extents);
         i++;