| Message ID | 1475503368-22878-1-git-send-email-vkuznets@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Oct 03, 2016 at 04:02:48PM +0200, Vitaly Kuznetsov wrote: > XEN_TMEM config option has no prompt and it is enabled as module by > default if CLEANCACHE or FRONTSWAP options are set with no way to disable > it. The only in-tree user of the tmem interface is xen-selfballoon which And if CONFIG_XEN=y . > can itself be disabled so it makes sense to make it possible to disable During boot-time with arguments. > XEN_TMEM too. In theory, both these options could be unified under the > XEN_SELFBALLOONING but other (out-of-tree) users of the tmem interface > may exist and someone may want to keep them supported without enabling > XEN_SELFBALLOONING. I think going the route of XEN_SELFBALLOONING may be better. > > Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com> > --- > - I don't know much about tmem and its users thus RFC. > --- > drivers/xen/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig > index f15bb3b7..0ea1df8 100644 > --- a/drivers/xen/Kconfig > +++ b/drivers/xen/Kconfig > @@ -166,7 +166,7 @@ config SWIOTLB_XEN > select SWIOTLB > > config XEN_TMEM > - tristate > + tristate "Transcendent Memory support for Xen" > depends on !ARM && !ARM64 > default m if (CLEANCACHE || FRONTSWAP) > help > -- > 2.7.4 > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > https://lists.xen.org/xen-devel
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> writes: > On Mon, Oct 03, 2016 at 04:02:48PM +0200, Vitaly Kuznetsov wrote: >> XEN_TMEM config option has no prompt and it is enabled as module by >> default if CLEANCACHE or FRONTSWAP options are set with no way to disable >> it. The only in-tree user of the tmem interface is xen-selfballoon which > > And if CONFIG_XEN=y . > Yes, of course) >> can itself be disabled so it makes sense to make it possible to disable > > During boot-time with arguments. I see, I rather meant we need a way to disable building the module, not just loading it. >> XEN_TMEM too. In theory, both these options could be unified under the >> XEN_SELFBALLOONING but other (out-of-tree) users of the tmem interface >> may exist and someone may want to keep them supported without enabling >> XEN_SELFBALLOONING. > > I think going the route of XEN_SELFBALLOONING may be better. Ok, if you say so) >> >> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com> >> --- >> - I don't know much about tmem and its users thus RFC. >> --- >> drivers/xen/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig >> index f15bb3b7..0ea1df8 100644 >> --- a/drivers/xen/Kconfig >> +++ b/drivers/xen/Kconfig >> @@ -166,7 +166,7 @@ config SWIOTLB_XEN >> select SWIOTLB >> >> config XEN_TMEM >> - tristate >> + tristate "Transcendent Memory support for Xen" >> depends on !ARM && !ARM64 >> default m if (CLEANCACHE || FRONTSWAP) >> help >> -- >> 2.7.4 >> >> >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xen.org >> https://lists.xen.org/xen-devel
diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig index f15bb3b7..0ea1df8 100644 --- a/drivers/xen/Kconfig +++ b/drivers/xen/Kconfig @@ -166,7 +166,7 @@ config SWIOTLB_XEN select SWIOTLB config XEN_TMEM - tristate + tristate "Transcendent Memory support for Xen" depends on !ARM && !ARM64 default m if (CLEANCACHE || FRONTSWAP) help
XEN_TMEM config option has no prompt and it is enabled as module by default if CLEANCACHE or FRONTSWAP options are set with no way to disable it. The only in-tree user of the tmem interface is xen-selfballoon which can itself be disabled so it makes sense to make it possible to disable XEN_TMEM too. In theory, both these options could be unified under the XEN_SELFBALLOONING but other (out-of-tree) users of the tmem interface may exist and someone may want to keep them supported without enabling XEN_SELFBALLOONING. Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com> --- - I don't know much about tmem and its users thus RFC. --- drivers/xen/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)