| Message ID | 1475771791-9749-2-git-send-email-edgar.iglesias@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Oct 6, 2016 at 9:36 AM, Edgar E. Iglesias <edgar.iglesias@gmail.com> wrote: > From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com> > > Disable the Cortex-a53-edac. Xen currently does not yet > handle reads/writes to the implementation defined CPUMERRSR > register. > > Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> This solution looks fine to me and everything boots on ZynqMP as expected with this patch. Acked-by: Alistair Francis <alistair.francis@xilinx.com> Thanks, Alistair > --- > xen/arch/arm/domain_build.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index ce97359..e8a400c 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -1188,6 +1188,7 @@ static int handle_node(struct domain *d, struct kernel_info *kinfo, > DT_MATCH_COMPATIBLE("arm,psci-1.0"), > DT_MATCH_COMPATIBLE("arm,cortex-a7-pmu"), > DT_MATCH_COMPATIBLE("arm,cortex-a15-pmu"), > + DT_MATCH_COMPATIBLE("arm,cortex-a53-edac"), > DT_MATCH_COMPATIBLE("arm,armv8-pmuv3"), > DT_MATCH_PATH("/cpus"), > DT_MATCH_TYPE("memory"), > -- > 2.5.0 > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > https://lists.xen.org/xen-devel
On Fri, 7 Oct 2016, Alistair Francis wrote: > On Thu, Oct 6, 2016 at 9:36 AM, Edgar E. Iglesias > <edgar.iglesias@gmail.com> wrote: > > From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com> > > > > Disable the Cortex-a53-edac. Xen currently does not yet > > handle reads/writes to the implementation defined CPUMERRSR > > register. > > > > Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> > > This solution looks fine to me and everything boots on ZynqMP as > expected with this patch. > > Acked-by: Alistair Francis <alistair.francis@xilinx.com> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> Wei, can we have this in 4.8? See the 0/1 email for an explanation of why this change is needed. The patch just adds the troublesome cortex-a15-pmu to the "skip_matches" array to remove it from dom0's device tree. > > --- > > xen/arch/arm/domain_build.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > > index ce97359..e8a400c 100644 > > --- a/xen/arch/arm/domain_build.c > > +++ b/xen/arch/arm/domain_build.c > > @@ -1188,6 +1188,7 @@ static int handle_node(struct domain *d, struct kernel_info *kinfo, > > DT_MATCH_COMPATIBLE("arm,psci-1.0"), > > DT_MATCH_COMPATIBLE("arm,cortex-a7-pmu"), > > DT_MATCH_COMPATIBLE("arm,cortex-a15-pmu"), > > + DT_MATCH_COMPATIBLE("arm,cortex-a53-edac"), > > DT_MATCH_COMPATIBLE("arm,armv8-pmuv3"), > > DT_MATCH_PATH("/cpus"), > > DT_MATCH_TYPE("memory"), > > -- > > 2.5.0 > > > > > > _______________________________________________ > > Xen-devel mailing list > > Xen-devel@lists.xen.org > > https://lists.xen.org/xen-devel >
On Fri, Oct 07, 2016 at 10:34:15AM -0700, Stefano Stabellini wrote: > On Fri, 7 Oct 2016, Alistair Francis wrote: > > On Thu, Oct 6, 2016 at 9:36 AM, Edgar E. Iglesias > > <edgar.iglesias@gmail.com> wrote: > > > From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com> > > > > > > Disable the Cortex-a53-edac. Xen currently does not yet > > > handle reads/writes to the implementation defined CPUMERRSR > > > register. > > > > > > Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> > > > > This solution looks fine to me and everything boots on ZynqMP as > > expected with this patch. > > > > Acked-by: Alistair Francis <alistair.francis@xilinx.com> > > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> > > Wei, can we have this in 4.8? See the 0/1 email for an explanation of > why this change is needed. The patch just adds the troublesome > cortex-a15-pmu to the "skip_matches" array to remove it from dom0's > device tree. > Sure.
On Fri, Oct 07, 2016 at 07:22:33PM +0100, Wei Liu wrote: > On Fri, Oct 07, 2016 at 10:34:15AM -0700, Stefano Stabellini wrote: > > On Fri, 7 Oct 2016, Alistair Francis wrote: > > > On Thu, Oct 6, 2016 at 9:36 AM, Edgar E. Iglesias > > > <edgar.iglesias@gmail.com> wrote: > > > > From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com> > > > > > > > > Disable the Cortex-a53-edac. Xen currently does not yet > > > > handle reads/writes to the implementation defined CPUMERRSR > > > > register. > > > > > > > > Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> > > > > > > This solution looks fine to me and everything boots on ZynqMP as > > > expected with this patch. > > > > > > Acked-by: Alistair Francis <alistair.francis@xilinx.com> > > > > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> > > > > Wei, can we have this in 4.8? See the 0/1 email for an explanation of > > why this change is needed. The patch just adds the troublesome > > cortex-a15-pmu to the "skip_matches" array to remove it from dom0's > > device tree. > > > > Sure. Hi Wei, Just a friendly reminder: This is still missing from master, staging and 4.8.0-rc2. Best regards, Edgar
On Wed, Oct 12, 2016 at 03:23:43PM +0200, Edgar E. Iglesias wrote: > On Fri, Oct 07, 2016 at 07:22:33PM +0100, Wei Liu wrote: > > On Fri, Oct 07, 2016 at 10:34:15AM -0700, Stefano Stabellini wrote: > > > On Fri, 7 Oct 2016, Alistair Francis wrote: > > > > On Thu, Oct 6, 2016 at 9:36 AM, Edgar E. Iglesias > > > > <edgar.iglesias@gmail.com> wrote: > > > > > From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com> > > > > > > > > > > Disable the Cortex-a53-edac. Xen currently does not yet > > > > > handle reads/writes to the implementation defined CPUMERRSR > > > > > register. > > > > > > > > > > Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> > > > > > > > > This solution looks fine to me and everything boots on ZynqMP as > > > > expected with this patch. > > > > > > > > Acked-by: Alistair Francis <alistair.francis@xilinx.com> > > > > > > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> > > > > > > Wei, can we have this in 4.8? See the 0/1 email for an explanation of > > > why this change is needed. The patch just adds the troublesome > > > cortex-a15-pmu to the "skip_matches" array to remove it from dom0's > > > device tree. > > > > > > > Sure. > > > Hi Wei, > > Just a friendly reminder: > This is still missing from master, staging and 4.8.0-rc2. > I thought Stefano would do it. I will apply this shortly. Thanks for the heads-up. Wei. > Best regards, > Edgar
On Wed, Oct 12, 2016 at 02:47:18PM +0100, Wei Liu wrote: > On Wed, Oct 12, 2016 at 03:23:43PM +0200, Edgar E. Iglesias wrote: > > On Fri, Oct 07, 2016 at 07:22:33PM +0100, Wei Liu wrote: > > > On Fri, Oct 07, 2016 at 10:34:15AM -0700, Stefano Stabellini wrote: > > > > On Fri, 7 Oct 2016, Alistair Francis wrote: > > > > > On Thu, Oct 6, 2016 at 9:36 AM, Edgar E. Iglesias > > > > > <edgar.iglesias@gmail.com> wrote: > > > > > > From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com> > > > > > > > > > > > > Disable the Cortex-a53-edac. Xen currently does not yet > > > > > > handle reads/writes to the implementation defined CPUMERRSR > > > > > > register. > > > > > > > > > > > > Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> > > > > > > > > > > This solution looks fine to me and everything boots on ZynqMP as > > > > > expected with this patch. > > > > > > > > > > Acked-by: Alistair Francis <alistair.francis@xilinx.com> > > > > > > > > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> > > > > > > > > Wei, can we have this in 4.8? See the 0/1 email for an explanation of > > > > why this change is needed. The patch just adds the troublesome > > > > cortex-a15-pmu to the "skip_matches" array to remove it from dom0's > > > > device tree. > > > > > > > > > > Sure. > > > > > > Hi Wei, > > > > Just a friendly reminder: > > This is still missing from master, staging and 4.8.0-rc2. > > > > I thought Stefano would do it. > > I will apply this shortly. Thanks for the heads-up. > Now applied. Wei. > Wei. > > > Best regards, > > Edgar
On Wed, 12 Oct 2016, Wei Liu wrote: > On Wed, Oct 12, 2016 at 02:47:18PM +0100, Wei Liu wrote: > > On Wed, Oct 12, 2016 at 03:23:43PM +0200, Edgar E. Iglesias wrote: > > > On Fri, Oct 07, 2016 at 07:22:33PM +0100, Wei Liu wrote: > > > > On Fri, Oct 07, 2016 at 10:34:15AM -0700, Stefano Stabellini wrote: > > > > > On Fri, 7 Oct 2016, Alistair Francis wrote: > > > > > > On Thu, Oct 6, 2016 at 9:36 AM, Edgar E. Iglesias > > > > > > <edgar.iglesias@gmail.com> wrote: > > > > > > > From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com> > > > > > > > > > > > > > > Disable the Cortex-a53-edac. Xen currently does not yet > > > > > > > handle reads/writes to the implementation defined CPUMERRSR > > > > > > > register. > > > > > > > > > > > > > > Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> > > > > > > > > > > > > This solution looks fine to me and everything boots on ZynqMP as > > > > > > expected with this patch. > > > > > > > > > > > > Acked-by: Alistair Francis <alistair.francis@xilinx.com> > > > > > > > > > > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> > > > > > > > > > > Wei, can we have this in 4.8? See the 0/1 email for an explanation of > > > > > why this change is needed. The patch just adds the troublesome > > > > > cortex-a15-pmu to the "skip_matches" array to remove it from dom0's > > > > > device tree. > > > > > > > > > > > > > Sure. > > > > > > > > > Hi Wei, > > > > > > Just a friendly reminder: > > > This is still missing from master, staging and 4.8.0-rc2. > > > > > > > I thought Stefano would do it. > > > > I will apply this shortly. Thanks for the heads-up. > > > > Now applied. Thanks Wei. They day I acked it, it was the day you asked not to commit, then I forgot about it :-)
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index ce97359..e8a400c 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -1188,6 +1188,7 @@ static int handle_node(struct domain *d, struct kernel_info *kinfo, DT_MATCH_COMPATIBLE("arm,psci-1.0"), DT_MATCH_COMPATIBLE("arm,cortex-a7-pmu"), DT_MATCH_COMPATIBLE("arm,cortex-a15-pmu"), + DT_MATCH_COMPATIBLE("arm,cortex-a53-edac"), DT_MATCH_COMPATIBLE("arm,armv8-pmuv3"), DT_MATCH_PATH("/cpus"), DT_MATCH_TYPE("memory"),