From patchwork Mon Oct 31 16:48:27 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Juergen Gross X-Patchwork-Id: 9406021 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DE64D60588 for ; Mon, 31 Oct 2016 16:51:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CE5F929341 for ; Mon, 31 Oct 2016 16:51:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C19C12935B; Mon, 31 Oct 2016 16:51:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id F415529341 for ; Mon, 31 Oct 2016 16:51:02 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c1FlZ-0003vS-SC; Mon, 31 Oct 2016 16:48:57 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c1FlY-0003sZ-BV for xen-devel@lists.xen.org; Mon, 31 Oct 2016 16:48:56 +0000 Received: from [85.158.139.211] by server-9.bemta-5.messagelabs.com id 86/CC-01928-7F577185; Mon, 31 Oct 2016 16:48:55 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrALMWRWlGSWpSXmKPExsVyuP0Ov+7XUvE Ig+4+JYslHxezODB6HN39mymAMYo1My8pvyKBNeP4xG2sBUfYK1pXr2VpYNzL1sXIySEhYCTx duI/JhBbSGAho8TL/RwgNpuAqsSG66dYQWwRASuJh/uvgdnMAlESR9p2s3QxcnAIC/hLnHsoA RJmASrf+uYD2BheAQeJj29aGSHGy0lcnzkdLM4JFH+95hozxCp7iYnLDjFPYORewMiwilGjOL WoLLVI18hML6koMz2jJDcxM0fX0MBULze1uDgxPTUnMalYLzk/dxMj0Lf1DAyMOxhvT/Y7xCj JwaQkyvs1TDxCiC8pP6UyI7E4I76oNCe1+BCjDAeHkgTvlxKgnGBRanpqRVpmDjDIYNISHDxK IrxswEAT4i0uSMwtzkyHSJ1i1OV4t/ndAyYhlrz8vFQpcV5WkCIBkKKM0jy4EbCAv8QoKyXMy 8jAwCDEU5BalJtZgir/ilGcg1FJmHcCyCU8mXklcJteAR3BBHREWqEIyBEliQgpqQZGga9KX6 clbJl2aukPWf85ly78EVnkPX+iZ2ZL3S/fKQqHM6O+rFV+5c3AZbPvukv/qhrdi7L1ydvdv1a en564Rfmr3Mnm4O8vy1nO6Z7nWSqfc+jd/VyB5hdNK3a/jDu47O/8nP+STutOdj1mZjGLqg5d ze5uPSGn4WT8udCnb3rXuHUJS6YvUmIpzkg01GIuKk4EADj9O1pzAgAA X-Env-Sender: jgross@suse.com X-Msg-Ref: server-11.tower-206.messagelabs.com!1477932533!55627151!1 X-Originating-IP: [195.135.220.15] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.0.13; banners=-,-,- X-VirusChecked: Checked Received: (qmail 47851 invoked from network); 31 Oct 2016 16:48:53 -0000 Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by server-11.tower-206.messagelabs.com with DHE-RSA-CAMELLIA256-SHA encrypted SMTP; 31 Oct 2016 16:48:53 -0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 2D9A8AD4F; Mon, 31 Oct 2016 16:48:53 +0000 (UTC) From: Juergen Gross To: linux-kernel@vger.kernel.org, xen-devel@lists.xen.org Date: Mon, 31 Oct 2016 17:48:27 +0100 Message-Id: <1477932510-28594-10-git-send-email-jgross@suse.com> X-Mailer: git-send-email 2.6.6 In-Reply-To: <1477932510-28594-1-git-send-email-jgross@suse.com> References: <1477932510-28594-1-git-send-email-jgross@suse.com> Cc: Juergen Gross , boris.ostrovsky@oracle.com, david.vrabel@citrix.com Subject: [Xen-devel] [PATCH 09/12] xen: make use of xenbus_read_unsigned() in xen-scsifront X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Use xenbus_read_unsigned() instead of xenbus_scanf() when possible. Signed-off-by: Juergen Gross --- drivers/scsi/xen-scsifront.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/scsi/xen-scsifront.c b/drivers/scsi/xen-scsifront.c index 9dc8687..7e817c6 100644 --- a/drivers/scsi/xen-scsifront.c +++ b/drivers/scsi/xen-scsifront.c @@ -1060,13 +1060,9 @@ static void scsifront_read_backend_params(struct xenbus_device *dev, struct vscsifrnt_info *info) { unsigned int sg_grant, nr_segs; - int ret; struct Scsi_Host *host = info->host; - ret = xenbus_scanf(XBT_NIL, dev->otherend, "feature-sg-grant", "%u", - &sg_grant); - if (ret != 1) - sg_grant = 0; + sg_grant = xenbus_read_unsigned(dev->otherend, "feature-sg-grant", 0); nr_segs = min_t(unsigned int, sg_grant, SG_ALL); nr_segs = max_t(unsigned int, nr_segs, VSCSIIF_SG_TABLESIZE); nr_segs = min_t(unsigned int, nr_segs,