From patchwork Mon Oct 31 16:48:22 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Juergen Gross X-Patchwork-Id: 9406003 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 298EF60588 for ; Mon, 31 Oct 2016 16:50:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1AE8E2935A for ; Mon, 31 Oct 2016 16:50:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0F7CA2935C; Mon, 31 Oct 2016 16:50:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 863182935A for ; Mon, 31 Oct 2016 16:50:49 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c1FlT-0003md-6G; Mon, 31 Oct 2016 16:48:51 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c1FlR-0003lE-V1 for xen-devel@lists.xen.org; Mon, 31 Oct 2016 16:48:50 +0000 Received: from [85.158.139.211] by server-4.bemta-5.messagelabs.com id 72/1B-22514-1F577185; Mon, 31 Oct 2016 16:48:49 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrGLMWRWlGSWpSXmKPExsVyuP0Ov+6HUvE Ig7frdSyWfFzM4sDocXT3b6YAxijWzLyk/IoE1ozuW8+YC7ZxVbTN3snYwPiJo4uRk0NCwEji 7cR/TF2MXBxCAgsZJVb0XGcCSbAJqEpsuH6KFcQWEbCSeLj/GitIEbPAa0aJxSdOsoAkhAX8J N7M38kGYrMANfzcsQnM5hWwl1h5dBIbxAY5ieszp4MN5RRwkHi95hoziC0EVDNx2SHmCYzcCx gZVjGqF6cWlaUW6ZrpJRVlpmeU5CZm5ugaGpjq5aYWFyemp+YkJhXrJefnbmIE+pcBCHYwTm1 wPsQoycGkJMr7NUw8QogvKT+lMiOxOCO+qDQntfgQowwHh5IE75cSoJxgUWp6akVaZg4w0GDS Ehw8SiK8bMBgE+ItLkjMLc5Mh0idYlSUEudlBUkIgCQySvPg2mDBfYlRVkqYlxHoECGegtSi3 MwSVPlXjOIcjErCvKdBtvNk5pXATX8FtJgJaHFaoQjI4pJEhJRUA2PNWdONnQ37jL+X2q3WU0 6LVfiWwi4auKPkeckStZ65B7ve/mXomZNSd2SXueDZA1/VGF4HiYq94rd90L1tpu6qAg7drS/ YApZ5327knOrq8GW90iIG3Q8VVqtNf9lmp2yrX2AxqTj258a8TY5NM44q1j3YNH3ukZLkP9tv CK/+4q8jJiJSdF6JpTgj0VCLuag4EQAgss2kaQIAAA== X-Env-Sender: jgross@suse.com X-Msg-Ref: server-12.tower-206.messagelabs.com!1477932528!31443084!1 X-Originating-IP: [195.135.220.15] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.0.13; banners=-,-,- X-VirusChecked: Checked Received: (qmail 42443 invoked from network); 31 Oct 2016 16:48:48 -0000 Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by server-12.tower-206.messagelabs.com with DHE-RSA-CAMELLIA256-SHA encrypted SMTP; 31 Oct 2016 16:48:48 -0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 1BCC8ACF3; Mon, 31 Oct 2016 16:48:48 +0000 (UTC) From: Juergen Gross To: linux-kernel@vger.kernel.org, xen-devel@lists.xen.org Date: Mon, 31 Oct 2016 17:48:22 +0100 Message-Id: <1477932510-28594-5-git-send-email-jgross@suse.com> X-Mailer: git-send-email 2.6.6 In-Reply-To: <1477932510-28594-1-git-send-email-jgross@suse.com> References: <1477932510-28594-1-git-send-email-jgross@suse.com> Cc: Juergen Gross , tpmdd@selhorst.net, jarkko.sakkinen@linux.intel.com, jgunthorpe@obsidianresearch.com, tpmdd-devel@lists.sourceforge.net, david.vrabel@citrix.com, boris.ostrovsky@oracle.com, peterhuewe@gmx.de Subject: [Xen-devel] [PATCH 04/12] xen: make use of xenbus_read_unsigned() in xen-tpmfront X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Use xenbus_read_unsigned() instead of xenbus_scanf() when possible. This requires to change the type of one read from int to unsigned, but this case has been wrong before: negative values are not allowed for the modified case. Cc: peterhuewe@gmx.de Cc: tpmdd@selhorst.net Cc: jarkko.sakkinen@linux.intel.com Cc: jgunthorpe@obsidianresearch.com Cc: tpmdd-devel@lists.sourceforge.net Signed-off-by: Juergen Gross Reviewed-by: Jarkko Sakkinen Reviewed-by: Jarkko Sakkinen --- drivers/char/tpm/xen-tpmfront.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/char/tpm/xen-tpmfront.c b/drivers/char/tpm/xen-tpmfront.c index 62028f4..50072cc 100644 --- a/drivers/char/tpm/xen-tpmfront.c +++ b/drivers/char/tpm/xen-tpmfront.c @@ -337,18 +337,14 @@ static int tpmfront_resume(struct xenbus_device *dev) static void backend_changed(struct xenbus_device *dev, enum xenbus_state backend_state) { - int val; - switch (backend_state) { case XenbusStateInitialised: case XenbusStateConnected: if (dev->state == XenbusStateConnected) break; - if (xenbus_scanf(XBT_NIL, dev->otherend, - "feature-protocol-v2", "%d", &val) < 0) - val = 0; - if (!val) { + if (!xenbus_read_unsigned(dev->otherend, "feature-protocol-v2", + 0)) { xenbus_dev_fatal(dev, -EINVAL, "vTPM protocol 2 required"); return;