From patchwork Tue Nov 8 06:29:01 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Juergen Gross X-Patchwork-Id: 9416701 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 227EE6022E for ; Tue, 8 Nov 2016 06:31:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 14AEB28C40 for ; Tue, 8 Nov 2016 06:31:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 05C4128C39; Tue, 8 Nov 2016 06:31:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 89BF528C39 for ; Tue, 8 Nov 2016 06:31:00 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c3zu8-0005uu-Fv; Tue, 08 Nov 2016 06:29:08 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c3zu7-0005un-Qn for xen-devel@lists.xen.org; Tue, 08 Nov 2016 06:29:07 +0000 Received: from [85.158.139.211] by server-16.bemta-5.messagelabs.com id 3B/A7-01666-2B071285; Tue, 08 Nov 2016 06:29:06 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrDLMWRWlGSWpSXmKPExsVyuP0Ov+6mAsU Ig/Y2VoslHxezODB6HN39mymAMYo1My8pvyKBNeNRwyzWgg2cFXf/LWVuYOzi6GLk5JAQMJJ4 O/EfUxcjF4eQwEJGidmvbrKCJNgEVCU2XD8FZosISEtc+3yZEcRmFoiQeLl4JROILSxgL7H11 hmWLkYODhag+iXdyiAmr4CdxJlmRojxchLXZ05nmsDIuYCRYRWjRnFqUVlqka6hmV5SUWZ6Rk luYmaOrqGBqV5uanFxYnpqTmJSsV5yfu4mRqCvGIBgB+P5056HGCU5mJREeVM2KUQI8SXlp1R mJBZnxBeV5qQWH2KU4eBQkuB9ka8YISRYlJqeWpGWmQMMGpi0BAePkgjvX5A0b3FBYm5xZjpE 6hSjopQ47xKQhABIIqM0D64NFqiXGGWlhHkZgQ4R4ilILcrNLEGVf8UozsGoJMwrDAx7IZ7Mv BK46a+AFjMBLa6KUQBZXJKIkJJqYMxwjVlTGPLO85adX9XKuP/BPHXs89q71xltuFazj/sTY8 NhTztv/7m+j59p259aemtCitLcs5ePNLDOan4kJC2sdXNGpSrDUce0ypehNq8SWoS3tZrLXRB cxc6g/2hpKtC9JSKWere38kl67/XjusW+Tb6x7MYJs5g9Go9fad/X5M/XilunxFKckWioxVxU nAgAKm4ugE8CAAA= X-Env-Sender: jgross@suse.com X-Msg-Ref: server-14.tower-206.messagelabs.com!1478586545!30208798!1 X-Originating-IP: [195.135.220.15] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.0.13; banners=-,-,- X-VirusChecked: Checked Received: (qmail 22999 invoked from network); 8 Nov 2016 06:29:05 -0000 Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by server-14.tower-206.messagelabs.com with DHE-RSA-CAMELLIA256-SHA encrypted SMTP; 8 Nov 2016 06:29:05 -0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id ABD1EAAB7; Tue, 8 Nov 2016 06:29:04 +0000 (UTC) From: Juergen Gross To: xen-devel@lists.xen.org Date: Tue, 8 Nov 2016 07:29:01 +0100 Message-Id: <1478586541-8528-1-git-send-email-jgross@suse.com> X-Mailer: git-send-email 2.6.6 Cc: Juergen Gross , samuel.thibault@ens-lyon.org, wei.liu2@citrix.com Subject: [Xen-devel] [PATCH] stubdom: correct dependency for ioemu linkfarm X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP The dependency for setting up the links for ioemu is wrong: it is depending on tools/qemu-xen-traditional-dir which is being modified by each "make tools" call. This leads to rebuilds of several stubdom libraries for each call of "make stubdom" as those depend on the ioemu linkfarm stamp file. Modify the dependency to the qemu Makefile instead which is a better indicator whether we need to create the qemu directory before setting up the links. Signed-off-by: Juergen Gross --- stubdom/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/stubdom/Makefile b/stubdom/Makefile index 2921f30..0b33e23 100644 --- a/stubdom/Makefile +++ b/stubdom/Makefile @@ -281,10 +281,10 @@ IOEMU_LINKFARM_TARGET := ioemu/linkfarm.stamp endif ifeq ($(QEMU_ROOT),.) -$(XEN_ROOT)/tools/qemu-xen-traditional-dir: +$(XEN_ROOT)/tools/qemu-xen-traditional-dir/Makefile: $(MAKE) DESTDIR= -C $(XEN_ROOT)/tools qemu-xen-traditional-dir-find -ioemu/linkfarm.stamp: $(XEN_ROOT)/tools/qemu-xen-traditional-dir +ioemu/linkfarm.stamp: $(XEN_ROOT)/tools/qemu-xen-traditional-dir/Makefile mkdir -p ioemu set -e; \ $(buildmakevars2shellvars); \