| Message ID | 1478596181-25250-1-git-send-email-jgross@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Nov 08, 2016 at 10:09:41AM +0100, Juergen Gross wrote: > When building stubdoms EXTRA_CFLAGS_XEN_TOOLS and > EXTRA_CFLAGS_QEMU_TRADITIONAL should be cleared as they might contain > flags not suitable for all stubdom builds (e.g. "-m64" often to be > found in $RPM_OPT_FLAGS will break building 32 bit stubdoms). > > Signed-off-by: Juergen Gross <jgross@suse.com> > --- > stubdom/Makefile | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/stubdom/Makefile b/stubdom/Makefile > index 2921f30..c89e353 100644 > --- a/stubdom/Makefile > +++ b/stubdom/Makefile > @@ -4,6 +4,10 @@ MINI_OS = $(XEN_ROOT)/extras/mini-os > export XEN_ROOT > export XEN_OS=MiniOS > > +# Remove flags which are meant for tools, e.g. "-m64" > +export EXTRA_CFLAGS_XEN_TOOLS= > +export EXTRA_CFLAGS_QEMU_TRADITIONAL= > + I can't think of a better way to deal with this. This is in line with how it is done in firmware build, so Acked-by: Wei Liu <wei.liu2@citrix.com> > export stubdom=y > export debug=y > # Moved from config/StdGNU.mk > -- > 2.6.6 >
Wei Liu, on Tue 08 Nov 2016 10:47:18 +0000, wrote: > On Tue, Nov 08, 2016 at 10:09:41AM +0100, Juergen Gross wrote: > > When building stubdoms EXTRA_CFLAGS_XEN_TOOLS and > > EXTRA_CFLAGS_QEMU_TRADITIONAL should be cleared as they might contain > > flags not suitable for all stubdom builds (e.g. "-m64" often to be > > found in $RPM_OPT_FLAGS will break building 32 bit stubdoms). > > > > Signed-off-by: Juergen Gross <jgross@suse.com> > > --- > > stubdom/Makefile | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/stubdom/Makefile b/stubdom/Makefile > > index 2921f30..c89e353 100644 > > --- a/stubdom/Makefile > > +++ b/stubdom/Makefile > > @@ -4,6 +4,10 @@ MINI_OS = $(XEN_ROOT)/extras/mini-os > > export XEN_ROOT > > export XEN_OS=MiniOS > > > > +# Remove flags which are meant for tools, e.g. "-m64" > > +export EXTRA_CFLAGS_XEN_TOOLS= > > +export EXTRA_CFLAGS_QEMU_TRADITIONAL= > > + > > I can't think of a better way to deal with this. This is in line with > how it is done in firmware build, so > > Acked-by: Wei Liu <wei.liu2@citrix.com> Acked-by: Samuel Thibault <samuel.thibault@ens-lyon.org> > > export stubdom=y > > export debug=y > > # Moved from config/StdGNU.mk > > -- > > 2.6.6 > > >
diff --git a/stubdom/Makefile b/stubdom/Makefile index 2921f30..c89e353 100644 --- a/stubdom/Makefile +++ b/stubdom/Makefile @@ -4,6 +4,10 @@ MINI_OS = $(XEN_ROOT)/extras/mini-os export XEN_ROOT export XEN_OS=MiniOS +# Remove flags which are meant for tools, e.g. "-m64" +export EXTRA_CFLAGS_XEN_TOOLS= +export EXTRA_CFLAGS_QEMU_TRADITIONAL= + export stubdom=y export debug=y # Moved from config/StdGNU.mk
When building stubdoms EXTRA_CFLAGS_XEN_TOOLS and EXTRA_CFLAGS_QEMU_TRADITIONAL should be cleared as they might contain flags not suitable for all stubdom builds (e.g. "-m64" often to be found in $RPM_OPT_FLAGS will break building 32 bit stubdoms). Signed-off-by: Juergen Gross <jgross@suse.com> --- stubdom/Makefile | 4 ++++ 1 file changed, 4 insertions(+)