From patchwork Wed Nov 16 17:59:43 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Cooper X-Patchwork-Id: 9432305 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 28C7C60471 for ; Wed, 16 Nov 2016 18:02:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1D7FF28B68 for ; Wed, 16 Nov 2016 18:02:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 11A7528F3E; Wed, 16 Nov 2016 18:02:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id ABB6428B68 for ; Wed, 16 Nov 2016 18:02:23 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c74Uw-0004Jo-8N; Wed, 16 Nov 2016 17:59:50 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c74Uu-0004Ji-Ar for xen-devel@lists.xen.org; Wed, 16 Nov 2016 17:59:48 +0000 Received: from [85.158.143.35] by server-3.bemta-6.messagelabs.com id E5/B3-25793-39E9C285; Wed, 16 Nov 2016 17:59:47 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuphkeJIrShJLcpLzFFi42JxWrrBXnfyPJ0 IgzObeSyWfFzM4sDocXT3b6YAxijWzLyk/IoE1ox9vWcYC7bIVDR/bWZpYHwp3sXIwSEh4C+x ZYlxFyMnB5uAvsTuF5+YQGwRAXWJ0x0XWUFKmAV0JVb91AAJCwsESrx/cocNxGYRUJX4sessG 0gJr4CnRMN5A5CwhICcxPnjP5lBbE4BL4mpn/4ygthCQCUtS7awQthqEtf6L7GD2LwCghInZz 5hAbGZBSQkDr54wQxxGLfE3277CYx8s5BUzUJStYCRaRWjenFqUVlqka6pXlJRZnpGSW5iZo6 uoYGZXm5qcXFiempOYlKxXnJ+7iZGYCgxAMEOxumX/Q8xSnIwKYnypk3RiRDiS8pPqcxILM6I LyrNSS0+xCjDwaEkwes8FygnWJSanlqRlpkDDGqYtAQHj5IIbzJImre4IDG3ODMdInWKUVFKn NcNJCEAksgozYNrg0XSJUZZKWFeRqBDhHgKUotyM0tQ5V8xinMwKgnz5oBM4cnMK4Gb/gpoMR PQ4j0CYItLEhFSUg2MkZtK5LZZ/jP8E9tTsXKS3kkZUY4PJYVH5Pd0Chr9qPLwWf+g7kL+Ua1 S5z//n3Mw6b5a5V66pvmtYzhnWuKetJOnm1/5WShcqjGuf7Lhv942Rhm/ayw1+tvvzxZd7SZa fNBdLiZsqdx6VhX5xZVlZ1Yy1fNelg1nXDujfSP7/HWV6qL+9xuUWIozEg21mIuKEwEhDL78n wIAAA== X-Env-Sender: prvs=12105882d=Andrew.Cooper3@citrix.com X-Msg-Ref: server-6.tower-21.messagelabs.com!1479319185!20610866!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 9.0.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 5184 invoked from network); 16 Nov 2016 17:59:46 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-6.tower-21.messagelabs.com with RC4-SHA encrypted SMTP; 16 Nov 2016 17:59:46 -0000 X-IronPort-AV: E=Sophos;i="5.31,649,1473120000"; d="scan'208";a="398588295" From: Andrew Cooper To: Xen-devel Date: Wed, 16 Nov 2016 17:59:43 +0000 Message-ID: <1479319183-24491-1-git-send-email-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1477921692-25477-1-git-send-email-andrew.cooper3@citrix.com> References: <1477921692-25477-1-git-send-email-andrew.cooper3@citrix.com> MIME-Version: 1.0 X-DLP: MIA1 Cc: Andrew Cooper Subject: [Xen-devel] [PATCH v2] x86/svm: Improve segment register printing in svm_vmcb_dump() X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP v2 patch FYI. I have queued this in my for-4.9 branch, for merging when we branch. ~Andrew ---%<--- This makes it more succinct and easier to read. Before: (XEN) H_CR3 = 0x000000042a0ec000 CleanBits = 0 (XEN) CS: sel=0x0008, attr=0x029b, limit=0xffffffff, base=0x0000000000000000 (XEN) DS: sel=0x0033, attr=0x0cf3, limit=0xffffffff, base=0x0000000000000000 (XEN) SS: sel=0x0018, attr=0x0c93, limit=0xffffffff, base=0x0000000000000000 (XEN) ES: sel=0x0033, attr=0x0cf3, limit=0xffffffff, base=0x0000000000000000 (XEN) FS: sel=0x0033, attr=0x0cf3, limit=0xffffffff, base=0x0000000000000000 (XEN) GS: sel=0x0033, attr=0x0cf3, limit=0xffffffff, base=0x0000000000000000 (XEN) GDTR: sel=0x0000, attr=0x0000, limit=0x00000067, base=0x000000000010d100 (XEN) LDTR: sel=0x0000, attr=0x0000, limit=0x00000000, base=0x0000000000000000 (XEN) IDTR: sel=0x0000, attr=0x0000, limit=0x00000fff, base=0x0000000000110900 (XEN) TR: sel=0x0038, attr=0x0089, limit=0x00000067, base=0x000000000010d020 After: (XEN) H_CR3 = 0x000000042a0ec000 CleanBits = 0 (XEN) sel attr limit base (XEN) CS: 0008 029b ffffffff 0000000000000000 (XEN) DS: 0033 0cf3 ffffffff 0000000000000000 (XEN) SS: 0018 0c93 ffffffff 0000000000000000 (XEN) ES: 0033 0cf3 ffffffff 0000000000000000 (XEN) FS: 0033 0cf3 ffffffff 0000000000000000 (XEN) GS: 0033 0cf3 ffffffff 0000000000000000 (XEN) GDTR: 0000 0000 00000067 000000000010d100 (XEN) LDTR: 0000 0000 00000000 0000000000000000 (XEN) IDTR: 0000 0000 00000fff 0000000000110900 (XEN) TR: 0038 0089 00000067 000000000010d020 Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich Reviewed-by: Boris Ostrovsky Reviewed-by: Suravee Suthikulpanit --- xen/arch/x86/hvm/svm/svmdebug.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/xen/arch/x86/hvm/svm/svmdebug.c b/xen/arch/x86/hvm/svm/svmdebug.c index ded5d19..49972c6 100644 --- a/xen/arch/x86/hvm/svm/svmdebug.c +++ b/xen/arch/x86/hvm/svm/svmdebug.c @@ -20,11 +20,10 @@ #include #include -static void svm_dump_sel(const char *name, svm_segment_register_t *s) +static void svm_dump_sel(const char *name, const svm_segment_register_t *s) { - printk("%s: sel=0x%04x, attr=0x%04x, limit=0x%08x, base=0x%016llx\n", - name, s->sel, s->attr.bytes, s->limit, - (unsigned long long)s->base); + printk("%s: %04x %04x %08x %016"PRIx64"\n", + name, s->sel, s->attr.bytes, s->limit, s->base); } /* This function can directly access fields which are covered by clean bits. */ @@ -79,16 +78,17 @@ void svm_vmcb_dump(const char *from, struct vmcb_struct *vmcb) (unsigned long long)vmcb->_h_cr3, vmcb->cleanbits.bytes); /* print out all the selectors */ - svm_dump_sel("CS", &vmcb->cs); - svm_dump_sel("DS", &vmcb->ds); - svm_dump_sel("SS", &vmcb->ss); - svm_dump_sel("ES", &vmcb->es); - svm_dump_sel("FS", &vmcb->fs); - svm_dump_sel("GS", &vmcb->gs); + printk(" sel attr limit base\n"); + svm_dump_sel(" CS", &vmcb->cs); + svm_dump_sel(" DS", &vmcb->ds); + svm_dump_sel(" SS", &vmcb->ss); + svm_dump_sel(" ES", &vmcb->es); + svm_dump_sel(" FS", &vmcb->fs); + svm_dump_sel(" GS", &vmcb->gs); svm_dump_sel("GDTR", &vmcb->gdtr); svm_dump_sel("LDTR", &vmcb->ldtr); svm_dump_sel("IDTR", &vmcb->idtr); - svm_dump_sel("TR", &vmcb->tr); + svm_dump_sel(" TR", &vmcb->tr); } bool_t