From patchwork Fri Nov 18 01:57:23 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Wu, Feng" X-Patchwork-Id: 9435663 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3CEF160755 for ; Fri, 18 Nov 2016 02:32:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 31A702972B for ; Fri, 18 Nov 2016 02:32:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2676129733; Fri, 18 Nov 2016 02:32:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D282729737 for ; Fri, 18 Nov 2016 02:32:46 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c7Ywg-00046M-Dw; Fri, 18 Nov 2016 02:30:30 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c7Ywe-00044u-Oq for xen-devel@lists.xen.org; Fri, 18 Nov 2016 02:30:28 +0000 Received: from [193.109.254.147] by server-9.bemta-6.messagelabs.com id FA/81-28694-4C76E285; Fri, 18 Nov 2016 02:30:28 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrPLMWRWlGSWpSXmKPExsVywNykWPdIul6 EwcXbrBZLPi5mcWD0OLr7N1MAYxRrZl5SfkUCa8b9/y0sBQ+FK479/c3UwPibv4uRk0NIoFJi 1YNmZhBbQoBX4siyGawQdoBE478ZbF2MXEA1fYwSF04vZgJJsAkoShy8eAisSERAWuLa58uMI EXMAgsYJRovHgWbJCygLXHo9WWwBhYBVYkne84wgti8Ao4Sc7eugNomJ7Fh93+wOKeAk8Tx1b dZIC5ylNg/9QPLBEbeBYwMqxg1ilOLylKLdA2N9JKKMtMzSnITM3N0DQ3M9HJTi4sT01NzEpO K9ZLzczcxAgOCAQh2MF7eGHCIUZKDSUmUtz1aL0KILyk/pTIjsTgjvqg0J7X4EKMMB4eSBO+n NKCcYFFqempFWmYOMDRh0hIcPEoivDdSgdK8xQWJucWZ6RCpU4yKUuK8PSB9AiCJjNI8uDZYP FxilJUS5mUEOkSIpyC1KDezBFX+FaM4B6OSMO8WkCk8mXklcNNfAS1mAlq8R0AHZHFJIkJKqo GRc4McmxKDgLp62YTWg4sNNj86s97YRfy1XPKsC7P3l9jHVz/WVz/Z6uC9N501ecFN/t7q/S5 FER/jw1+1e9Zws+Uu+xG59taJ2ZsX6C2cmR6w5FnN0hVzl7A1q+otWiDqvP3OQ+WsWkemHSwb Z09V6WcNi3cvtDOdGhZaaJ2gt67K5r/53molluKMREMt5qLiRACSZsYLggIAAA== X-Env-Sender: feng.wu@intel.com X-Msg-Ref: server-14.tower-27.messagelabs.com!1479436221!60052313!5 X-Originating-IP: [192.55.52.115] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.0.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 58980 invoked from network); 18 Nov 2016 02:30:27 -0000 Received: from mga14.intel.com (HELO mga14.intel.com) (192.55.52.115) by server-14.tower-27.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 18 Nov 2016 02:30:27 -0000 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP; 17 Nov 2016 18:30:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos; i="5.31,655,1473145200"; d="scan'208"; a="1070084877" Received: from unknown (HELO feng-bdw-de-pi.bj.intel.com) ([10.238.154.55]) by fmsmga001.fm.intel.com with ESMTP; 17 Nov 2016 18:30:25 -0800 From: Feng Wu To: xen-devel@lists.xen.org Date: Fri, 18 Nov 2016 09:57:23 +0800 Message-Id: <1479434244-10223-7-git-send-email-feng.wu@intel.com> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1479434244-10223-1-git-send-email-feng.wu@intel.com> References: <1479434244-10223-1-git-send-email-feng.wu@intel.com> Cc: kevin.tian@intel.com, Feng Wu , george.dunlap@eu.citrix.com, andrew.cooper3@citrix.com, dario.faggioli@citrix.com, jbeulich@suse.com Subject: [Xen-devel] [PATCH v8 6/7] VT-d: Some cleanups X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Use type-safe structure assignment instead of memcpy() Use sizeof(*iremap_entry). Signed-off-by: Feng Wu Reviewed-by: Konrad Rzeszutek Wilk Acked-by: Kevin Tian --- v7: - Remove a useless cleanup v6: - More descripion about the patch xen/drivers/passthrough/vtd/intremap.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/xen/drivers/passthrough/vtd/intremap.c b/xen/drivers/passthrough/vtd/intremap.c index 0cb8c37..8664194 100644 --- a/xen/drivers/passthrough/vtd/intremap.c +++ b/xen/drivers/passthrough/vtd/intremap.c @@ -183,8 +183,8 @@ static void free_remap_entry(struct iommu *iommu, int index) GET_IREMAP_ENTRY(ir_ctrl->iremap_maddr, index, iremap_entries, iremap_entry); - memset(iremap_entry, 0, sizeof(struct iremap_entry)); - iommu_flush_cache_entry(iremap_entry, sizeof(struct iremap_entry)); + memset(iremap_entry, 0, sizeof(*iremap_entry)); + iommu_flush_cache_entry(iremap_entry, sizeof(*iremap_entry)); iommu_flush_iec_index(iommu, 0, index); unmap_vtd_domain_page(iremap_entries); @@ -310,7 +310,7 @@ static int ioapic_rte_to_remap_entry(struct iommu *iommu, GET_IREMAP_ENTRY(ir_ctrl->iremap_maddr, index, iremap_entries, iremap_entry); - memcpy(&new_ire, iremap_entry, sizeof(struct iremap_entry)); + new_ire = *iremap_entry; if ( rte_upper ) { @@ -353,8 +353,8 @@ static int ioapic_rte_to_remap_entry(struct iommu *iommu, remap_rte->format = 1; /* indicate remap format */ } - memcpy(iremap_entry, &new_ire, sizeof(struct iremap_entry)); - iommu_flush_cache_entry(iremap_entry, sizeof(struct iremap_entry)); + *iremap_entry = new_ire; + iommu_flush_cache_entry(iremap_entry, sizeof(*iremap_entry)); iommu_flush_iec_index(iommu, 0, index); unmap_vtd_domain_page(iremap_entries); @@ -674,7 +674,7 @@ static int msi_msg_to_remap_entry( if ( iremap_entry->val != new_ire.val ) { if ( !pi_desc ) - memcpy(iremap_entry, &new_ire, sizeof(struct iremap_entry)); + *iremap_entry = new_ire; else { __uint128_t ret; @@ -690,7 +690,7 @@ static int msi_msg_to_remap_entry( ASSERT(ret == old_ire.val); } - iommu_flush_cache_entry(iremap_entry, sizeof(struct iremap_entry)); + iommu_flush_cache_entry(iremap_entry, sizeof(*iremap_entry)); iommu_flush_iec_index(iommu, 0, index); }