diff mbox

[1/2] Kconfig: introduce allrandom.config

Message ID 1480956336-3139-2-git-send-email-wei.liu2@citrix.com (mailing list archive)
State New, archived
Headers show

Commit Message

Wei Liu Dec. 5, 2016, 4:45 p.m. UTC 
This would be used to force selection of certain items in randconfig.

We need this to force gcov format to be autodetected in randconfig
target, which would avoid generating known-incompatible combinations.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
Cc: Doug Goldstein <cardoe@cardoe.com>
---
 xen/tools/kconfig/allrandom.config | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 xen/tools/kconfig/allrandom.config

Comments

Andrew Cooper Dec. 5, 2016, 5:01 p.m. UTC | #1 
On 05/12/16 16:45, Wei Liu wrote:
> This would be used to force selection of certain items in randconfig.
>
> We need this to force gcov format to be autodetected in randconfig
> target, which would avoid generating known-incompatible combinations.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
> Cc: Doug Goldstein <cardoe@cardoe.com>
> ---
>  xen/tools/kconfig/allrandom.config | 1 +
>  1 file changed, 1 insertion(+)
>  create mode 100644 xen/tools/kconfig/allrandom.config
>
> diff --git a/xen/tools/kconfig/allrandom.config b/xen/tools/kconfig/allrandom.config
> new file mode 100644
> index 0000000..e49e7d6
> --- /dev/null
> +++ b/xen/tools/kconfig/allrandom.config
> @@ -0,0 +1 @@

I'd put a comment here saying

# Explicit option choices not subject to regular RANDCONFIG

Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

> +CONFIG_GCOV_FORMAT_AUTODETECT=y
Douglas Goldstein Dec. 5, 2016, 6:08 p.m. UTC | #2 
On 12/5/16 10:45 AM, Wei Liu wrote:
> This would be used to force selection of certain items in randconfig.
> 
> We need this to force gcov format to be autodetected in randconfig
> target, which would avoid generating known-incompatible combinations.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
> Cc: Doug Goldstein <cardoe@cardoe.com>
> ---
>  xen/tools/kconfig/allrandom.config | 1 +
>  1 file changed, 1 insertion(+)
>  create mode 100644 xen/tools/kconfig/allrandom.config
> 
> diff --git a/xen/tools/kconfig/allrandom.config b/xen/tools/kconfig/allrandom.config
> new file mode 100644
> index 0000000..e49e7d6
> --- /dev/null
> +++ b/xen/tools/kconfig/allrandom.config
> @@ -0,0 +1 @@
> +CONFIG_GCOV_FORMAT_AUTODETECT=y
> 

Thank you for doing this Wei. I do agree with Andrew about the explicit
comment.

Reviewed-by: Doug Goldstein <cardoe@cardoe.com>
diff mbox

Patch

diff --git a/xen/tools/kconfig/allrandom.config b/xen/tools/kconfig/allrandom.config
new file mode 100644
index 0000000..e49e7d6
--- /dev/null
+++ b/xen/tools/kconfig/allrandom.config
@@ -0,0 +1 @@ 
+CONFIG_GCOV_FORMAT_AUTODETECT=y