From patchwork Tue Dec 20 18:37:57 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Jackson X-Patchwork-Id: 9482037 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1568860237 for ; Tue, 20 Dec 2016 18:49:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0A4A327FAD for ; Tue, 20 Dec 2016 18:49:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EF48F280FC; Tue, 20 Dec 2016 18:49:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 99F5627FAD for ; Tue, 20 Dec 2016 18:49:46 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cJPRx-0002xp-02; Tue, 20 Dec 2016 18:47:44 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cJPRv-0002xB-An for xen-devel@lists.xenproject.org; Tue, 20 Dec 2016 18:47:43 +0000 Received: from [85.158.143.35] by server-4.bemta-6.messagelabs.com id 01/1B-25093-ECC79585; Tue, 20 Dec 2016 18:47:42 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupmkeJIrShJLcpLzFFi42JxWrohUvdcTWS EwbL5Qhbft0xmcmD0OPzhCksAYxRrZl5SfkUCa8bFGbwF29gqmh8INzDOZ+1i5OSQEPCX6Hp6 kBHEZhPQlWja8peti5GDQ0RAReL2XgMQk1kgVGLHC0uQCmGBQIm3S6axgNgsAqoSjf+ugtm8A p4SN09cZYSYKCdx/vhPZhCbU8BL4n3HP7C4EFDN7wsdzCAjhQTUJOauj4doFZQ4OfMJ2BhmAQ mJgy9eME9g5J2FJDULSWoBI9MqRvXi1KKy1CJdM72kosz0jJLcxMwcXUMDM73c1OLixPTUnMS kYr3k/NxNjMCAYQCCHYzzTvgfYpTkYFIS5V1VERkhxJeUn1KZkVicEV9UmpNafIhRhoNDSYJX qRooJ1iUmp5akZaZAwxdmLQEB4+SCG8YSJq3uCAxtzgzHSJ1ilGX48D7FU+ZhFjy8vNSpcR5b 4AUCYAUZZTmwY2AxdElRlkpYV5GoKOEeApSi3IzS1DlXzGKczAqCfNeA5nCk5lXArfpFdARTE BHLOwOBzmiJBEhJdXAuIjRtP7b/8KJnJFC5pPq/v2JP7km9d3mR8u88iP7glz/+677mylbfWJ DJu/svisnFqjkXt5iaT7pfE8095wi57sWuR0bbFV37LgRzrmRf9X2aRNfXvXu0JpXL3cn2XHH g2Maq2L3h01z3GCcsfLdH+YlMZN3BVk+Vdng++tS6rH/L+7dOvb4TIcSS3FGoqEWc1FxIgAsR CzhngIAAA== X-Env-Sender: prvs=155c47fa8=Ian.Jackson@citrix.com X-Msg-Ref: server-6.tower-21.messagelabs.com!1482259658!26212121!3 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 9.1.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 5470 invoked from network); 20 Dec 2016 18:47:41 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-6.tower-21.messagelabs.com with RC4-SHA encrypted SMTP; 20 Dec 2016 18:47:41 -0000 X-IronPort-AV: E=Sophos;i="5.33,380,1477958400"; d="scan'208";a="395803656" From: Ian Jackson To: Date: Tue, 20 Dec 2016 18:37:57 +0000 Message-ID: <1482259082-30767-5-git-send-email-ian.jackson@eu.citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1482259082-30767-1-git-send-email-ian.jackson@eu.citrix.com> References: <1482259082-30767-1-git-send-email-ian.jackson@eu.citrix.com> MIME-Version: 1.0 Cc: Ian Jackson Subject: [Xen-devel] [OSSTEST PATCH 4/9] db retry, bisection: Reset %jobs_created on db retry X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP %jobs_created is used for memoisation while populating the destination flight. We need to reset it when we restart flight construction, because those jobs were created in the discarded transaction. Otherwise we could create a flight with missing jobs. Signed-off-by: Ian Jackson --- cs-bisection-step | 1 + 1 file changed, 1 insertion(+) diff --git a/cs-bisection-step b/cs-bisection-step index 4c71587..1d1962a 100755 --- a/cs-bisection-step +++ b/cs-bisection-step @@ -1286,6 +1286,7 @@ END db_retry($popflight,'constructing', $dbh_tests,[qw(flights)], sub { print STDERR "Populating $popflight...\n"; + undef %jobs_created; preparejob($job, $latest_flight, 0); foreach my $hostspec (split /,/, $hosts) { # / $hostspec =~ m/=/;