diff mbox

[OSSTEST,6/9] db retry: Document $@ as an implicit parameter to need_retry

Message ID 1482259082-30767-7-git-send-email-ian.jackson@eu.citrix.com (mailing list archive)
State New, archived
Headers show

Commit Message

Ian Jackson Dec. 20, 2016, 6:37 p.m. UTC 
There are only two call sites and neither trashes $@ right now.
We are going to use a more exception-friendly style.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
 Osstest/JobDB/Executive.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox

Patch

diff --git a/Osstest/JobDB/Executive.pm b/Osstest/JobDB/Executive.pm
index 7eeaf52..ebafb4c 100644
--- a/Osstest/JobDB/Executive.pm
+++ b/Osstest/JobDB/Executive.pm
@@ -59,7 +59,7 @@  sub begin_work ($$$) { #method
 }
 
 sub need_retry ($$$) {
-    my ($jd, $dbh,$committing) = @_;
+    my ($jd, $dbh,$committing) = @_; # implicitly, $@ is an argument too
     return
 	($dbh_tests->err() // 0)==7 &&
 	($dbh_tests->state =~ m/^(?:40P01|40001|23|40002)/);