From patchwork Fri Dec 23 12:24:18 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Liu X-Patchwork-Id: 9487411 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D7BAD601C0 for ; Fri, 23 Dec 2016 12:26:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C9F4626247 for ; Fri, 23 Dec 2016 12:26:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BED4726E82; Fri, 23 Dec 2016 12:26:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 78CCE26247 for ; Fri, 23 Dec 2016 12:26:52 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cKOte-0003DR-0s; Fri, 23 Dec 2016 12:24:26 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cKOtc-0003CH-Fc for xen-devel@lists.xenproject.org; Fri, 23 Dec 2016 12:24:24 +0000 Received: from [193.109.254.147] by server-2.bemta-6.messagelabs.com id DB/83-22326-7771D585; Fri, 23 Dec 2016 12:24:23 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmplkeJIrShJLcpLzFFi42JxWrohUrdcPDb C4OwCUYvvWyYzOTB6HP5whSWAMYo1My8pvyKBNWPO7b2MBTu5KrpuPmVsYGzg7GLk5JAQ8Je4 uPoCE4jNJqAs8bOzlw3EFhHQk2g68Jyxi5GLg1lgH5PE4dcbWLoYOTiEBawlGu5ogNSwCKhKn Pj0gxXE5hVwklj9ehsLxEw5ifPHfzKD2JwCzhI9U66yg9hCIDUL+lggbAWJjunHmCB6BSVOzn wCFmcWkJA4+OIF8wRG3llIUrOQpBYwMq1i1ChOLSpLLdI1MtZLKspMzyjJTczM0TU0MNPLTS0 uTkxPzUlMKtZLzs/dxAgMHgYg2MH4Z37gIUZJDiYlUV61zTERQnxJ+SmVGYnFGfFFpTmpxYcY ZTg4lCR4DcRiI4QEi1LTUyvSMnOAYQyTluDgURLhrQVJ8xYXJOYWZ6ZDpE4xKkqJ804FSQiAJ DJK8+DaYLFziVFWSpiXEegQIZ6C1KLczBJU+VeM4hyMSsK8/0SBpvBk5pXATX8FtJgJaLFtcz TI4pJEhJRUAyO37ok3ZyYY78t64Hn7/e0p0eU+Myqn/uiqua7w1KsylLeQ7fm2C6vzDvxzcjm kVMfwfvKBfw+jFfQKj5aIubLLJTZ7ptZ9n7TsqOqv1om8Of9Tuxv//FXkXHp7+sxL05Zt4e2u qlNRPxide1Lu96yGc0eVfs//fOncgrds+xjvmkndvL47bZ+CEktxRqKhFnNRcSIAobWafZgCA AA= X-Env-Sender: prvs=158aab1cd=wei.liu2@citrix.com X-Msg-Ref: server-4.tower-27.messagelabs.com!1482495860!78096444!3 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 9.1.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 42504 invoked from network); 23 Dec 2016 12:24:23 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-4.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 23 Dec 2016 12:24:23 -0000 X-IronPort-AV: E=Sophos;i="5.33,393,1477958400"; d="scan'208";a="396346487" From: Wei Liu To: Xen-devel Date: Fri, 23 Dec 2016 12:24:18 +0000 Message-ID: <1482495858-4334-4-git-send-email-wei.liu2@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1482495858-4334-1-git-send-email-wei.liu2@citrix.com> References: <1482495858-4334-1-git-send-email-wei.liu2@citrix.com> MIME-Version: 1.0 Cc: Stefano Stabellini , Wei Liu , George Dunlap , Andrew Cooper , Ian Jackson , Tim Deegan , Jan Beulich Subject: [Xen-devel] [PATCH v2 2/2] build: use debug_symbols to add -g3 X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP While doing archeology I found 38ce7ce3, we should also make sure debug_symbols is the responsible for adding "-g" to CFLAGS. Move adding "-g3" from being guarded by debug to being guarded by debug_symbols. Signed-off-by: Wei Liu Acked-by: Ian Jackson --- Cc: Andrew Cooper Cc: George Dunlap Cc: Ian Jackson Cc: Jan Beulich Cc: Konrad Rzeszutek Wilk Cc: Stefano Stabellini Cc: Tim Deegan Cc: Wei Liu --- tools/Rules.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/Rules.mk b/tools/Rules.mk index 9a87f18..c8386b1 100644 --- a/tools/Rules.mk +++ b/tools/Rules.mk @@ -31,7 +31,7 @@ debug ?= y debug_symbols ?= $(debug) ifeq ($(debug_symbols),y) -CFLAGS += -g +CFLAGS += -g3 endif ifneq ($(nosharedlibs),y) @@ -146,7 +146,7 @@ SHLIB_libxenvchan = $(SHDEPS_libxenvchan) -Wl,-rpath-link=$(XEN_LIBVCHAN) ifeq ($(debug),y) # Disable optimizations and enable debugging information for macros -CFLAGS += -O0 -g3 -fno-omit-frame-pointer +CFLAGS += -O0 -fno-omit-frame-pointer # But allow an override to -O0 in case Python enforces -D_FORTIFY_SOURCE=. PY_CFLAGS += $(PY_NOOPT_CFLAGS) else