| Message ID | 1483452256-2879-3-git-send-email-boris.ostrovsky@oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
>>> On 03.01.17 at 15:04, <boris.ostrovsky@oracle.com> wrote: > Noone else needs to include it since it is only useful to code > that can made domctl calls. And public domctl.h can only be included > by the toolstack or the hypervisor. > > Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com> > --- > New in v6 (not required by the series). > > Q: Should include/public/hvm/save.h have the same guards? Yes. In fact the architecture specific header should never be included directly, so putting the guard just there (and ... > --- a/xen/include/public/arch-x86/hvm/save.h > +++ b/xen/include/public/arch-x86/hvm/save.h > @@ -26,6 +26,8 @@ > #ifndef __XEN_PUBLIC_HVM_SAVE_X86_H__ > #define __XEN_PUBLIC_HVM_SAVE_X86_H__ > > +#if defined(__XEN__) || defined(__XEN_TOOLS__) ... an #error here and in the ARM counterpart) would seem best. Jan
diff --git a/xen/include/public/arch-x86/hvm/save.h b/xen/include/public/arch-x86/hvm/save.h index 8d73b51..ee0a3f7 100644 --- a/xen/include/public/arch-x86/hvm/save.h +++ b/xen/include/public/arch-x86/hvm/save.h @@ -26,6 +26,8 @@ #ifndef __XEN_PUBLIC_HVM_SAVE_X86_H__ #define __XEN_PUBLIC_HVM_SAVE_X86_H__ +#if defined(__XEN__) || defined(__XEN_TOOLS__) + /* * Save/restore header: general info about the save file. */ @@ -632,6 +634,8 @@ struct hvm_msr { */ #define HVM_SAVE_CODE_MAX 20 +#endif /* __XEN__ || __XEN_TOOLS__ */ + #endif /* __XEN_PUBLIC_HVM_SAVE_X86_H__ */ /*
Noone else needs to include it since it is only useful to code that can made domctl calls. And public domctl.h can only be included by the toolstack or the hypervisor. Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com> --- New in v6 (not required by the series). Q: Should include/public/hvm/save.h have the same guards? xen/include/public/arch-x86/hvm/save.h | 4 ++++ 1 file changed, 4 insertions(+)