From patchwork Thu Feb 9 14:17:44 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Durrant X-Patchwork-Id: 9564661 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C4FD360236 for ; Thu, 9 Feb 2017 14:19:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AE95D284FA for ; Thu, 9 Feb 2017 14:19:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A08512850D; Thu, 9 Feb 2017 14:19:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 3D042284B4 for ; Thu, 9 Feb 2017 14:19:58 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cbpXl-0006h7-7Y; Thu, 09 Feb 2017 14:17:53 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cbpXk-0006gj-CD for xen-devel@lists.xenproject.org; Thu, 09 Feb 2017 14:17:52 +0000 Received: from [85.158.137.68] by server-7.bemta-3.messagelabs.com id AD/EB-23854-F0A7C985; Thu, 09 Feb 2017 14:17:51 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprKIsWRWlGSWpSXmKPExsXitHRDpC5/1Zw Ig1krOS2+b5nM5MDocfjDFZYAxijWzLyk/IoE1oyeBwtYCzayVsxYM4GxgfEISxcjB4eEgL/E 5/uxXYycHGwCOhJTn15iBbFFBFwk+redYQOxmQWqJE5Pm8wIUi4s4CkxY2o8SJhFQEXi3s49L CA2r4CbxKzjvWCtEgJyEueP/2QGsTkF3CW+P7gFFhcCqtn19QQ7hK0isX7qLDaIXkGJkzOfsE CskpA4+OIF8wRG3llIUrOQpBYwMq1i1ChOLSpLLdI1MtRLKspMzyjJTczM0TU0MNbLTS0uTkx PzUlMKtZLzs/dxAgMnHoGBsYdjD17/Q4xSnIwKYnyyhbMiRDiS8pPqcxILM6ILyrNSS0+xCjD waEkwXu0AignWJSanlqRlpkDDGGYtAQHj5IIbwxImre4IDG3ODMdInWK0Zjj1I3TL5k4Tn268 JJJiCUvPy9VSpxXrxKoVACkNKM0D24QLLYuMcpKCfMyMjAwCPEUpBblZpagyr9iFOdgVBLmfQ GykCczrwRu3yugU5iATrl+ehbIKSWJCCmpBsYM/kfTHk/pVbR8X3tm2oHrl8PdtYp/3lFlFb2 2xkiCL23+sUeHVnIE5X+7zbh9ptUdObc7hv6mSrd5pGInnSyOSLA7VSuSfeX8zle9yRcSd8yL uy+0amvi7QuzVXmrhTY8r53cMGs3D9ub+d3LL8TsKdIKFlNc26Q8Te/BhpVHnDbVbctgq7FWY inOSDTUYi4qTgQA9WDhI6gCAAA= X-Env-Sender: prvs=206c1e2c2=Paul.Durrant@citrix.com X-Msg-Ref: server-7.tower-31.messagelabs.com!1486649869!77230321!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 9.1.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 15405 invoked from network); 9 Feb 2017 14:17:50 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-7.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 9 Feb 2017 14:17:50 -0000 X-IronPort-AV: E=Sophos;i="5.35,349,1484006400"; d="scan'208";a="405748659" From: Paul Durrant To: , Date: Thu, 9 Feb 2017 14:17:44 +0000 Message-ID: <1486649866-4869-2-git-send-email-paul.durrant@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1486649866-4869-1-git-send-email-paul.durrant@citrix.com> References: <1486649866-4869-1-git-send-email-paul.durrant@citrix.com> MIME-Version: 1.0 Cc: Juergen Gross , Boris Ostrovsky , Paul Durrant Subject: [Xen-devel] [PATCH 1/3] xen/privcmd: return -ENOSYS for unimplemented IOCTLs X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP The code goes so far as to set the default return code to -ENOSYS but then overrides this to -EINVAL in the switch() statement's default case. This patch removes this pointless and incorrect override. Signed-off-by: Paul Durrant --- Cc: Boris Ostrovsky Cc: Juergen Gross --- drivers/xen/privcmd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c index 6e3306f..b4e5e27 100644 --- a/drivers/xen/privcmd.c +++ b/drivers/xen/privcmd.c @@ -572,7 +572,6 @@ static long privcmd_ioctl(struct file *file, break; default: - ret = -EINVAL; break; }