From patchwork Fri Feb 10 14:24:35 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Durrant X-Patchwork-Id: 9566857 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 02E6F60216 for ; Fri, 10 Feb 2017 14:27:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E3B98281F9 for ; Fri, 10 Feb 2017 14:27:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D82172855E; Fri, 10 Feb 2017 14:27:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 98DFC281F9 for ; Fri, 10 Feb 2017 14:27:18 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ccC7v-0003JK-12; Fri, 10 Feb 2017 14:24:43 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ccC7t-0003Im-HR for xen-devel@lists.xenproject.org; Fri, 10 Feb 2017 14:24:41 +0000 Received: from [85.158.139.211] by server-10.bemta-5.messagelabs.com id E2/FA-01703-82DCD985; Fri, 10 Feb 2017 14:24:40 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprIIsWRWlGSWpSXmKPExsXitHRDpK7G2bk RBuuaRS2+b5nM5MDocfjDFZYAxijWzLyk/IoE1ozPUy+zFDzmqJj+5xBzA+NS9i5GTg4JAX+J 08/+sYHYbAI6ElOfXmIFsUUEXCT6t50BizMLVEmcnjaZEcQWFvCRON5+BqyXRUBV4vejfiYQm 1fAXeLF109sEDPlJM4f/8kMYnMKeEhMvLgJrEYIqKZ7x1xWCFtFYv3UWWwQvYISJ2c+YYHYJS Fx8MUL5gmMvLOQpGYhSS1gZFrFqFGcWlSWWqRraKCXVJSZnlGSm5iZA+SZ6uWmFhcnpqfmJCY V6yXn525iBAYPAxDsYFwz1fkQoyQHk5Ior8DpuRFCfEn5KZUZicUZ8UWlOanFhxhlODiUJHjX g+QEi1LTUyvSMnOAYQyTluDgURLhFQRJ8xYXJOYWZ6ZDpE4x6nKcunH6JZMQS15+XqqUOO9mk CIBkKKM0jy4EbCYusQoKyXMywh0lBBPQWpRbmYJqvwrRnEORiVhXukzQFN4MvNK4Da9AjqCCe iI66dngRxRkoiQkmpgVJ6Vpf9weu8tTbOGhc58d8/mP/2082TqtP1yBtxVbv+8j/GsUYj3ePp WrH3yteTEmbnV/lIyu0vEmrbXLq/6ZavO89DWXFTKlN0k1K1FavKCi3pNs03frbXZ2r2+xGhz qWrrBsNdrInng1K/tTMWafHle6VqRDWd8ZZ9s/d3w2vmKU7X3r5SYinOSDTUYi4qTgQAT8v/H aQCAAA= X-Env-Sender: prvs=207696d45=Paul.Durrant@citrix.com X-Msg-Ref: server-15.tower-206.messagelabs.com!1486736677!70304487!2 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 9.2.3; banners=-,-,- X-VirusChecked: Checked Received: (qmail 21040 invoked from network); 10 Feb 2017 14:24:40 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-15.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 10 Feb 2017 14:24:40 -0000 X-IronPort-AV: E=Sophos;i="5.35,141,1484006400"; d="scan'208";a="406084504" From: Paul Durrant To: , Date: Fri, 10 Feb 2017 14:24:35 +0000 Message-ID: <1486736677-10953-2-git-send-email-paul.durrant@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1486736677-10953-1-git-send-email-paul.durrant@citrix.com> References: <1486736677-10953-1-git-send-email-paul.durrant@citrix.com> MIME-Version: 1.0 Cc: Juergen Gross , Boris Ostrovsky , Paul Durrant Subject: [Xen-devel] [PATCH v2 1/3] xen/privcmd: return -ENOTTY for unimplemented IOCTLs X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP The code sets the default return code to -ENOSYS but then overrides this to -EINVAL in the switch() statement's default case, which is clearly silly. This patch removes the override and sets the default return code to -ENOTTY, which is the conventional return for an unimplemented ioctl. Signed-off-by: Paul Durrant --- Cc: Boris Ostrovsky Cc: Juergen Gross v2: - Use -ENOTTY rather than -ENOSYS --- drivers/xen/privcmd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c index 6e3306f..5e5c7ae 100644 --- a/drivers/xen/privcmd.c +++ b/drivers/xen/privcmd.c @@ -551,7 +551,7 @@ static long privcmd_ioctl_mmap_batch(void __user *udata, int version) static long privcmd_ioctl(struct file *file, unsigned int cmd, unsigned long data) { - int ret = -ENOSYS; + int ret = -ENOTTY; void __user *udata = (void __user *) data; switch (cmd) { @@ -572,7 +572,6 @@ static long privcmd_ioctl(struct file *file, break; default: - ret = -EINVAL; break; }