From patchwork Sat Feb 18 01:29:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefano Stabellini X-Patchwork-Id: 9580977 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D365C60437 for ; Sat, 18 Feb 2017 01:31:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B385B2878F for ; Sat, 18 Feb 2017 01:31:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 979D12879C; Sat, 18 Feb 2017 01:31:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 25E062878F for ; Sat, 18 Feb 2017 01:31:53 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cetpu-0003nW-B1; Sat, 18 Feb 2017 01:29:18 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cetps-0003nK-Gk for xen-devel@lists.xenproject.org; Sat, 18 Feb 2017 01:29:16 +0000 Received: from [85.158.137.68] by server-7.bemta-3.messagelabs.com id 67/0C-23854-B63A7A85; Sat, 18 Feb 2017 01:29:15 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrELMWRWlGSWpSXmKPExsVybKJsh27W4uU RBl0rrSy+b5nM5MDocfjDFZYAxijWzLyk/IoE1ozOb/2MBUd5K57PO8jcwHiVq4uRi0NIYCqj xMwfM1ggnINMEhcf3mfrYuTkYBMwlPj7ZBOYLSIgIbGpYQUTiM0sYC1x780PdhBbWMBOYv6cI 4wgNouAqsTCR9eZQWxeAVeJX9M7wGokBOQkTh6bzAphZ0jM65kDZXtJLLpxCcpWk7h6bhPzBE aeBYwMqxjVi1OLylKLdC30kooy0zNKchMzc3QNDYz1clOLixPTU3MSk4r1kvNzNzEC/c4ABDs YL7Q7H2KU5GBSEuU94rM8QogvKT+lMiOxOCO+qDQntfgQowwHh5IEr8wioJxgUWp6akVaZg4w AGHSEhw8SiK8nguB0rzFBYm5xZnpEKlTjIpS4rzMIH0CIImM0jy4NljQX2KUlRLmZQQ6RIinI LUoN7MEVf4VozgHo5Iw712Q8TyZeSVw018BLWYCWtwZsRRkcUkiQkqqgdH1+oFbv18G7t28J7 Qq6+mGMxeyqw82RIdG1fU47jrw9T9vmIbfkvqSBWsmHMvZIH8gjdnebqmZXuzio5qfzO0CdGw el5x8InlPcNcenXlNZut+Nu9Zumz9l4C3i91vfTh4Kq2pX6eucer+2uBjpQ/eP3atvPnuS92d C25iDc82rWCc3p0uw3lIiaU4I9FQi7moOBEAx6NHjXUCAAA= X-Env-Sender: sstabellini@kernel.org X-Msg-Ref: server-8.tower-31.messagelabs.com!1487381353!86268945!1 X-Originating-IP: [198.145.29.136] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.2.3; banners=-,-,- X-VirusChecked: Checked Received: (qmail 1612 invoked from network); 18 Feb 2017 01:29:14 -0000 Received: from mail.kernel.org (HELO mail.kernel.org) (198.145.29.136) by server-8.tower-31.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 18 Feb 2017 01:29:14 -0000 Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0928820148; Sat, 18 Feb 2017 01:29:12 +0000 (UTC) Received: from sstabellini-ThinkPad-X260.hsd1.ca.comcast.net (96-82-76-110-static.hfc.comcastbusiness.net [96.82.76.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 01DFF20145; Sat, 18 Feb 2017 01:29:10 +0000 (UTC) From: Stefano Stabellini To: julien.grall@arm.com Date: Fri, 17 Feb 2017 17:29:06 -0800 Message-Id: <1487381346-3572-1-git-send-email-sstabellini@kernel.org> X-Mailer: git-send-email 1.9.1 X-Virus-Scanned: ClamAV using ClamSMTP Cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org Subject: [Xen-devel] [PATCH v2] xen/arm: warn if dom0_mem is not specified X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP The default dom0_mem is 128M which is not sufficient to boot a Ubuntu based Dom0. It is not clear what a better default value could be. Instead, loadly warn the user when dom0_mem is unspecified and wait 3 secs. Then use 512M. Signed-off-by: Stefano Stabellini --- xen/arch/arm/domain_build.c | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index c97a1f5..db7471f 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -1,4 +1,5 @@ #include +#include #include #include #include @@ -31,14 +32,11 @@ integer_param("dom0_max_vcpus", opt_dom0_max_vcpus); int dom0_11_mapping = 1; -#define DOM0_MEM_DEFAULT 0x8000000 /* 128 MiB */ -static u64 __initdata dom0_mem = DOM0_MEM_DEFAULT; +static u64 __initdata dom0_mem; static void __init parse_dom0_mem(const char *s) { dom0_mem = parse_size_and_unit(s, &s); - if ( dom0_mem == 0 ) - dom0_mem = DOM0_MEM_DEFAULT; } custom_param("dom0_mem", parse_dom0_mem); @@ -2125,7 +2123,21 @@ int construct_dom0(struct domain *d) BUG_ON(d->vcpu[0] == NULL); BUG_ON(v->is_initialised); - printk("*** LOADING DOMAIN 0 ***\n"); + if ( dom0_mem > 0 ) + printk("*** LOADING DOMAIN 0 ***\n"); + else + { + int i; + printk("*** PLEASE SPECIFY dom0_mem PARAMETER - USING 512M FOR NOW ***\n"); + for (i = 0; i < 3; i++) + { + printk("%d...", i+1); + mdelay(1000); + } + printk("\n"); + dom0_mem = MB(512); + } + iommu_hwdom_init(d);