From patchwork Mon Feb 20 11:00:25 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Cooper X-Patchwork-Id: 9582551 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8B54E604A0 for ; Mon, 20 Feb 2017 11:03:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7BBE7287E9 for ; Mon, 20 Feb 2017 11:03:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 70CC3287F0; Mon, 20 Feb 2017 11:03:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C778B28841 for ; Mon, 20 Feb 2017 11:03:03 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cfli8-0007Zv-11; Mon, 20 Feb 2017 11:00:52 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cfli7-0007Zc-Df for xen-devel@lists.xen.org; Mon, 20 Feb 2017 11:00:51 +0000 Received: from [85.158.137.68] by server-9.bemta-3.messagelabs.com id 76/80-12625-26CCAA85; Mon, 20 Feb 2017 11:00:50 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupnkeJIrShJLcpLzFFi42JxWrohUjfpzKo Ig2nPeCyWfFzM4sDocXT3b6YAxijWzLyk/IoE1oz+7c/ZC9rYKxreHGNvYDzI2sXIySEh4C+x /dZJMJtNQF9i94tPTCC2iIC6xOmOi0BxDg5mAT+JQw98QcLCAiESs1ZuBCtnEVCVOLKrgxmkh FfAQ+LnriKIiXIS54//ZAaxOQU8JaYc/sAGYgsBlWxreAxlq0lc67/EDmLzCghKnJz5hAXEZh aQkDj44gXzBEbeWUhSs5CkFjAyrWLUKE4tKkst0jU00EsqykzPKMlNzMwB8oz1clOLixPTU3M Sk4r1kvNzNzECA6eegYFxB+O2LudDjJIcTEqivHeWrIoQ4kvKT6nMSCzOiC8qzUktPsQow8Gh JME7/TRQTrAoNT21Ii0zBxjCMGkJDh4lEd5VIGne4oLE3OLMdIjUKUZdjlOfLrxkEmLJy89Ll RLnbQApEgApyijNgxsBi6dLjLJSwryMDAwMQjwFqUW5mSWo8q8YxTkYlYR5PUGm8GTmlcBteg V0BBPQETc9VoIcUZKIkJJqYJSp3tUcERn/2UbuiOhpqegVJm0HjlT8P8Lg4Bb/rspvzpe85mM ue9g6S6Lq/qzfWffvks8ddtFjvhtqjFJPnNiwrMDi2aZ5Gxle3wk1dBb/cyRVPchYvWFTnqql ycavPja811hzjjkcK4m50P+cd/H72fs+ZPlkntp2oHON+saIVcnzeRrMCpRYijMSDbWYi4oTA efL/fKiAgAA X-Env-Sender: prvs=21759e352=Andrew.Cooper3@citrix.com X-Msg-Ref: server-9.tower-31.messagelabs.com!1487588447!30982674!2 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 9.2.3; banners=-,-,- X-VirusChecked: Checked Received: (qmail 22211 invoked from network); 20 Feb 2017 11:00:49 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-9.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 20 Feb 2017 11:00:49 -0000 X-IronPort-AV: E=Sophos;i="5.35,186,1484006400"; d="scan'208";a="408330913" From: Andrew Cooper To: Xen-devel Date: Mon, 20 Feb 2017 11:00:25 +0000 Message-ID: <1487588434-4359-2-git-send-email-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1487588434-4359-1-git-send-email-andrew.cooper3@citrix.com> References: <1487588434-4359-1-git-send-email-andrew.cooper3@citrix.com> MIME-Version: 1.0 Cc: Andrew Cooper , Jan Beulich Subject: [Xen-devel] [PATCH 01/10] x86/cpuid: Disallow policy updates once the domain is running X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP On real hardware, the bulk of CPUID data is system-specific and constant. Hold the toolstack to the same behaviour when constructing domains. Values which are expected to change dynamically (e.g. OSXSAVE) are unaffected and continue to function as before. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich --- CC: Jan Beulich --- xen/arch/x86/domctl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c index 3b5c3c9..fc42cb1 100644 --- a/xen/arch/x86/domctl.c +++ b/xen/arch/x86/domctl.c @@ -941,6 +941,8 @@ long arch_do_domctl( case XEN_DOMCTL_set_cpuid: if ( d == currd ) /* no domain_pause() */ ret = -EINVAL; + else if ( d->creation_finished ) + ret = -EEXIST; /* No changing once the domain is running. */ else { domain_pause(d);