diff mbox

[1/2] Add libxendevicemodel to rpath-link

Message ID 1487761238-24938-1-git-send-email-paul.durrant@citrix.com (mailing list archive)
State New, archived
Headers show

Commit Message

Paul Durrant Feb. 22, 2017, 11 a.m. UTC
libxenctrl now depends on this library

Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
--
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
 xen-hooks.mak | 1 +
 1 file changed, 1 insertion(+)

Comments

Ian Jackson Feb. 22, 2017, 12:08 p.m. UTC | #1
Paul Durrant writes ("[PATCH 1/2] Add libxendevicemodel to rpath-link"):
> libxenctrl now depends on this library

FAOD, this and the next one look like patches against qemu-trad.  It's
normally a good idea to state this somewhere :-).

There is, AIUI, no forward/backward compatibility provided (at least
not for qemu-trad).  That is fine, but it means that the qemu-trad
patches need to be pushed first, and then the QEMU_TAG update needs to
be folded into relevant xen.git commit.  So when the series is ready
to commit, committers need to coordinate.

Anyway, both patches:

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

Ian.
Paul Durrant Feb. 22, 2017, 12:15 p.m. UTC | #2
> -----Original Message-----
> From: Ian Jackson [mailto:ian.jackson@eu.citrix.com]
> Sent: 22 February 2017 12:09
> To: Paul Durrant <Paul.Durrant@citrix.com>
> Cc: xen-devel@lists.xenproject.org
> Subject: Re: [PATCH 1/2] Add libxendevicemodel to rpath-link
> 
> Paul Durrant writes ("[PATCH 1/2] Add libxendevicemodel to rpath-link"):
> > libxenctrl now depends on this library
> 
> FAOD, this and the next one look like patches against qemu-trad.  It's
> normally a good idea to state this somewhere :-).

Sorry, there was meant to be a patch #0 for that.

> 
> There is, AIUI, no forward/backward compatibility provided (at least
> not for qemu-trad).  That is fine, but it means that the qemu-trad
> patches need to be pushed first, and then the QEMU_TAG update needs to
> be folded into relevant xen.git commit.  So when the series is ready
> to commit, committers need to coordinate.
> 

Indeed they do. I'll send the libxl series with URLs and tags pointing at my repos on xenbits and mention in the patch header that these need to be appropriately substituted.

> Anyway, both patches:
> 
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
> 

Thanks,

  Paul

> Ian.
diff mbox

Patch

diff --git a/xen-hooks.mak b/xen-hooks.mak
index c1ea4be..4356f67 100644
--- a/xen-hooks.mak
+++ b/xen-hooks.mak
@@ -28,6 +28,7 @@  LIBS += -L$(XEN_ROOT)/tools/xenstore -lxenstore
 LIBS += -Wl,-rpath-link=$(XEN_ROOT)/tools/libs/toollog
 LIBS += -Wl,-rpath-link=$(XEN_ROOT)/tools/libs/call
 LIBS += -Wl,-rpath-link=$(XEN_ROOT)/tools/libs/foreignmemory
+LIBS += -Wl,-rpath-link=$(XEN_ROOT)/tools/libs/devicemodel
 
 LDFLAGS := $(CFLAGS) $(LDFLAGS)