From patchwork Mon Mar 20 09:50:27 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Razvan Cojocaru X-Patchwork-Id: 9633615 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 94FA56020B for ; Mon, 20 Mar 2017 09:53:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8CB8A279B3 for ; Mon, 20 Mar 2017 09:53:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 80CB727FAE; Mon, 20 Mar 2017 09:53:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A53B8279B3 for ; Mon, 20 Mar 2017 09:53:12 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cptxd-00084D-2C; Mon, 20 Mar 2017 09:50:45 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cptxb-000847-Sq for xen-devel@lists.xen.org; Mon, 20 Mar 2017 09:50:44 +0000 Received: from [85.158.139.211] by server-15.bemta-5.messagelabs.com id 85/8F-01896-3F5AFC85; Mon, 20 Mar 2017 09:50:43 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprPIsWRWlGSWpSXmKPExsUSfTxjoe6npec jDPbeFbJY8nExiwOjx9Hdv5kCGKNYM/OS8isSWDPObrvNVvAktWLrkltsDYwzPLsYOTmEBDwk jm2/wtjFyAVkr2WUOD/rNSuEc5VR4tmy/WwwVQs2LGGBSOxnlLi7/hs7SIJNwFBi9cYWsCIRA WmJa58vg41iBik6tGQtUIKDQ1jAW2LGLjeQGhYBVYmJL+4wgoR5BTwlXuznBwlLCMhJnDw2mR XCzpFY/2YhM0iJhICUxP9WJZCJEgIbWCQu713JAlEjI/Fo4k22CYwCCxgZVjFqFKcWlaUW6Rp a6CUVZaZnlOQmZuboGhqY6uWmFhcnpqfmJCYV6yXn525iBAYWAxDsYGza7nmIUZKDSUmUd8nU 8xFCfEn5KZUZicUZ8UWlOanFhxhlODiUJHjzlgDlBItS01Mr0jJzgCEOk5bg4FES4XUDSfMWF yTmFmemQ6ROMepyzJm9+w2TEEtefl6qlDjvA5AiAZCijNI8uBGweLvEKCslzMsIdJQQT0FqUW 5mCar8K0ZxDkYlYd5TIFN4MvNK4Da9AjqCCeiIZTfOgBxRkoiQkmpg3GJw4b3Hk/kyV3v/GQe JXNf+eWwqR6vQopP7d32S6Ch5uCjHO45z79yAu6/bdDoNLrz0Z/Hdy5nrmBzIZSE6XX+64fny e883265ZsYJN5rCNaXac1c814ae2CH65bbzWWOGRVpz1xO4AxYsp17mFZyX4blMofVHB5eUkd EDn+vvz111OtfWyKbEUZyQaajEXFScCAOkDBg6yAgAA X-Env-Sender: rcojocaru@bitdefender.com X-Msg-Ref: server-10.tower-206.messagelabs.com!1490003441!73208478!1 X-Originating-IP: [91.199.104.161] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.2.3; banners=-,-,- X-VirusChecked: Checked Received: (qmail 12746 invoked from network); 20 Mar 2017 09:50:42 -0000 Received: from mx01.bbu.dsd.mx.bitdefender.com (HELO mx01.bbu.dsd.mx.bitdefender.com) (91.199.104.161) by server-10.tower-206.messagelabs.com with DHE-RSA-AES128-GCM-SHA256 encrypted SMTP; 20 Mar 2017 09:50:42 -0000 Received: (qmail 29230 invoked from network); 20 Mar 2017 11:50:40 +0200 Received: from unknown (HELO mx-sr.buh.bitdefender.com) (10.17.80.103) by mx01.bbu.dsd.mx.bitdefender.com with AES256-GCM-SHA384 encrypted SMTP; 20 Mar 2017 11:50:40 +0200 Received: from smtp01.buh.bitdefender.com (smtp.bitdefender.biz [10.17.80.75]) by mx-sr.buh.bitdefender.com (Postfix) with ESMTP id 51BF17FC29 for ; Mon, 20 Mar 2017 11:50:40 +0200 (EET) Received: (qmail 16676 invoked from network); 20 Mar 2017 11:50:40 +0200 Received: from xen.dsd.ro (HELO xen.dsd.bitdefender.biz) (rcojocaru@bitdefender.com@10.10.14.109) by smtp01.buh.bitdefender.com with AES128-SHA256 encrypted SMTP; 20 Mar 2017 11:50:40 +0200 From: Razvan Cojocaru To: xen-devel@lists.xen.org Date: Mon, 20 Mar 2017 11:50:27 +0200 Message-Id: <1490003427-11501-1-git-send-email-rcojocaru@bitdefender.com> X-Mailer: git-send-email 1.9.1 X-BitDefender-Scanner: Clean, Agent: BitDefender qmail 3.1.6 on smtp01.buh.bitdefender.com, sigver: 7.70280 X-BitDefender-Spam: No (0) X-BitDefender-SpamStamp: Build: [Engines: 2.15.8.1074, Dats: 443769, Stamp: 3], Multi: [Enabled, t: (0.000020, 0.053737)], BW: [Enabled, t: (0.000011)], RBL DNSBL: [Disabled], APM: [Enabled, Score: 500, t: (0.013883), Flags: 85D2ED72; NN_NO_CONTENT_TYPE; NN_LEGIT_SUMM_400_WORDS; NN_NO_LINK_NMD; NN_LEGIT_BITDEFENDER; NN_LEGIT_S_SQARE_BRACKETS; NN_LEGIT_MAILING_LIST_TO], SGN: [Enabled, t: (0.019835, 0.000637)], URL: [Enabled, t: (0.000005, 0.000001)], RTDA: [Enabled, t: (0.239216), Hit: No, Details: v2.4.4; Id: 11.5eumo8.1bblfs4nm.1th5], total: 0(775) X-BitDefender-CF-Stamp: none Cc: ravi.sahita@intel.com, tamas@tklengyel.com, wei.liu2@citrix.com, Razvan Cojocaru , andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, jbeulich@suse.com Subject: [Xen-devel] [PATCH V2] common/mem_access: merged mem_access setting interfaces X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP xc_altp2m_set_mem_access() and xc_set_mem_access() end up doing the same thing in the hypervisor, but the former is a HVMOP and the latter a DOMCTL. Since nobody is currently using, or has stated intent to use, this functionality specifically as an HVMOP, this patch removes the HVMOP while adding an extra parameter to the more flexible DOMCTL variant, in which the altp2m view can be transmitted (0 for the default view, or when altp2m is disabled). The xen-access test has been updated in the process. Signed-off-by: Razvan Cojocaru --- Changes since V1: - Removed XEN_DOMCTL_INTERFACE_VERSION bump (as the "x86: remove PVHv1 code" already does this for this release). - Replaced uint16_t pad; with uint16_t pad[3]; as suggested by Tamas. --- tools/libxc/include/xenctrl.h | 10 +++------- tools/libxc/xc_altp2m.c | 25 ------------------------- tools/libxc/xc_mem_access.c | 14 +++++++++----- tools/tests/xen-access/xen-access.c | 25 ++++++++----------------- xen/arch/x86/hvm/hvm.c | 10 ---------- xen/common/mem_access.c | 4 ++-- xen/include/public/hvm/hvm_op.h | 15 +-------------- xen/include/public/memory.h | 2 ++ 8 files changed, 25 insertions(+), 80 deletions(-) diff --git a/tools/libxc/include/xenctrl.h b/tools/libxc/include/xenctrl.h index 2d97d36..10d80b3 100644 --- a/tools/libxc/include/xenctrl.h +++ b/tools/libxc/include/xenctrl.h @@ -1923,9 +1923,6 @@ int xc_altp2m_destroy_view(xc_interface *handle, domid_t domid, /* Switch all vCPUs of the domain to the specified altp2m view */ int xc_altp2m_switch_to_view(xc_interface *handle, domid_t domid, uint16_t view_id); -int xc_altp2m_set_mem_access(xc_interface *handle, domid_t domid, - uint16_t view_id, xen_pfn_t gfn, - xenmem_access_t access); int xc_altp2m_change_gfn(xc_interface *handle, domid_t domid, uint16_t view_id, xen_pfn_t old_gfn, xen_pfn_t new_gfn); @@ -1956,9 +1953,8 @@ int xc_mem_paging_load(xc_interface *xch, domid_t domain_id, * Allowed types are XENMEM_access_default, XENMEM_access_n, any combination of * XENMEM_access_ + (rwx), and XENMEM_access_rx2rw */ -int xc_set_mem_access(xc_interface *xch, domid_t domain_id, - xenmem_access_t access, uint64_t first_pfn, - uint32_t nr); +int xc_set_mem_access(xc_interface *xch, domid_t domain_id, uint16_t view_id, + xenmem_access_t access, uint64_t first_pfn, uint32_t nr); /* * Set an array of pages to their respective access in the access array. @@ -1966,7 +1962,7 @@ int xc_set_mem_access(xc_interface *xch, domid_t domain_id, * The same allowed access types as for xc_set_mem_access() apply. */ int xc_set_mem_access_multi(xc_interface *xch, domid_t domain_id, - uint8_t *access, uint64_t *pages, + uint16_t view_id, uint8_t *access, uint64_t *pages, uint32_t nr); /* diff --git a/tools/libxc/xc_altp2m.c b/tools/libxc/xc_altp2m.c index 0639632..4f44a7b 100644 --- a/tools/libxc/xc_altp2m.c +++ b/tools/libxc/xc_altp2m.c @@ -163,31 +163,6 @@ int xc_altp2m_switch_to_view(xc_interface *handle, domid_t domid, return rc; } -int xc_altp2m_set_mem_access(xc_interface *handle, domid_t domid, - uint16_t view_id, xen_pfn_t gfn, - xenmem_access_t access) -{ - int rc; - DECLARE_HYPERCALL_BUFFER(xen_hvm_altp2m_op_t, arg); - - arg = xc_hypercall_buffer_alloc(handle, arg, sizeof(*arg)); - if ( arg == NULL ) - return -1; - - arg->version = HVMOP_ALTP2M_INTERFACE_VERSION; - arg->cmd = HVMOP_altp2m_set_mem_access; - arg->domain = domid; - arg->u.set_mem_access.view = view_id; - arg->u.set_mem_access.hvmmem_access = access; - arg->u.set_mem_access.gfn = gfn; - - rc = xencall2(handle->xcall, __HYPERVISOR_hvm_op, HVMOP_altp2m, - HYPERCALL_BUFFER_AS_ARG(arg)); - - xc_hypercall_buffer_free(handle, arg); - return rc; -} - int xc_altp2m_change_gfn(xc_interface *handle, domid_t domid, uint16_t view_id, xen_pfn_t old_gfn, xen_pfn_t new_gfn) diff --git a/tools/libxc/xc_mem_access.c b/tools/libxc/xc_mem_access.c index 9536635..4242527 100644 --- a/tools/libxc/xc_mem_access.c +++ b/tools/libxc/xc_mem_access.c @@ -25,17 +25,19 @@ int xc_set_mem_access(xc_interface *xch, domid_t domain_id, + uint16_t view_id, xenmem_access_t access, uint64_t first_pfn, uint32_t nr) { xen_mem_access_op_t mao = { - .op = XENMEM_access_op_set_access, - .domid = domain_id, - .access = access, - .pfn = first_pfn, - .nr = nr + .op = XENMEM_access_op_set_access, + .domid = domain_id, + .access = access, + .pfn = first_pfn, + .nr = nr, + .view_id = view_id }; return do_memory_op(xch, XENMEM_access_op, &mao, sizeof(mao)); @@ -43,6 +45,7 @@ int xc_set_mem_access(xc_interface *xch, int xc_set_mem_access_multi(xc_interface *xch, domid_t domain_id, + uint16_t view_id, uint8_t *access, uint64_t *pages, uint32_t nr) @@ -59,6 +62,7 @@ int xc_set_mem_access_multi(xc_interface *xch, .access = XENMEM_access_default + 1, /* Invalid value */ .pfn = ~0UL, /* Invalid GFN */ .nr = nr, + .view_id = view_id, }; if ( xc_hypercall_bounce_pre(xch, pages) || diff --git a/tools/tests/xen-access/xen-access.c b/tools/tests/xen-access/xen-access.c index 9d4f957..bd348ef 100644 --- a/tools/tests/xen-access/xen-access.c +++ b/tools/tests/xen-access/xen-access.c @@ -475,9 +475,6 @@ int main(int argc, char *argv[]) /* With altp2m we just create a new, restricted view of the memory */ if ( memaccess && altp2m ) { - xen_pfn_t gfn = 0; - unsigned long perm_set = 0; - rc = xc_altp2m_set_domain_state( xch, domain_id, 1 ); if ( rc < 0 ) { @@ -495,15 +492,9 @@ int main(int argc, char *argv[]) DPRINTF("altp2m view created with id %u\n", altp2m_view_id); DPRINTF("Setting altp2m mem_access permissions.. "); - for(; gfn < xenaccess->max_gpfn; ++gfn) - { - rc = xc_altp2m_set_mem_access( xch, domain_id, altp2m_view_id, gfn, - default_access); - if ( !rc ) - perm_set++; - } - - DPRINTF("done! Permissions set on %lu pages.\n", perm_set); + rc = xc_set_mem_access(xch, domain_id, altp2m_view_id, default_access, + 0, xenaccess->max_gpfn); + DPRINTF("done!"); rc = xc_altp2m_switch_to_view( xch, domain_id, altp2m_view_id ); if ( rc < 0 ) @@ -523,14 +514,14 @@ int main(int argc, char *argv[]) if ( memaccess && !altp2m ) { /* Set the default access type and convert all pages to it */ - rc = xc_set_mem_access(xch, domain_id, default_access, ~0ull, 0); + rc = xc_set_mem_access(xch, domain_id, 0, default_access, ~0ull, 0); if ( rc < 0 ) { ERROR("Error %d setting default mem access type\n", rc); goto exit; } - rc = xc_set_mem_access(xch, domain_id, default_access, START_PFN, + rc = xc_set_mem_access(xch, domain_id, 0, default_access, START_PFN, (xenaccess->max_gpfn - START_PFN) ); if ( rc < 0 ) @@ -606,8 +597,8 @@ int main(int argc, char *argv[]) rc = xc_altp2m_set_domain_state(xch, domain_id, 0); rc = xc_monitor_singlestep(xch, domain_id, 0); } else { - rc = xc_set_mem_access(xch, domain_id, XENMEM_access_rwx, ~0ull, 0); - rc = xc_set_mem_access(xch, domain_id, XENMEM_access_rwx, START_PFN, + rc = xc_set_mem_access(xch, domain_id, 0, XENMEM_access_rwx, ~0ull, 0); + rc = xc_set_mem_access(xch, domain_id, 0, XENMEM_access_rwx, START_PFN, (xenaccess->max_gpfn - START_PFN) ); } @@ -685,7 +676,7 @@ int main(int argc, char *argv[]) } else if ( default_access != after_first_access ) { - rc = xc_set_mem_access(xch, domain_id, after_first_access, + rc = xc_set_mem_access(xch, domain_id, 0, after_first_access, req.u.mem_access.gfn, 1); if (rc < 0) { diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index 0282986..863ac74 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -4343,7 +4343,6 @@ static int do_altp2m_op( case HVMOP_altp2m_create_p2m: case HVMOP_altp2m_destroy_p2m: case HVMOP_altp2m_switch_p2m: - case HVMOP_altp2m_set_mem_access: case HVMOP_altp2m_change_gfn: break; default: @@ -4451,15 +4450,6 @@ static int do_altp2m_op( rc = p2m_switch_domain_altp2m_by_id(d, a.u.view.view); break; - case HVMOP_altp2m_set_mem_access: - if ( a.u.set_mem_access.pad ) - rc = -EINVAL; - else - rc = p2m_set_mem_access(d, _gfn(a.u.set_mem_access.gfn), 1, 0, 0, - a.u.set_mem_access.hvmmem_access, - a.u.set_mem_access.view); - break; - case HVMOP_altp2m_change_gfn: if ( a.u.change_gfn.pad1 || a.u.change_gfn.pad2 ) rc = -EINVAL; diff --git a/xen/common/mem_access.c b/xen/common/mem_access.c index 19f63bb..35afb1c 100644 --- a/xen/common/mem_access.c +++ b/xen/common/mem_access.c @@ -67,7 +67,7 @@ int mem_access_memop(unsigned long cmd, break; rc = p2m_set_mem_access(d, _gfn(mao.pfn), mao.nr, start_iter, - MEMOP_CMD_MASK, mao.access, 0); + MEMOP_CMD_MASK, mao.access, mao.view_id); if ( rc > 0 ) { ASSERT(!(rc & MEMOP_CMD_MASK)); @@ -78,7 +78,7 @@ int mem_access_memop(unsigned long cmd, case XENMEM_access_op_set_access_multi: rc = p2m_set_mem_access_multi(d, mao.pfn_list, mao.access_list, mao.nr, - start_iter, MEMOP_CMD_MASK, 0); + start_iter, MEMOP_CMD_MASK, mao.view_id); if ( rc > 0 ) { ASSERT(!(rc & MEMOP_CMD_MASK)); diff --git a/xen/include/public/hvm/hvm_op.h b/xen/include/public/hvm/hvm_op.h index bc00ef0..cf6f24f 100644 --- a/xen/include/public/hvm/hvm_op.h +++ b/xen/include/public/hvm/hvm_op.h @@ -219,18 +219,6 @@ struct xen_hvm_altp2m_view { typedef struct xen_hvm_altp2m_view xen_hvm_altp2m_view_t; DEFINE_XEN_GUEST_HANDLE(xen_hvm_altp2m_view_t); -struct xen_hvm_altp2m_set_mem_access { - /* view */ - uint16_t view; - /* Memory type */ - uint16_t hvmmem_access; /* xenmem_access_t */ - uint32_t pad; - /* gfn */ - uint64_t gfn; -}; -typedef struct xen_hvm_altp2m_set_mem_access xen_hvm_altp2m_set_mem_access_t; -DEFINE_XEN_GUEST_HANDLE(xen_hvm_altp2m_set_mem_access_t); - struct xen_hvm_altp2m_change_gfn { /* view */ uint16_t view; @@ -258,7 +246,7 @@ struct xen_hvm_altp2m_op { #define HVMOP_altp2m_destroy_p2m 5 /* Switch view for an entire domain */ #define HVMOP_altp2m_switch_p2m 6 -/* Notify that a page of memory is to have specific access types */ +/* Deprecated by XENMEM_access_op_set_access */ #define HVMOP_altp2m_set_mem_access 7 /* Change a p2m entry to have a different gfn->mfn mapping */ #define HVMOP_altp2m_change_gfn 8 @@ -269,7 +257,6 @@ struct xen_hvm_altp2m_op { struct xen_hvm_altp2m_domain_state domain_state; struct xen_hvm_altp2m_vcpu_enable_notify enable_notify; struct xen_hvm_altp2m_view view; - struct xen_hvm_altp2m_set_mem_access set_mem_access; struct xen_hvm_altp2m_change_gfn change_gfn; uint8_t pad[64]; } u; diff --git a/xen/include/public/memory.h b/xen/include/public/memory.h index 6eee0c8..07ccc2a 100644 --- a/xen/include/public/memory.h +++ b/xen/include/public/memory.h @@ -444,6 +444,8 @@ struct xen_mem_access_op { /* xenmem_access_t */ uint8_t access; domid_t domid; + uint16_t view_id; + uint16_t pad[3]; /* * Number of pages for set op (or size of pfn_list for * XENMEM_access_op_set_access_multi)