From patchwork Fri Mar 24 11:00:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Durrant X-Patchwork-Id: 9642699 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 803F660327 for ; Fri, 24 Mar 2017 11:02:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6249E27F07 for ; Fri, 24 Mar 2017 11:02:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5280B26E81; Fri, 24 Mar 2017 11:02:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id DBE0126E81 for ; Fri, 24 Mar 2017 11:02:47 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1crMxB-0003uD-Sq; Fri, 24 Mar 2017 11:00:21 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1crMxB-0003u4-7A for xen-devel@lists.xenproject.org; Fri, 24 Mar 2017 11:00:21 +0000 Received: from [85.158.139.211] by server-15.bemta-5.messagelabs.com id AE/59-01896-44CF4D85; Fri, 24 Mar 2017 11:00:20 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrNLMWRWlGSWpSXmKPExsXitHRDpK7Dnys RBu8em1h83zKZyYHR4/CHKywBjFGsmXlJ+RUJrBlfzgYUrBKsmPCuuoFxK18XIyeHhIC/xKF7 75hBbDYBHYmpTy+xdjFycIgIqEjc3mvQxcjFwSzwnEni9Yaf7CA1wgKBEvd2fGIEsVkEVCW+7 5nMAmLzCrhJnHy0mQ1ippzE+eM/wWYKAc1ZP3UWG0SNoMTJmU/A6pkFJCQOvnjBPIGRexaS1C wkqQWMTKsYNYpTi8pSi3QNTfSSijLTM0pyEzNzdA0NTPVyU4uLE9NTcxKTivWS83M3MQIDgQE IdjCePe15iFGSg0lJlNdt25UIIb6k/JTKjMTijPii0pzU4kOMMhwcShK8b38B5QSLUtNTK9Iy c4AhCZOW4OBREuHl/w2U5i0uSMwtzkyHSJ1iVJQS570M0icAksgozYNrg8XBJUZZKWFeRqBDh HgKUotyM0tQ5V8xinMwKgnzBoGM58nMK4Gb/gpoMRPQ4tkbwBaXJCKkpBoYXZbqx8X53ZINOK bBvSdy8dqXDwSdbf/uzEoP5jDQ3v3Z1b7ZmGvO3+vzXt/XVJ8oUbBsjb6Aw2yh2YsEbU93GCz aqdUbd8P21+SedT9t+5eFb6qojN8W7yqWzF6l/eONxL+wOX5+z2dE1P71nZ2uZrvp3eyskhJt /bmXueT4llYp8dneKJZTYinOSDTUYi4qTgQA2r5D834CAAA= X-Env-Sender: prvs=249263d75=Paul.Durrant@citrix.com X-Msg-Ref: server-15.tower-206.messagelabs.com!1490353215!77161587!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 9.2.3; banners=-,-,- X-VirusChecked: Checked Received: (qmail 62226 invoked from network); 24 Mar 2017 11:00:16 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-15.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 24 Mar 2017 11:00:16 -0000 X-IronPort-AV: E=Sophos;i="5.36,214,1486425600"; d="scan'208";a="415719358" From: Paul Durrant To: Date: Fri, 24 Mar 2017 11:00:13 +0000 Message-ID: <1490353213-2734-1-git-send-email-paul.durrant@citrix.com> X-Mailer: git-send-email 2.1.4 MIME-Version: 1.0 Cc: Stefano Stabellini , Wei Liu , George Dunlap , Andrew Cooper , Ian Jackson , Tim Deegan , Paul Durrant , Jan Beulich Subject: [Xen-devel] [PATCH v2] docs: update HVM emulated unplug protocol to cover NVMe disks X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Recent discussions on xen-devel have highlighted that to properly support displacing emulated NVMe disks with PV equivalents will need updates to PV frontends. Therefore it is important that, if an emulated NVMe disk is exposed to a guest with an existing PV storage frontend, that frontend does not inadvertently cause unplug of that emulated disk when unplugging IDE or SCSI disks. This patch defines a new bit in the mask used to instruct QEMU to unplug emulated devices which will instruct QEMU to unplug NVMe disks and limits the semantics of the existing 'all' disk-unplug bit to only IDE and/or SCSI disks. Signed-off-by: Paul Durrant Reviewed-by: Wei Liu Acked-by: George Dunlap --- Cc: Andrew Cooper Cc: George Dunlap Cc: Ian Jackson Cc: Jan Beulich Cc: Konrad Rzeszutek Wilk Cc: Stefano Stabellini Cc: Tim Deegan Cc: Wei Liu v2: - Updated commit comment with background rather then referring to thread URL. --- docs/misc/hvm-emulated-unplug.markdown | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/docs/misc/hvm-emulated-unplug.markdown b/docs/misc/hvm-emulated-unplug.markdown index 8ead0c5..f6b27ed 100644 --- a/docs/misc/hvm-emulated-unplug.markdown +++ b/docs/misc/hvm-emulated-unplug.markdown @@ -32,12 +32,13 @@ drivers): blacklisted and should not load. 6. The drivers write a two-byte bitmask of devices to unplug to IO - port `0x10`. The defined fields are: + port `0x10`. The defined bits are: - * `1` -- All emulated disks (not including CD drives) - * `2` -- All emulated NICs - * `4` -- All IDE disks except for the primary master (not including CD - drives) + * `0` -- All emulated IDE and SCSI disks (not including CD drives). + * `1` -- All emulated NICs. + * `2` -- All IDE disks except for the primary master (not including CD + drives). This is overridden by bit 0. + * `3` -- All emulated NVMe disks. The relevant emulated devices then disappear from the relevant buses. For most guest operating systems, you want to do this