diff mbox

[2/2] sg-report-flight: Do not report many non-regressions as allowable

Message ID 1492693645-4714-2-git-send-email-ian.jackson@eu.citrix.com (mailing list archive)
State New, archived
Headers show

Commit Message

Ian Jackson April 20, 2017, 1:07 p.m. UTC
In bd648aea2ebe
 sg-report-flight: report allowable regressions separately in summary
whether the regression was allowable was put in $allow, but this
was erroneously not used.

In 4a210cda9cc8
 sg-report-flight: fix allowable failure logic not to reuse $allow for two purposes (!)
that use of the variable, which was never used, was removed.

However, what ought to happen, is that $failv->{Allow} would be set to
1 if the entry matched an allow pattern, and only if it was a blocker.
That makes the logic in "report ... separately" correct.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
 sg-report-flight |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox


diff --git a/sg-report-flight b/sg-report-flight
index 5b8f67a..5e362b9 100755
--- a/sg-report-flight
+++ b/sg-report-flight
@@ -888,6 +888,7 @@  END
             print DEBUG " allow $item?";
             foreach my $allowpat (@allows) {
                 next unless $item =~ m/$allowpat/;
+                $failv->{Allow}= 1;
                 print DEBUG " allowed";
@@ -895,7 +896,6 @@  END
             print DEBUG "\n";
 	$failv->{Blocker}= $blocker;
-        $failv->{Allow}= 1;
 	$failv->{SummaryCore}= $rtups[0][2];
 	$failv->{SummaryRefFlight}= $rtups[0][3];
 	$failv->{Summary}= $failv->{SummaryCore};