diff mbox

[OSSTEST,2/3] proxy config: Actually set https_proxy too

Message ID 1493133217-15622-2-git-send-email-ian.jackson@eu.citrix.com (mailing list archive)
State New, archived
Headers show

Commit Message

Ian Jackson April 25, 2017, 3:13 p.m. UTC 
05406e5aaffb "proxy config: Set https_proxy too" was ineffective
because in d22b80bb "proxy config: Factor out http_proxy_envsettings"
the variable name $var was not substituted into the new
supposedly-more-general shell rune, which consequently lacked the
appropriate generality.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
---
 Osstest/TestSupport.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox

Patch

diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
index d482e1d..19bdd23 100644
--- a/Osstest/TestSupport.pm
+++ b/Osstest/TestSupport.pm
@@ -1911,7 +1911,7 @@  sub http_proxy_envsettings ($) {
     return unless $proxy;
     my @script;
     foreach my $var (qw(http_proxy https_proxy)) {
-        push @script, "http_proxy=$proxy", "export http_proxy";
+        push @script, "$var=$proxy", "export $var";
     }
     return (join '; ', @script).';';
 }