diff mbox

[OSSTEST,03/24] cs-flight-create: Fix usage error message

Message ID 1495105294-25989-3-git-send-email-ian.jackson@eu.citrix.com (mailing list archive)
State New, archived
Headers show

Commit Message

Ian Jackson May 18, 2017, 11:01 a.m. UTC 
This spuriously prints $!.  It's still a poor message.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
 cs-flight-create | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Roger Pau Monné May 23, 2017, 1:58 p.m. UTC | #1 
On Thu, May 18, 2017 at 12:01:13PM +0100, Ian Jackson wrote:
> This spuriously prints $!.  It's still a poor message.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
> ---
>  cs-flight-create | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/cs-flight-create b/cs-flight-create
> index a412396..dc61e62 100755
> --- a/cs-flight-create
> +++ b/cs-flight-create
> @@ -24,7 +24,7 @@ use Osstest;
>  
>  csreadconfig();
>  
> -@ARGV==2 or die $!;
> +@ARGV==2 or die;

Maybe a "Invalid number of arguments provided, expected 2"?

In any case:

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Roger.
diff mbox

Patch

diff --git a/cs-flight-create b/cs-flight-create
index a412396..dc61e62 100755
--- a/cs-flight-create
+++ b/cs-flight-create
@@ -24,7 +24,7 @@  use Osstest;
 
 csreadconfig();
 
-@ARGV==2 or die $!;
+@ARGV==2 or die;
 our ($intended,$branch) = @ARGV;
 
 my ($flight) =