From patchwork Tue May 23 18:07:53 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Jackson X-Patchwork-Id: 9743163 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 304F96037F for ; Tue, 23 May 2017 18:10:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1FECF284AA for ; Tue, 23 May 2017 18:10:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0C6ED28549; Tue, 23 May 2017 18:10:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 7211528545 for ; Tue, 23 May 2017 18:10:48 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dDEEM-0006Zz-A8; Tue, 23 May 2017 18:08:26 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dDEEL-0006Zt-3t for xen-devel@lists.xenproject.org; Tue, 23 May 2017 18:08:25 +0000 Received: from [85.158.139.211] by server-2.bemta-5.messagelabs.com id D5/12-02006-89A74295; Tue, 23 May 2017 18:08:24 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrKLMWRWlGSWpSXmKPExsXitHSDve70KpV Ig9k/dSy+b5nM5MDocfjDFZYAxijWzLyk/IoE1owNE3kLFrFVbP1yj7mBcTJrFyMnh4SAv8Ty HzfZQGw2AV2Jpi1/gWwODhEBFYnbew1ATGaBUIkdLyxBKoQFPCVaew+CdbIIqEpMWrEMzOYFi i99dQpqopzE+eM/mUFahQTUJOauj4coEZQ4OfMJC4jNLCAhcfDFC+YJjNyzkKRmIUktYGRaxa hRnFpUllqka2Ssl1SUmZ5RkpuYmaNraGCql5taXJyYnpqTmFSsl5yfu4kRGAT1DAyMOxh3tPs dYpTkYFIS5Q0pU4kU4kvKT6nMSCzOiC8qzUktPsQow8GhJMEbWwmUEyxKTU+tSMvMAYYjTFqC g0dJhFcbJM1bXJCYW5yZDpE6xajLMefe1/dMQix5+XmpUuK8B0GKBECKMkrz4EbAYuMSo6yUM C8jAwODEE9BalFuZgmq/CtGcQ5GJWFedpApPJl5JXCbXgEdwQR0hOtdZZAjShIRUlINjOW2jD avmDuTpwX6Hqn8bJjx5fFqtYeXCr0vJJa8O3DlEaMA8/cd29Z/Wx7y9LNnhK70bKfwFospH29 9f7KiXEhjc3dqWmkIU8Dv1L0BNotOaBl/zo31NTjZ0NOxIGvmcq4zFjqvl1sWGgilnOipez19 62Gd16s0Di/afdC0IiRmccDju5OlWpRYijMSDbWYi4oTAWMpKwiIAgAA X-Env-Sender: prvs=30992e160=Ian.Jackson@citrix.com X-Msg-Ref: server-12.tower-206.messagelabs.com!1495562900!63641332!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 9.4.12; banners=-,-,- X-VirusChecked: Checked Received: (qmail 4658 invoked from network); 23 May 2017 18:08:23 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-12.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 23 May 2017 18:08:23 -0000 X-IronPort-AV: E=Sophos;i="5.38,383,1491264000"; d="scan'208";a="433721962" From: Ian Jackson To: Date: Tue, 23 May 2017 19:07:53 +0100 Message-ID: <1495562873-29798-1-git-send-email-ian.jackson@eu.citrix.com> X-Mailer: git-send-email 2.1.4 MIME-Version: 1.0 Cc: Ian Jackson Subject: [Xen-devel] [OSSTEST PATCH] ts-examine-logs-save: Do not do readdir $! check X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP In perl 5.14 in Massachusetts, this produces this message /home/logs/logs/109694/test-amd64-amd64-examine Bad file descriptor at ./ts-examine-logs-save line 100. Sadly this means there is no way to tell failure apart from end of directory. This patch should be reverted when we have a fixed version of perl. Signed-off-by: Ian Jackson --- ts-examine-logs-save | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ts-examine-logs-save b/ts-examine-logs-save index 014522a..b9c9941 100755 --- a/ts-examine-logs-save +++ b/ts-examine-logs-save @@ -97,7 +97,7 @@ sub save_logs () { logm("saving $f"); link "$stash/$f", "$td/$f" or die "$stash $td $f $!"; } - die "$stash $!" if $!; + # die "$stash $!" if $!; closedir D; }