| Message ID | 1495642470-1079-1-git-send-email-ian.jackson@eu.citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Thanks for the test reports and the release-ack. Ideally I would like a review but I may not get one. Julien, or Michael, do you feel qualified to review this ? Looking at the REST MAINTAINERS: I know Andrew, Jan and Konrad are extremely busy right now so I don't want to ask them to stare at these Makefiles, and Wei is away. Stefano, do you think you could look ? If I can't get a review, I do think I should get some kind of ack to commit it. An ack from a REST maintainer suffices I think. Thanks, Ian.
Hi Ian, On 25/05/17 13:42, Ian Jackson wrote: > Thanks for the test reports and the release-ack. Ideally I would like > a review but I may not get one. Julien, or Michael, do you feel > qualified to review this ? My knowledge of the build system is very limited. So I don't think my review here will be useful sorry. > > Looking at the REST MAINTAINERS: > > I know Andrew, Jan and Konrad are extremely busy right now so I don't > want to ask them to stare at these Makefiles, and Wei is away. > > Stefano, do you think you could look ? > > If I can't get a review, I do think I should get some kind of ack to > commit it. An ack from a REST maintainer suffices I think. Cheers,
On 25/05/17 13:55, Julien Grall wrote: > Hi Ian, > > On 25/05/17 13:42, Ian Jackson wrote: >> Thanks for the test reports and the release-ack. Ideally I would like >> a review but I may not get one. Julien, or Michael, do you feel >> qualified to review this ? > > My knowledge of the build system is very limited. So I don't think my > review here will be useful sorry. > >> >> Looking at the REST MAINTAINERS: >> >> I know Andrew, Jan and Konrad are extremely busy right now so I don't >> want to ask them to stare at these Makefiles, and Wei is away. >> >> Stefano, do you think you could look ? >> >> If I can't get a review, I do think I should get some kind of ack to >> commit it. An ack from a REST maintainer suffices I think. If it helps, the arguments look persuasive and the changes appear to match the arguments. Acked-by: Andrew Cooper <andrew.cooper3@citrix.com> ~Andrew
On Wed, May 24, 2017 at 05:14:29PM +0100, Ian Jackson wrote: > This is the only one of the Makefiles invoked with -C from the > toplevel which lacks this target. > > CC: Julien Grall <julien.grall@arm.com> > CC: M A Young <m.a.young@durham.ac.uk> > CC: Andrew Cooper <andrew.cooper3@citrix.com> > CC: Wei Liu <wei.liu2@citrix.com> > Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com> Acked-by: Roger Pau Monné <roger.pau@citrix.com> Roger.
diff --git a/tools/include/Makefile b/tools/include/Makefile index 98b479f..db0f030 100644 --- a/tools/include/Makefile +++ b/tools/include/Makefile @@ -4,8 +4,8 @@ include $(XEN_ROOT)/tools/Rules.mk # Relative to $(XEN_ROOT)/xen/xsm/flask FLASK_H_DEPEND := policy/initial_sids -.PHONY: all -all: xen-foreign xen/.dir xen-xsm/.dir +.PHONY: all build +all build: xen-foreign xen/.dir xen-xsm/.dir .PHONY: xen-foreign xen-foreign:
This is the only one of the Makefiles invoked with -C from the toplevel which lacks this target. CC: Julien Grall <julien.grall@arm.com> CC: M A Young <m.a.young@durham.ac.uk> CC: Andrew Cooper <andrew.cooper3@citrix.com> CC: Wei Liu <wei.liu2@citrix.com> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com> --- tools/include/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)