diff mbox

[OSSTEST] arm64, armhf: Use dtuart for console by default

Message ID 1495795491-27670-1-git-send-email-ian.jackson@eu.citrix.com (mailing list archive)
State New, archived
Headers show

Commit Message

Ian Jackson May 26, 2017, 10:44 a.m. UTC 
We don't want to have to set a host property for each ARM host.

Julien writes:

 This command line should always work for arm64.  If the device-tree
 does not provide the property then it is a bug.  We want the command
 line to be as agnostic as possible from the platform.

Reported-by: Julien Grall <julien.grall@arm.com>
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
 ts-xen-install | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Julien Grall May 26, 2017, 10:48 a.m. UTC | #1 
Hi Ian,

On 26/05/17 11:44, Ian Jackson wrote:
> We don't want to have to set a host property for each ARM host.
>
> Julien writes:
>
>  This command line should always work for arm64.  If the device-tree
>  does not provide the property then it is a bug.  We want the command

NIT: "does not provide the property 'stdout-path' "

>  line to be as agnostic as possible from the platform.
>
> Reported-by: Julien Grall <julien.grall@arm.com>
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>

FWIW:

Acked-by: Julien Grall <julien.grall@arm.com>

Cheers,
diff mbox

Patch

diff --git a/ts-xen-install b/ts-xen-install
index 9eb2131..3ab6090 100755
--- a/ts-xen-install
+++ b/ts-xen-install
@@ -145,7 +145,9 @@  sub adjustconfig () {
 sub setupboot () {
     my $xenhopt= "conswitch=x watchdog noreboot";
 
-    my $cons= get_host_property($ho, 'XenSerialConsole', 'com1');
+    my $cons= get_host_property($ho, 'XenSerialConsole',
+				$r{arch} =~ m/^arm/ ? 'dtuart'
+				: 'com1');
 
     if ( $cons eq "com1" ) {
 	$xenhopt .= " com1=$c{Baud},8n1 console=com1,vga gdb=com1";