From patchwork Thu Jun 1 13:10:50 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Cooper X-Patchwork-Id: 9759599 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C2D6C60375 for ; Thu, 1 Jun 2017 13:13:23 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A9EC123B23 for ; Thu, 1 Jun 2017 13:13:23 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9C73F25E13; Thu, 1 Jun 2017 13:13:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 232E923B23 for ; Thu, 1 Jun 2017 13:13:23 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dGPsR-00046p-Jl; Thu, 01 Jun 2017 13:10:59 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dGPsQ-00046g-F6 for xen-devel@lists.xen.org; Thu, 01 Jun 2017 13:10:58 +0000 Received: from [85.158.143.35] by server-10.bemta-6.messagelabs.com id F7/5F-03613-16210395; Thu, 01 Jun 2017 13:10:57 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHLMWRWlGSWpSXmKPExsXitHRDpG6ikEG kwYlpQhZLPi5mcWD0OLr7N1MAYxRrZl5SfkUCa8beaRtYCw7yVjS8f8bSwPiHq4uRk0NCwF/i 3cPdzCA2m4C+xO4Xn5hAbBEBdYnTHRdZuxi5OJgFepglVk29zgiSEBaIktjwfRYriM0ioCLRs bsJzOYV8JA4fP49E8RQOYnzx3+CDRUSUJO41n+JHaJGUOLkzCcsIDazgITEwRcvmCcwcs9Ckp qFJLWAkWkVo0ZxalFZapGukbFeUlFmekZJbmJmjq6hgZlebmpxcWJ6ak5iUrFecn7uJkZgODA AwQ7GP/MDDzFKcjApifJW2OhFCvEl5adUZiQWZ8QXleakFh9ilOHgUJLg1RM0iBQSLEpNT61I y8wBBiZMWoKDR0mEVwgkzVtckJhbnJkOkTrFqCglzmsJkhAASWSU5sG1waLhEqOslDAvI9AhQ jwFqUW5mSWo8q8YxTkYlYR5lUGm8GTmlcBNfwW0mAlo8Ytt+iCLSxIRUlINjJX7rqsf+9/97/ COOx928LmXmB5esYNtYX9qt+GFHS23ZgZn2izQ3h8ufPRu3NGzTDrNzMZ6bx83HZDbymhnu+h 2WHr+YjXeJiNu1R2XH0lFuGirGHZZi0k4cNV/Kzze1XpY9d3zo++fym5xCTU4eLvVwenv3yni K/6H3P77kqXXqFJp46615kosxRmJhlrMRcWJAATlkBCBAgAA X-Env-Sender: prvs=3184c523e=Andrew.Cooper3@citrix.com X-Msg-Ref: server-3.tower-21.messagelabs.com!1496322655!68330644!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 9.4.19; banners=-,-,- X-VirusChecked: Checked Received: (qmail 4475 invoked from network); 1 Jun 2017 13:10:56 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-3.tower-21.messagelabs.com with RC4-SHA encrypted SMTP; 1 Jun 2017 13:10:56 -0000 X-IronPort-AV: E=Sophos;i="5.39,279,1493683200"; d="scan'208";a="426186466" From: Andrew Cooper To: Xen-devel Date: Thu, 1 Jun 2017 14:10:50 +0100 Message-ID: <1496322650-4527-1-git-send-email-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.1.4 MIME-Version: 1.0 Cc: Stefano Stabellini , Wei Liu , George Dunlap , Andrew Cooper , Ian Jackson , Tim Deegan , Julien Grall , Paul Durrant , Jan Beulich Subject: [Xen-devel] [PATCH] xen/public: Correct the HYPERVISOR_dm_op() documentation to match reality X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP The number of buffers is ahead of the buffer list in the argument list. Signed-off-by: Andrew Cooper Acked-by: Wei Liu --- CC: George Dunlap CC: Ian Jackson CC: Jan Beulich CC: Konrad Rzeszutek Wilk CC: Stefano Stabellini CC: Tim Deegan CC: Wei Liu CC: Paul Durrant CC: Julien Grall For 4.9. This is only documentation, but important to get correct seeing as dm_op()s are a new feature in 4.9 --- xen/include/public/hvm/dm_op.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/include/public/hvm/dm_op.h b/xen/include/public/hvm/dm_op.h index 20c21b6..2a4c3d9 100644 --- a/xen/include/public/hvm/dm_op.h +++ b/xen/include/public/hvm/dm_op.h @@ -391,17 +391,17 @@ DEFINE_XEN_GUEST_HANDLE(xen_dm_op_buf_t); /* ` enum neg_errnoval * ` HYPERVISOR_dm_op(domid_t domid, - * ` xen_dm_op_buf_t bufs[], - * ` unsigned int nr_bufs) + * ` unsigned int nr_bufs, + * ` xen_dm_op_buf_t bufs[]) * ` * * @domid is the domain the hypercall operates on. + * @nr_bufs is the number of buffers in the @bufs array. * @bufs points to an array of buffers where @bufs[0] contains a struct * xen_dm_op, describing the specific device model operation and its * parameters. * @bufs[1..] may be referenced in the parameters for the purposes of * passing extra information to or from the domain. - * @nr_bufs is the number of buffers in the @bufs array. */ #endif /* __XEN_PUBLIC_HVM_DM_OP_H__ */