From patchwork Mon Jun 26 11:59:02 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Cooper X-Patchwork-Id: 9809163 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 73A2160329 for ; Mon, 26 Jun 2017 12:01:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7799F26E74 for ; Mon, 26 Jun 2017 12:01:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 67B262856B; Mon, 26 Jun 2017 12:01:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E4E5D26E74 for ; Mon, 26 Jun 2017 12:01:34 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dPSfd-00087f-AA; Mon, 26 Jun 2017 11:59:09 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dPSfc-00087Z-07 for xen-devel@lists.xen.org; Mon, 26 Jun 2017 11:59:08 +0000 Received: from [85.158.143.35] by server-10.bemta-6.messagelabs.com id EC/DF-03613-B07F0595; Mon, 26 Jun 2017 11:59:07 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrBLMWRWlGSWpSXmKPExsXitHRDpC7X94B Ig8fvjCyWfFzM4sDocXT3b6YAxijWzLyk/IoE1ox5zWfZC86wVTR+e8vewNjM2sXIySEh4C+x /tFzFhCbTUBfYveLT0wgtoiAusTpjotANRwczAJ+Eoce+IKEhQXsJaYt38sGYrMIqEqs6rgJV s4r4Clx+twUqJFyEueP/2QGsYUE1CSu9V9ih6gRlDg58wnYKmYBCYmDL14wT2DknoUkNQtJag Ej0ypGjeLUorLUIl0jC72kosz0jJLcxMwcXUMDM73c1OLixPTUnMSkYr3k/NxNjMBQYACCHYz n1wYeYpTkYFIS5eV4EhApxJeUn1KZkVicEV9UmpNafIhRhoNDSYI39xtQTrAoNT21Ii0zBxiU MGkJDh4lEd6jD4HSvMUFibnFmekQqVOMuhxNH7Z8YRJiycvPS5US51UCmSEAUpRRmgc3AhYhl xhlpYR5GYGOEuIpSC3KzSxBlX/FKM7BqCTM2w0yhSczrwRu0yugI5iAjmCZB3ZESSJCSqqBcc m/TWcdrf8uXhjkmrP9xqMdm32zap4tDOVJX6rx6Y/k1/zTu21uM/GwLPrtnaz7aOLc5WsSbrJ wTX689m7clyT9mu5jgXvmz3851/GFJvNbsUXuL+XFLRQl/T3Ds+cs5nvrdqj01pVpfXf0dr/9 JC98YU32nuA5zlJrndMi3G8tOrJT+UaSa6ISS3FGoqEWc1FxIgDPgq1riwIAAA== X-Env-Sender: prvs=343a9f7d8=Andrew.Cooper3@citrix.com X-Msg-Ref: server-10.tower-21.messagelabs.com!1498478345!69035773!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 9.4.19; banners=-,-,- X-VirusChecked: Checked Received: (qmail 54606 invoked from network); 26 Jun 2017 11:59:06 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-10.tower-21.messagelabs.com with RC4-SHA encrypted SMTP; 26 Jun 2017 11:59:06 -0000 X-IronPort-AV: E=Sophos;i="5.39,395,1493683200"; d="scan'208";a="429337385" From: Andrew Cooper To: Xen-devel Date: Mon, 26 Jun 2017 12:59:02 +0100 Message-ID: <1498478342-26517-1-git-send-email-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.1.4 MIME-Version: 1.0 Cc: Andrew Cooper , Jan Beulich Subject: [Xen-devel] [PATCH] x86/mm: Fix infinite loop in get_spage_pages() X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP c/s 2b8eb37 switched int i to being unsigned, but the undo logic on failure relied in i being signed. As i being unsigned in still preforable, adjust the undo logic to work with an unsigned i. Coverity-ID: 1413017 Signed-off-by: Andrew Cooper Reviewed-by: Konrad Rzeszutek Will Reviewed-by: Wei Liu Reviewed-by: Jan Beulich --- CC: Jan Beulich --- xen/arch/x86/mm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index b20f37f..19f672d 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -2687,7 +2687,7 @@ static int get_spage_pages(struct page_info *page, struct domain *d) { if ( !get_page_and_type(page, d, PGT_writable_page) ) { - while ( --i >= 0 ) + while ( i-- > 0 ) put_page_and_type(--page); return 0; }