From patchwork Thu Jul 13 02:03:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Zhang, Xiong Y" X-Patchwork-Id: 9836401 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D75E160393 for ; Wed, 12 Jul 2017 10:01:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CA45B285A6 for ; Wed, 12 Jul 2017 10:01:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BEDFE28608; Wed, 12 Jul 2017 10:01:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=BAYES_00, DATE_IN_FUTURE_12_24, RCVD_IN_DNSWL_MED autolearn=no version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 5AAF72860B for ; Wed, 12 Jul 2017 10:01:25 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dVEQA-0005Uc-QT; Wed, 12 Jul 2017 09:59:02 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dVEQ9-0005UW-41 for xen-devel@lists.xen.org; Wed, 12 Jul 2017 09:59:01 +0000 Received: from [85.158.143.35] by server-10.bemta-6.messagelabs.com id C5/8F-03582-4E2F5695; Wed, 12 Jul 2017 09:59:00 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrLLMWRWlGSWpSXmKPExsVywNykQvfxp9R Ig71vrCyWfFzM4sDocXT3b6YAxijWzLyk/IoE1oyFB/4zFaxnrzg2oZWlgbGLrYuRi0NIYBqj xJOOz0xdjJwcEgK8EkeWzWCFsP0ldk1YwgJR1MIocf77CmaQBJuAtsTav6fYQGwRAWmJa58vM 4LYzALREnfmrmbvYuTgEBYIkni4xxHEZBFQldhz3RKkglfAXeJlzwWo8XISN891Mk9g5F7AyL CKUaM4tagstUjX0EAvqSgzPaMkNzEzB8gz08tNLS5OTE/NSUwq1kvOz93ECPQuAxDsYLy3LOA QoyQHk5Io7/GHqZFCfEn5KZUZicUZ8UWlOanFhxhlODiUJHh3fwTKCRalpqdWpGXmAMMMJi3B waMkwiu3DyjNW1yQmFucmQ6ROsVoyTHj/5ovTBxNH7YAyVcT/n9jEmLJy89LlRLnLQGZJwDSk FGaBzcOFguXGGWlhHkZgQ4U4ilILcrNLEGVf8UozsGoJMz7AGQKT2ZeCdzWV0AHMQEdtCY7Be SgkkSElFQD4+Rl2/fMn5H/gOWWxqsNTCf5mBRsfs2umbbZSE5Hq1XsZ8ysW+0/r9bK2WtVc72 tTfl+V9RV+ecb5ZXsds+6jXMmyygs6/W60Ct93WbrYrP5hW8D5Tm037q5H/qp5fl/zpzSV+UP PqwW/fVBacZxLTbbB78D9ja1LflV/SeGI9Jj6o8Pr2pzLiqxFGckGmoxFxUnAgDrKsvIgAIAA A== X-Env-Sender: xiong.y.zhang@intel.com X-Msg-Ref: server-14.tower-21.messagelabs.com!1499853537!66197288!1 X-Originating-IP: [192.55.52.120] X-SpamReason: No, hits=2.3 required=7.0 tests=DATE_IN_FUTURE_12_24 X-StarScan-Received: X-StarScan-Version: 9.4.25; banners=-,-,- X-VirusChecked: Checked Received: (qmail 10544 invoked from network); 12 Jul 2017 09:58:59 -0000 Received: from mga04.intel.com (HELO mga04.intel.com) (192.55.52.120) by server-14.tower-21.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 12 Jul 2017 09:58:59 -0000 Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jul 2017 02:58:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,349,1496127600"; d="scan'208";a="124182599" Received: from test-optiplex-7040.bj.intel.com ([10.238.154.174]) by orsmga005.jf.intel.com with ESMTP; 12 Jul 2017 02:58:55 -0700 From: Xiong Zhang To: xen-devel@lists.xen.org Date: Thu, 13 Jul 2017 10:03:39 +0800 Message-Id: <1499911419-10410-1-git-send-email-xiong.y.zhang@intel.com> X-Mailer: git-send-email 2.7.4 Cc: Xiong Zhang , ian.jackson@eu.citrix.com, wei.liu2@citrix.com Subject: [Xen-devel] [PATCH] tools/libxl: Fix a segment fault when mmio_hole is set in hvm.cfg X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP When valid mmio_hole is set in hvm.cfg, segment fault happens at accessing localents pointer. Because the size of localents pointer isn't enough to store appended mmio_hole_size parameter. Signed-off-by: Xiong Zhang Acked-by: Wei Liu --- tools/libxl/libxl_create.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c index bffbc45..1158303 100644 --- a/tools/libxl/libxl_create.c +++ b/tools/libxl/libxl_create.c @@ -451,7 +451,7 @@ int libxl__domain_build(libxl__gc *gc, vments[4] = "start_time"; vments[5] = GCSPRINTF("%lu.%02d", start_time.tv_sec,(int)start_time.tv_usec/10000); - localents = libxl__calloc(gc, 9, sizeof(char *)); + localents = libxl__calloc(gc, 11, sizeof(char *)); i = 0; localents[i++] = "platform/acpi"; localents[i++] = libxl__acpi_defbool_val(info) ? "1" : "0";