From patchwork Wed Aug 9 20:51:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "lan,Tianyu" X-Patchwork-Id: 9892687 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3C4A060325 for ; Thu, 10 Aug 2017 03:00:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2B6D228A06 for ; Thu, 10 Aug 2017 03:00:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2001328A39; Thu, 10 Aug 2017 03:00:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAYES_00, DATE_IN_PAST_06_12, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E9B1D28A40 for ; Thu, 10 Aug 2017 03:00:29 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dfdfm-00051n-RL; Thu, 10 Aug 2017 02:58:10 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dfdfl-00051I-3r for xen-devel@lists.xenproject.org; Thu, 10 Aug 2017 02:58:09 +0000 Received: from [85.158.139.211] by server-3.bemta-5.messagelabs.com id 72/46-02033-0CBCB895; Thu, 10 Aug 2017 02:58:08 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpikeJIrShJLcpLzFFi42Jpa+sQ0d13ujv SYFcvs8X3LZOZHBg9Dn+4whLAGMWamZeUX5HAmjFp6gKmgg3sFXvuTWBrYJzN1sXIxSEkMI1R 4n7ff9YuRk4OCQFeiSPLZkDZ/hKv169hhyjqYJQ4cfcDO0iCTUBd4sTiiYwgtoiAlcT2lu2MI EXMAl8YJX5t2gPWLQzUvW/6SxYQm0VAVeJ3x3ZmEJtXwEXi0YQNUBsUJKY8fA8W5xRwlTizdQ nYUCGgmlvbPrJNYORdwMiwilGjOLWoLLVI18hSL6koMz2jJDcxM0fX0MBULze1uDgxPTUnMal YLzk/dxMjMCTqGRgYdzBe3uJ3iFGSg0lJlLejoTtSiC8pP6UyI7E4I76oNCe1+BCjDAeHkgQv /ymgnGBRanpqRVpmDjA4YdISHDxKIry/TgKleYsLEnOLM9MhUqcYjTmaPmz5wsTxasL/b0xCL Hn5ealS4rxpIJMEQEozSvPgBsGi5hKjrJQwLyMDA4MQT0FqUW5mCar8K0ZxDkYlYd5dIFN4Mv NK4Pa9AjqFCeiUCN9OkFNKEhFSUg2MVoZNGg9dy24Isme9uWqYUHXNufaewieHz3Xl3w6pis7 q2PQ4rtH1Vbffik2y6RXnX34Lfqqtk/cjM3a1fPSGbc7njnJuUtM2KTYsmLPIxMc3wIRnmfhP 9ivOEd92Z3lZ7Yw7Nu345psfH3kriTK4tnJ98Iv82ld/wmTelzCBn/2dfPdSNaqUWIozEg21m IuKEwGfh0uZlQIAAA== X-Env-Sender: tianyu.lan@intel.com X-Msg-Ref: server-11.tower-206.messagelabs.com!1502333883!86824073!1 X-Originating-IP: [134.134.136.20] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogMTM0LjEzNC4xMzYuMjAgPT4gMzU1MzU4\n X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 16121 invoked from network); 10 Aug 2017 02:58:05 -0000 Received: from mga02.intel.com (HELO mga02.intel.com) (134.134.136.20) by server-11.tower-206.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 10 Aug 2017 02:58:05 -0000 Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Aug 2017 19:58:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,349,1498546800"; d="scan'208";a="117462840" Received: from sky-ws.sh.intel.com (HELO localhost) ([10.239.48.141]) by orsmga004.jf.intel.com with ESMTP; 09 Aug 2017 19:57:58 -0700 From: Lan Tianyu To: qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Date: Wed, 9 Aug 2017 16:51:20 -0400 Message-Id: <1502311882-11038-2-git-send-email-tianyu.lan@intel.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1502311882-11038-1-git-send-email-tianyu.lan@intel.com> References: <1502311882-11038-1-git-send-email-tianyu.lan@intel.com> Cc: Lan Tianyu , kevin.tian@intel.com, sstabellini@kernel.org, ehabkost@redhat.com, mst@redhat.com, marcel@redhat.com, anthony.perard@citrix.com, pbonzini@redhat.com, Chao Gao , rth@twiddle.net Subject: [Xen-devel] [PATCH V2 1/3] i386/msi: Correct mask of destination ID in MSI address X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Chao Gao According to SDM 10.11.1, only [19:12] bits of MSI address are Destination ID, change the mask to avoid ambiguity for VT-d spec has used the bit 4 to indicate a remappable interrupt request. Signed-off-by: Chao Gao Signed-off-by: Lan Tianyu Reviewed-by: Anthony PERARD Reviewed-by: Peter Xu --- include/hw/i386/apic-msidef.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/i386/apic-msidef.h b/include/hw/i386/apic-msidef.h index 8b4d4cc..420b411 100644 --- a/include/hw/i386/apic-msidef.h +++ b/include/hw/i386/apic-msidef.h @@ -26,6 +26,6 @@ #define MSI_ADDR_DEST_ID_SHIFT 12 #define MSI_ADDR_DEST_IDX_SHIFT 4 -#define MSI_ADDR_DEST_ID_MASK 0x00ffff0 +#define MSI_ADDR_DEST_ID_MASK 0x000ff000 #endif /* HW_APIC_MSIDEF_H */