| Message ID | 1504185374-7581-5-git-send-email-boris.ostrovsky@oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Aug 31, 2017 at 09:16:14AM -0400, Boris Ostrovsky wrote: > There is no need to scrub pages freed during dom0 construction since > once dom0 is ready the heap will be scrubbed by scrub_heap_pages() anyway, > setting scrub_debug at the end. > > Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com> Reviewed-by: Wei Liu <wei.liu2@citrix.com>
diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index 2b8bb95..dbad1e1 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -2248,16 +2248,12 @@ void free_domheap_pages(struct page_info *pg, unsigned int order) spin_unlock_recursive(&d->page_alloc_lock); -#ifndef CONFIG_SCRUB_DEBUG /* * Normally we expect a domain to clear pages before freeing them, * if it cares about the secrecy of their contents. However, after * a domain has died we assume responsibility for erasure. */ - scrub = !!d->is_dying; -#else - scrub = true; -#endif + scrub = d->is_dying || scrub_debug; } else {
There is no need to scrub pages freed during dom0 construction since once dom0 is ready the heap will be scrubbed by scrub_heap_pages() anyway, setting scrub_debug at the end. Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com> --- Changes in v2: * Use '||' instead of '|'. Drop '!!' * Clarified commit message. xen/common/page_alloc.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)