diff mbox

x86/traps: Fix show_page_walk() to avoid printing trailing whitespace

Message ID 1504630494-22335-1-git-send-email-andrew.cooper3@citrix.com (mailing list archive)
State New, archived
Headers show

Commit Message

Andrew Cooper Sept. 5, 2017, 4:54 p.m. UTC
This moves the L2 line to be consistent with the L3 line.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Wei Liu <wei.liu2@citrix.com>
---
 xen/arch/x86/x86_64/traps.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Wei Liu Sept. 5, 2017, 6:02 p.m. UTC | #1
On Tue, Sep 05, 2017 at 05:54:54PM +0100, Andrew Cooper wrote:
> This moves the L2 line to be consistent with the L3 line.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Wei Liu <wei.liu2@citrix.com>
Jan Beulich Sept. 6, 2017, 9:59 a.m. UTC | #2
>>> On 05.09.17 at 20:02, <wei.liu2@citrix.com> wrote:
> On Tue, Sep 05, 2017 at 05:54:54PM +0100, Andrew Cooper wrote:
>> This moves the L2 line to be consistent with the L3 line.
>> 
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> 
> Reviewed-by: Wei Liu <wei.liu2@citrix.com>

Acked-by: Jan Beulich <jbeulich@suse.com>
diff mbox

Patch

diff --git a/xen/arch/x86/x86_64/traps.c b/xen/arch/x86/x86_64/traps.c
index 41ec78f..f811c68 100644
--- a/xen/arch/x86/x86_64/traps.c
+++ b/xen/arch/x86/x86_64/traps.c
@@ -206,9 +206,9 @@  void show_page_walk(unsigned long addr)
     mfn = l2e_get_pfn(l2e);
     pfn = mfn_valid(_mfn(mfn)) && machine_to_phys_mapping_valid ?
           get_gpfn_from_mfn(mfn) : INVALID_M2P_ENTRY;
-    printk(" L2[0x%03lx] = %"PRIpte" %016lx %s\n",
+    printk(" L2[0x%03lx] = %"PRIpte" %016lx%s\n",
            l2_table_offset(addr), l2e_get_intpte(l2e), pfn,
-           (l2e_get_flags(l2e) & _PAGE_PSE) ? "(PSE)" : "");
+           (l2e_get_flags(l2e) & _PAGE_PSE) ? " (PSE)" : "");
     if ( !(l2e_get_flags(l2e) & _PAGE_PRESENT) ||
          (l2e_get_flags(l2e) & _PAGE_PSE) ||
          !mfn_valid(_mfn(mfn)) )