From patchwork Wed Sep 13 04:52:49 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "lan,Tianyu" X-Patchwork-Id: 9951057 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 26B9660360 for ; Wed, 13 Sep 2017 11:02:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1615628655 for ; Wed, 13 Sep 2017 11:02:09 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0A55728DE0; Wed, 13 Sep 2017 11:02:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAYES_00, DATE_IN_PAST_06_12, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 7434128655 for ; Wed, 13 Sep 2017 11:02:08 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ds5Om-0003pg-Pr; Wed, 13 Sep 2017 11:00:04 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ds5Om-0003f1-3r for xen-devel@lists.xen.org; Wed, 13 Sep 2017 11:00:04 +0000 Received: from [85.158.139.211] by server-3.bemta-5.messagelabs.com id B9/0C-30688-3BF09B95; Wed, 13 Sep 2017 11:00:03 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrFLMWRWlGSWpSXmKPExsXS1taRoruJf2e kwaIjRhZLPi5mcWD0OLr7N1MAYxRrZl5SfkUCa8aKNR/ZCr6pVRxecY69gfGhTBcjJ4eQQKXE jaOX2UBsCQFeiSPLZrBC2P4S7dP2MnYxcgHVdDBK7PlzjB0kwSagLnFi8URGEFtEQFri2ufLY EXMAusYJRra/rKAJISBug/9fAFkc3CwCKhKvPwQDBLmFXCROHTwJdQyBYkpD98zg9icAq4SHW /esEAc5CLxbepDpgmMvAsYGVYxahSnFpWlFukaG+glFWWmZ5TkJmbm6BoamOrlphYXJ6an5iQ mFesl5+duYgSGQz0DA+MOxgmr/A4xSnIwKYny7t+zI1KILyk/pTIjsTgjvqg0J7X4EKMMB4eS BO9kvp2RQoJFqempFWmZOcDAhElLcPAoifAuA0nzFhck5hZnpkOkTjHqcnTcvPuHSYglLz8vV Uqcdw1IkQBIUUZpHtwIWJRcYpSVEuZlZGBgEOIpSC3KzSxBlX/FKM7BqCTMuxRkCk9mXgncpl dARzABHXHm9A6QI0oSEVJSDYybVkbmFyrcFv0w0yI6Q3TqJJ6DJotOny9nmiSyYLlG0pFI941 /002m/Lr7dOrNaEeVM1xroxqXlvGzZTR/5IpJu6qcmTVTvvbF4pDaW19O3S9etM59qUz9lEuC C2exX727Mna20Zm0WYFxKVePNib/j2xn1r14TWn99lfGVz/U8X9ZxqTELs+gxFKckWioxVxUn AgAufyCdo0CAAA= X-Env-Sender: tianyu.lan@intel.com X-Msg-Ref: server-6.tower-206.messagelabs.com!1505300394!108491835!2 X-Originating-IP: [134.134.136.100] X-SpamReason: No, hits=0.8 required=7.0 tests=DATE_IN_PAST_06_12 X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 41442 invoked from network); 13 Sep 2017 11:00:02 -0000 Received: from mga07.intel.com (HELO mga07.intel.com) (134.134.136.100) by server-6.tower-206.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 13 Sep 2017 11:00:02 -0000 Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP; 13 Sep 2017 04:00:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,387,1500966000"; d="scan'208";a="899818115" Received: from sky-ws.sh.intel.com (HELO localhost) ([10.239.48.141]) by FMSMGA003.fm.intel.com with ESMTP; 13 Sep 2017 03:59:59 -0700 From: Lan Tianyu To: xen-devel@lists.xen.org Date: Wed, 13 Sep 2017 00:52:49 -0400 Message-Id: <1505278369-21605-4-git-send-email-tianyu.lan@intel.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1505278369-21605-1-git-send-email-tianyu.lan@intel.com> References: <1505278369-21605-1-git-send-email-tianyu.lan@intel.com> Cc: Lan Tianyu , kevin.tian@intel.com, wei.liu2@citrix.com, ian.jackson@eu.citrix.com, jbeulich@suse.com, roger.pau@citrix.com, chao.gao@intel.com Subject: [Xen-devel] [RFC PATCH V3 3/3] hvmload: Add x2apic entry support in the MADT build X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP This patch is to add x2apic entry support for ACPI MADT table according to ACPI spec 5.2.12.12 Processor Local x2APIC Structure. Signed-off-by: Chao Gao Signed-off-by: Lan Tianyu --- tools/libacpi/acpi2_0.h | 10 +++++++++ tools/libacpi/build.c | 56 ++++++++++++++++++++++++++++++++++++------------- 2 files changed, 51 insertions(+), 15 deletions(-) diff --git a/tools/libacpi/acpi2_0.h b/tools/libacpi/acpi2_0.h index 2619ba3..ada5131 100644 --- a/tools/libacpi/acpi2_0.h +++ b/tools/libacpi/acpi2_0.h @@ -322,6 +322,7 @@ struct acpi_20_waet { #define ACPI_IO_SAPIC 0x06 #define ACPI_PROCESSOR_LOCAL_SAPIC 0x07 #define ACPI_PLATFORM_INTERRUPT_SOURCES 0x08 +#define ACPI_PROCESSOR_LOCAL_X2APIC 0x09 /* * APIC Structure Definitions. @@ -338,6 +339,15 @@ struct acpi_20_madt_lapic { uint32_t flags; }; +struct acpi_20_madt_x2apic { + uint8_t type; + uint8_t length; + uint16_t reserved; /* reserved - must be zero */ + uint32_t apic_id; /* Processor x2APIC ID */ + uint32_t flags; + uint32_t acpi_processor_id; /* ACPI processor UID */ +}; + /* * Local APIC Flags. All other bits are reserved and must be 0. */ diff --git a/tools/libacpi/build.c b/tools/libacpi/build.c index f9881c9..4830339 100644 --- a/tools/libacpi/build.c +++ b/tools/libacpi/build.c @@ -78,9 +78,9 @@ static struct acpi_20_madt *construct_madt(struct acpi_ctxt *ctxt, struct acpi_20_madt *madt; struct acpi_20_madt_intsrcovr *intsrcovr; struct acpi_20_madt_ioapic *io_apic; - struct acpi_20_madt_lapic *lapic; const struct hvm_info_table *hvminfo = config->hvminfo; int i, sz; + void *end; if ( config->lapic_id == NULL ) return NULL; @@ -88,7 +88,14 @@ static struct acpi_20_madt *construct_madt(struct acpi_ctxt *ctxt, sz = sizeof(struct acpi_20_madt); sz += sizeof(struct acpi_20_madt_intsrcovr) * 16; sz += sizeof(struct acpi_20_madt_ioapic); - sz += sizeof(struct acpi_20_madt_lapic) * hvminfo->nr_vcpus; + + for ( i = 0; i < hvminfo->nr_vcpus; i++ ) + { + if ( config->lapic_id(i) > 254) + sz += sizeof(struct acpi_20_madt_x2apic); + else + sz += sizeof(struct acpi_20_madt_lapic); + } madt = ctxt->mem_ops.alloc(ctxt, sz, 16); if (!madt) return NULL; @@ -142,27 +149,46 @@ static struct acpi_20_madt *construct_madt(struct acpi_ctxt *ctxt, io_apic->ioapic_id = config->ioapic_id; io_apic->ioapic_addr = config->ioapic_base_address; - lapic = (struct acpi_20_madt_lapic *)(io_apic + 1); + end = (struct acpi_20_madt_lapic *)(io_apic + 1); } else - lapic = (struct acpi_20_madt_lapic *)(madt + 1); + end = (struct acpi_20_madt_lapic *)(madt + 1); info->nr_cpus = hvminfo->nr_vcpus; - info->madt_lapic0_addr = ctxt->mem_ops.v2p(ctxt, lapic); + info->madt_lapic0_addr = ctxt->mem_ops.v2p(ctxt, end); + for ( i = 0; i < hvminfo->nr_vcpus; i++ ) { - memset(lapic, 0, sizeof(*lapic)); - lapic->type = ACPI_PROCESSOR_LOCAL_APIC; - lapic->length = sizeof(*lapic); - /* Processor ID must match processor-object IDs in the DSDT. */ - lapic->acpi_processor_id = i; - lapic->apic_id = config->lapic_id(i); - lapic->flags = (test_bit(i, hvminfo->vcpu_online) - ? ACPI_LOCAL_APIC_ENABLED : 0); - lapic++; + unsigned int apic_id = config->lapic_id(i); + + if ( apic_id < 255 ) { + struct acpi_20_madt_lapic *lapic = end; + + memset(lapic, 0, sizeof(*lapic)); + lapic->type = ACPI_PROCESSOR_LOCAL_APIC; + lapic->length = sizeof(*lapic); + /* Processor ID must match processor-object IDs in the DSDT. */ + lapic->acpi_processor_id = i; + lapic->apic_id = apic_id; + lapic->flags = test_bit(i, hvminfo->vcpu_online) + ? ACPI_LOCAL_APIC_ENABLED : 0; + end = ++lapic; + } else { + struct acpi_20_madt_x2apic *lapic = end; + + memset(lapic, 0, sizeof(*lapic)); + lapic->type = ACPI_PROCESSOR_LOCAL_X2APIC; + lapic->length = sizeof(*lapic); + /* Processor ID must match processor-object IDs in the DSDT. */ + lapic->acpi_processor_id = i; + lapic->apic_id = apic_id; + lapic->flags = test_bit(i, hvminfo->vcpu_online) + ? ACPI_LOCAL_APIC_ENABLED : 0; + end = ++lapic; + } } - madt->header.length = (unsigned char *)lapic - (unsigned char *)madt; + madt->header.length = (unsigned char *)end - (unsigned char *)madt; set_checksum(madt, offsetof(struct acpi_header, checksum), madt->header.length); info->madt_csum_addr =