From patchwork Wed Oct 4 15:57:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Jackson X-Patchwork-Id: 9985113 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id CFE7E60586 for ; Wed, 4 Oct 2017 16:09:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C2A66286DC for ; Wed, 4 Oct 2017 16:09:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B7581286B1; Wed, 4 Oct 2017 16:09:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 390CC286DC for ; Wed, 4 Oct 2017 16:09:30 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzmD0-0003ep-3g; Wed, 04 Oct 2017 16:07:42 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzmCy-0003dw-G8 for xen-devel@lists.xensource.com; Wed, 04 Oct 2017 16:07:40 +0000 Received: from [85.158.139.211] by server-11.bemta-5.messagelabs.com id 08/45-01778-B4705D95; Wed, 04 Oct 2017 16:07:39 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrGIsWRWlGSWpSXmKPExsXitHSDva43+9V Ig3k3xC3uTXnP7sDosb1vF3sAYxRrZl5SfkUCa0b7t8nMBfskK37dmcvYwHhIpIuRk0NCwF9i 1sH3LBC2h8T1syeYQGw2AV2Jpi1/2UBsEQFlieNNX1hBbGaBKcwSkzf7gdjCAjYSU95PAOtlE VCRuDj/OFgvr4CnROuqk4wQM+Ukzh//yQxicwp4STzd2QFkc3AIAdUcW2sKYapJzF0fD9EpKH Fy5hMWiE0SEgdfvGCGmGIp8W39U+YJjPyzkJTNQlK2gJFpFaN6cWpRWWqRrpFeUlFmekZJbmJ mjq6hgalebmpxcWJ6ak5iUrFecn7uJkZgmDEAwQ7G73+cDjFKcjApifL++nklUogvKT+lMiOx OCO+qDQntfgQowwHh5IEry3b1UghwaLU9NSKtMwcYMDDpCU4eJREeK+wAqV5iwsSc4sz0yFSp xh1OTpu3v3DJMSSl5+XKiXOOwFkhgBIUUZpHtwIWPRdYpSVEuZlBDpKiKcgtSg3swRV/hWjOA ejkjBvFMgUnsy8ErhNr4COYAI6Yk7TFZAjShIRUlINjJvdrBdsippTLfDnpyjDpBu2MV48y8Q fCUz5XqzcK2suV7V78qx7AasuHY37pnAh58fLv63yM08H/m3O8s44Emfu6v68OYFV6Lg/i++G dqOOGx+j2m0Y/W00q+/1/FAMTmgu9i9ye+XiEbpnlvLW+TOKvhb5HshjW11imCsu1ry7+terO de/KLEUZyQaajEXFScCADXZkRS5AgAA X-Env-Sender: prvs=4438c69fc=Ian.Jackson@citrix.com X-Msg-Ref: server-3.tower-206.messagelabs.com!1507133256!110999150!2 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 17341 invoked from network); 4 Oct 2017 16:07:39 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-3.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 4 Oct 2017 16:07:39 -0000 X-IronPort-AV: E=Sophos;i="5.42,477,1500940800"; d="scan'208";a="450475300" X-CrossPremisesHeadersFilteredBySendConnector: FTLPEX02AMS01.citrite.net From: Ian Jackson To: Date: Wed, 4 Oct 2017 16:57:07 +0100 Message-ID: <1507132650-25376-2-git-send-email-ian.jackson@eu.citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1507132650-25376-1-git-send-email-ian.jackson@eu.citrix.com> References: <1507132650-25376-1-git-send-email-ian.jackson@eu.citrix.com> MIME-Version: 1.0 X-OrganizationHeadersPreserved: FTLPEX02AMS01.citrite.net Cc: Stefano Stabellini , Wei Liu , Konrad Rzeszutek Wilk , George Dunlap , Andrew Cooper , Ian Jackson , Tim Deegan , Ross Lagerwall , Jan Beulich Subject: [Xen-devel] [PATCH 01/24] xen: Provide XEN_DMOP_remote_shutdown X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP SCHEDOP_remote_shutdown should be a DMOP so that a deprivileged qemu can do the propery tidying up. We need to keep SCHEDOP_remote_shutdown for ABI stability reasons and because it is needed for PV guests. CC: Jan Beulich CC: Andrew Cooper CC: George Dunlap CC: Konrad Rzeszutek Wilk CC: Stefano Stabellini CC: Tim Deegan CC: Wei Liu Reviewed-by: Jan Beulich Reviewed-by: Wei Liu Signed-off-by: Ian Jackson --- v2: Coding style: add blank line in switch statement. Correct commit message re reasons to keep SCHEDOP_remote_shutdown. Add to xlat.lst in alphabetical order wrt to other dm_ops. Signed-off-by: Ian Jackson --- xen/arch/x86/hvm/dm.c | 10 ++++++++++ xen/include/public/hvm/dm_op.h | 12 ++++++++++++ xen/include/xlat.lst | 1 + 3 files changed, 23 insertions(+) diff --git a/xen/arch/x86/hvm/dm.c b/xen/arch/x86/hvm/dm.c index 9cf53b5..acabde1 100644 --- a/xen/arch/x86/hvm/dm.c +++ b/xen/arch/x86/hvm/dm.c @@ -629,6 +629,15 @@ static int dm_op(const struct dmop_args *op_args) break; } + case XEN_DMOP_remote_shutdown: + { + const struct xen_dm_op_remote_shutdown *data = + &op.u.remote_shutdown; + + domain_shutdown(d, data->reason); + break; + } + default: rc = -EOPNOTSUPP; break; @@ -657,6 +666,7 @@ CHECK_dm_op_modified_memory; CHECK_dm_op_set_mem_type; CHECK_dm_op_inject_event; CHECK_dm_op_inject_msi; +CHECK_dm_op_remote_shutdown; int compat_dm_op(domid_t domid, unsigned int nr_bufs, diff --git a/xen/include/public/hvm/dm_op.h b/xen/include/public/hvm/dm_op.h index 6bbab5f..e173085 100644 --- a/xen/include/public/hvm/dm_op.h +++ b/xen/include/public/hvm/dm_op.h @@ -357,6 +357,17 @@ struct xen_dm_op_map_mem_type_to_ioreq_server { has to be set to zero by the caller */ }; +/* + * XEN_DMOP_remote_shutdown : Declare a shutdown for another domain + * Identical to SCHEDOP_remote_shutdown + */ +#define XEN_DMOP_remote_shutdown 16 + +struct xen_dm_op_remote_shutdown { + uint32_t reason; /* SHUTDOWN_* => enum sched_shutdown_reason */ + /* (Other reason values are not blocked) */ +}; + struct xen_dm_op { uint32_t op; uint32_t pad; @@ -377,6 +388,7 @@ struct xen_dm_op { struct xen_dm_op_inject_msi inject_msi; struct xen_dm_op_map_mem_type_to_ioreq_server map_mem_type_to_ioreq_server; + struct xen_dm_op_remote_shutdown remote_shutdown; } u; }; diff --git a/xen/include/xlat.lst b/xen/include/xlat.lst index 0f17000..4346cbe 100644 --- a/xen/include/xlat.lst +++ b/xen/include/xlat.lst @@ -64,6 +64,7 @@ ? dm_op_inject_msi hvm/dm_op.h ? dm_op_ioreq_server_range hvm/dm_op.h ? dm_op_modified_memory hvm/dm_op.h +? dm_op_remote_shutdown hvm/dm_op.h ? dm_op_set_ioreq_server_state hvm/dm_op.h ? dm_op_set_isa_irq_level hvm/dm_op.h ? dm_op_set_mem_type hvm/dm_op.h