| Message ID | 1507677465-3840-5-git-send-email-mengxu@cis.upenn.edu (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, 2017-10-10 at 19:17 -0400, Meng Xu wrote: > --- a/tools/xentrace/formats > +++ b/tools/xentrace/formats > @@ -75,7 +75,7 @@ > 0x00022801 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtds:tickle [ > cpu = %(1)d ] > 0x00022802 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtds:runq_pick [ > dom:vcpu = 0x%(1)08x, cur_deadline = 0x%(3)08x%(2)08x, cur_budget = > 0x%(5)08x%(4)08x ] > 0x00022803 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtds:burn_budget [ > dom:vcpu = 0x%(1)08x, cur_budget = 0x%(3)08x%(2)08x, delta = %(4)d ] > -0x00022804 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtds:repl_budget [ > dom:vcpu = 0x%(1)08x, cur_deadline = 0x%(3)08x%(2)08x, cur_budget = > 0x%(5)08x%(4)08x ] > +0x00022804 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtds:repl_budget [ > dom:vcpu = 0x%(1)08x, priority_level = 0x%(2)08d cur_deadline = > 0x%(4)08x%(3)08x, cur_budget = 0x%(6)08x%(5)08x ] > 0x00022805 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtds:sched_tasklet > 0x00022806 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtds:schedule [ > cpu[16]:tasklet[8]:idle[4]:tickled[4] = %(1)08x ] > But, both in case of this file and below in xenalyze.c, you update 1 record (the one of REPL_BUDGET). However, in patch 1, you added the priority_level field to two records: REPL_BUDGET and BURN_BUDGET. Or am I missing something? Regards, Dario > diff --git a/tools/xentrace/xenalyze.c b/tools/xentrace/xenalyze.c > index 79bdba7..2783204 100644 > --- a/tools/xentrace/xenalyze.c > +++ b/tools/xentrace/xenalyze.c > @@ -7946,12 +7946,14 @@ void sched_process(struct pcpu_info *p) > if(opt.dump_all) { > struct { > unsigned int vcpuid:16, domid:16; > + unsigned int priority_level; > uint64_t cur_dl, cur_bg; > } __attribute__((packed)) *r = (typeof(r))ri->d; > > - printf(" %s rtds:repl_budget d%uv%u, deadline = > %"PRIu64", " > - "budget = %"PRIu64"\n", ri->dump_header, > - r->domid, r->vcpuid, r->cur_dl, r->cur_bg); > + printf(" %s rtds:repl_budget d%uv%u, priority_level > = %u," > + "deadline = %"PRIu64", budget = %"PRIu64"\n", > + ri->dump_header, r->domid, r->vcpuid, > + r->priority_level, r->cur_dl, r->cur_bg); > } > break; > case TRC_SCHED_CLASS_EVT(RTDS, 5): /* SCHED_TASKLET */
On Wed, Oct 11, 2017 at 6:57 AM, Dario Faggioli <raistlin@linux.it> wrote: > On Tue, 2017-10-10 at 19:17 -0400, Meng Xu wrote: >> --- a/tools/xentrace/formats >> +++ b/tools/xentrace/formats >> @@ -75,7 +75,7 @@ >> 0x00022801 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtds:tickle [ >> cpu = %(1)d ] >> 0x00022802 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtds:runq_pick [ >> dom:vcpu = 0x%(1)08x, cur_deadline = 0x%(3)08x%(2)08x, cur_budget = >> 0x%(5)08x%(4)08x ] >> 0x00022803 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtds:burn_budget [ >> dom:vcpu = 0x%(1)08x, cur_budget = 0x%(3)08x%(2)08x, delta = %(4)d ] >> -0x00022804 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtds:repl_budget [ >> dom:vcpu = 0x%(1)08x, cur_deadline = 0x%(3)08x%(2)08x, cur_budget = >> 0x%(5)08x%(4)08x ] >> +0x00022804 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtds:repl_budget [ >> dom:vcpu = 0x%(1)08x, priority_level = 0x%(2)08d cur_deadline = >> 0x%(4)08x%(3)08x, cur_budget = 0x%(6)08x%(5)08x ] >> 0x00022805 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtds:sched_tasklet >> 0x00022806 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtds:schedule [ >> cpu[16]:tasklet[8]:idle[4]:tickled[4] = %(1)08x ] >> > But, both in case of this file and below in xenalyze.c, you update 1 > record (the one of REPL_BUDGET). However, in patch 1, you added the > priority_level field to two records: REPL_BUDGET and BURN_BUDGET. > > Or am I missing something? OMG, my fault. I forgot to check this. I will add this and double check it by running some tests. Best, Meng
diff --git a/tools/xentrace/formats b/tools/xentrace/formats index d6e7e3f..7d3a209 100644 --- a/tools/xentrace/formats +++ b/tools/xentrace/formats @@ -75,7 +75,7 @@ 0x00022801 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtds:tickle [ cpu = %(1)d ] 0x00022802 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtds:runq_pick [ dom:vcpu = 0x%(1)08x, cur_deadline = 0x%(3)08x%(2)08x, cur_budget = 0x%(5)08x%(4)08x ] 0x00022803 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtds:burn_budget [ dom:vcpu = 0x%(1)08x, cur_budget = 0x%(3)08x%(2)08x, delta = %(4)d ] -0x00022804 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtds:repl_budget [ dom:vcpu = 0x%(1)08x, cur_deadline = 0x%(3)08x%(2)08x, cur_budget = 0x%(5)08x%(4)08x ] +0x00022804 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtds:repl_budget [ dom:vcpu = 0x%(1)08x, priority_level = 0x%(2)08d cur_deadline = 0x%(4)08x%(3)08x, cur_budget = 0x%(6)08x%(5)08x ] 0x00022805 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtds:sched_tasklet 0x00022806 CPU%(cpu)d %(tsc)d (+%(reltsc)8d) rtds:schedule [ cpu[16]:tasklet[8]:idle[4]:tickled[4] = %(1)08x ] diff --git a/tools/xentrace/xenalyze.c b/tools/xentrace/xenalyze.c index 79bdba7..2783204 100644 --- a/tools/xentrace/xenalyze.c +++ b/tools/xentrace/xenalyze.c @@ -7946,12 +7946,14 @@ void sched_process(struct pcpu_info *p) if(opt.dump_all) { struct { unsigned int vcpuid:16, domid:16; + unsigned int priority_level; uint64_t cur_dl, cur_bg; } __attribute__((packed)) *r = (typeof(r))ri->d; - printf(" %s rtds:repl_budget d%uv%u, deadline = %"PRIu64", " - "budget = %"PRIu64"\n", ri->dump_header, - r->domid, r->vcpuid, r->cur_dl, r->cur_bg); + printf(" %s rtds:repl_budget d%uv%u, priority_level = %u," + "deadline = %"PRIu64", budget = %"PRIu64"\n", + ri->dump_header, r->domid, r->vcpuid, + r->priority_level, r->cur_dl, r->cur_bg); } break; case TRC_SCHED_CLASS_EVT(RTDS, 5): /* SCHED_TASKLET */
Change repl_budget event output for xentrace formats and xenalyze Signed-off-by: Meng Xu <mengxu@cis.upenn.edu> --- No changes from v2 Changes from v1 Add this changes from v1 --- tools/xentrace/formats | 2 +- tools/xentrace/xenalyze.c | 8 +++++--- 2 files changed, 6 insertions(+), 4 deletions(-)