From patchwork Wed Oct 11 13:07:29 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Semel X-Patchwork-Id: 9999605 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id CCB416037F for ; Wed, 11 Oct 2017 13:11:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BDEBA289F7 for ; Wed, 11 Oct 2017 13:11:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B2E6828A2D; Wed, 11 Oct 2017 13:11:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=2.0 tests=BAYES_00,DKIM_ADSP_ALL, DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 3786528A1C for ; Wed, 11 Oct 2017 13:11:45 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e2Gl3-0006PH-3n; Wed, 11 Oct 2017 13:09:09 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e2Gl2-0006PB-1s for xen-devel@lists.xenproject.org; Wed, 11 Oct 2017 13:09:08 +0000 Received: from [85.158.139.211] by server-5.bemta-5.messagelabs.com id C8/E0-01544-3F71ED95; Wed, 11 Oct 2017 13:09:07 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrNIsWRWlGSWpSXmKPExsVyfvUOWd1P4vc iDU5sNbH4vmUykwOjx+EPV1gCGKNYM/OS8isSWDMm77zLWnCZtWL5kbMsDYxXWLoYuThYBDYz SzQ0LmbtYuTkkBDwl9i1dh4bSEJI4DWjxKnrXYwQziomictLZrBDOHsZJVY/a2KBcPYxSvw+N xWq7BajxJV5rcxdjBwcbAKqEif22oKYIgIqErf3GoCsYBaIlfjw5iATiC0sYCXx781TFhCbBa j607pJYGfwCjhJbN3bDHWSgsSUh++ZIeKCEidnPmGBmCMhcfDFC7C4gICAxIZXD9gnMArOQlI 2C0nZAkamVYwaxalFZalFuoYmeklFmekZJbmJmTm6hgamermpxcWJ6ak5iUnFesn5uZsYgUHK AAQ7GM+e9jzEKMnBpCTKe/353UghvqT8lMqMxOKM+KLSnNTiQ4wyHBxKErwPxO5FCgkWpaanV qRl5gDjBSYtwcGjJMIrDowZId7igsTc4sx0iNQpRmOOGw+v/2Hi6Lh59w+TEEtefl6qlDjvY5 BJAiClGaV5cINgcXyJUVZKmJcR6DQhnoLUotzMElT5V4ziHIxKwrzfQKbwZOaVwO17BXQKE9A poml3QE4pSURISTUwTsz+euxFicq0iLyOgKcG1rb7OOTEDdeXLPzYrb7P/PZpP7Ozzm8Y4nze eJ4O5fc7veDUsu1nPpp1LpqUUL50BcsXR1FN/7wdZXkrZT7s9mUw/t67lys3zcXw/zYlozUJX 7lmtttNPxT/K1xMt7PQ311RjkH6m3PKnfcLsph/RMqesvn3gm+BEktxRqKhFnNRcSIAT5ylB9 4CAAA= X-Env-Sender: prvs=450f2e0eb=phentex@amazon.com X-Msg-Ref: server-4.tower-206.messagelabs.com!1507727345!106469049!1 X-Originating-IP: [207.171.184.29] X-SpamReason: No, hits=0.0 required=7.0 tests=FROM_AMAZON X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 43368 invoked from network); 11 Oct 2017 13:09:06 -0000 Received: from smtp-fw-9102.amazon.com (HELO smtp-fw-9102.amazon.com) (207.171.184.29) by server-4.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 11 Oct 2017 13:09:06 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1507727346; x=1539263346; h=from:to:cc:subject:date:message-id:mime-version; bh=zzP3LuxDzuL7Ms7lrxgQ0UDgEB/Dbh3oUnSDGgdPfG0=; b=EiYi3QtFZJ6oDKoHUl1ssNR1q94qsYEoPwWa8hUx2O+lw+K+FpQZgJSs YWgnNrKNXfsL+2EWModlmTrqhJFh440BUl+p4kmFvDdW72T2n++XDW7Do Hl9vYSON7iJklfYWq+H4oaPGp+YmAOUG7njQXP//1Mq4p4islisG+zMBP g=; X-IronPort-AV: E=Sophos;i="5.43,361,1503360000"; d="scan'208";a="567335622" Received: from sea3-co-svc-lb6-vlan3.sea.amazon.com (HELO email-inbound-relay-2a-f14f4a47.us-west-2.amazon.com) ([10.47.22.38]) by smtp-border-fw-out-9102.sea19.amazon.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 11 Oct 2017 13:08:27 +0000 Received: from EX13MTAUEA001.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan3.pdx.amazon.com [10.236.137.198]) by email-inbound-relay-2a-f14f4a47.us-west-2.amazon.com (8.14.7/8.14.7) with ESMTP id v9BD85HM078248 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Wed, 11 Oct 2017 13:08:08 GMT Received: from EX13D05EUB003.ant.amazon.com (10.43.166.253) by EX13MTAUEA001.ant.amazon.com (10.43.61.243) with Microsoft SMTP Server (TLS) id 15.0.1236.3; Wed, 11 Oct 2017 13:08:07 +0000 Received: from EX13MTAUWB001.ant.amazon.com (10.43.161.207) by EX13D05EUB003.ant.amazon.com (10.43.166.253) with Microsoft SMTP Server (TLS) id 15.0.1236.3; Wed, 11 Oct 2017 13:08:06 +0000 Received: from dev-dsk-wipawel-1a-0c4e6d58.eu-west-1.amazon.com (10.4.134.33) by mail-relay.amazon.com (10.43.161.249) with Microsoft SMTP Server id 15.0.1236.3 via Frontend Transport; Wed, 11 Oct 2017 13:08:04 +0000 From: Paul Semel To: Date: Wed, 11 Oct 2017 13:07:29 +0000 Message-ID: <1507727249-93295-1-git-send-email-phentex@amazon.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Precedence: Bulk Cc: andrew.cooper3@citrix.com, Paul Semel , wipawel@amazon.de Subject: [Xen-devel] [PATCH xtf] libc: Fix strcpy() assignment mistake X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Paul Semel the strcpy function was doing a comparison instead of doing an assignment. Signed-off-by: Paul Semel Reviewed-by: Pawel Wieczorkiewicz Reviewed-by: Bjoern Doebel Reviewed-by: Martin Pohlack --- common/libc/string.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/libc/string.c b/common/libc/string.c index 94acc7e..967f2fa 100644 --- a/common/libc/string.c +++ b/common/libc/string.c @@ -24,7 +24,7 @@ size_t strnlen(const char *str, size_t max) { char *p = dst; - while ( *p++ == *src++ ) + while ( (*p++ = *src++) ) ; return dst;