From patchwork Thu Oct 26 17:03:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Euan Harris X-Patchwork-Id: 10028645 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id AA8DC60567 for ; Thu, 26 Oct 2017 17:06:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 95CD928E75 for ; Thu, 26 Oct 2017 17:06:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8A7AD28E82; Thu, 26 Oct 2017 17:06:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E9A8328E77 for ; Thu, 26 Oct 2017 17:06:16 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e7lZR-0002dA-UG; Thu, 26 Oct 2017 17:03:53 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e7lZR-0002d3-3r for xen-devel@lists.xenproject.org; Thu, 26 Oct 2017 17:03:53 +0000 Received: from [85.158.139.211] by server-12.bemta-5.messagelabs.com id 33/B6-19514-87512F95; Thu, 26 Oct 2017 17:03:52 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprOIsWRWlGSWpSXmKPExsXitHSDvW656Kd IgzlnLSy+b5nM5MDocfjDFZYAxijWzLyk/IoE1owJ346wFXRxVXzY/YaxgbGbo4uRk0NCwF/i 1LrrTCA2m4CWxO4PC9m7GDk4RARUJG7vNehi5OJgFuhllFj6/gJYjbCAs8SUJw2MIDaLgKpEx 6xnYDavgJvE297DTBAzFSSmPHzPDGJzCrhLHFq4iQ3EFgKqufjtFyuErSzx4coadoheQYmTM5 +wgNjMAhISB1+8YJ7AyDsLSWoWktQCRqZVjBrFqUVlqUW6RkZ6SUWZ6RkluYmZObqGBqZ6uan FxYnpqTmJScV6yfm5mxiBwVPPwMC4g3FPu98hRkkOJiVRXoY9HyKF+JLyUyozEosz4otKc1KL DzHKcHAoSfAuFP4UKSRYlJqeWpGWmQMMY5i0BAePkgjvJZA0b3FBYm5xZjpE6hSjMUfHzbt/m DiezXzdwCzEkpeflyolzmsqAlQqAFKaUZoHNwgWX5cYZaWEeRkZGBiEeApSi3IzS1DlXzGKcz AqCUMs5MnMK4Hb9wroFCagU5pUP4CcUpKIkJJqYNzccKIv5/DFrslWbw9e+tecdG/vt6D5VVz lM6pvHeXZ6Pz75wJFEf7y+z3x+1m0Np/brsKcm+LZtteA41r8nV7xJSvMIw42aZgeWriiWvtl zI2/ZdoFs2//zHGadL1XL+Rv7t3rU9LPFjJmpixMkZ7KYHnnzWa1D+s53v6WuT31F4eEAav/z CNKLMUZiYZazEXFiQAIbwDIqgIAAA== X-Env-Sender: prvs=465eced58=euan.harris@citrix.com X-Msg-Ref: server-7.tower-206.messagelabs.com!1509037429!105948291!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 40950 invoked from network); 26 Oct 2017 17:03:51 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-7.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 26 Oct 2017 17:03:51 -0000 X-IronPort-AV: E=Sophos;i="5.44,301,1505779200"; d="scan'208";a="456259605" From: Euan Harris To: Date: Thu, 26 Oct 2017 18:03:14 +0100 Message-ID: <1509037399-48926-5-git-send-email-euan.harris@citrix.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1509037399-48926-1-git-send-email-euan.harris@citrix.com> References: <1509037399-48926-1-git-send-email-euan.harris@citrix.com> MIME-Version: 1.0 Cc: andrew.cooper3@citrix.com, kevin.tian@intel.com, Euan Harris , jun.nakajima@intel.com, jbeulich@suse.com Subject: [Xen-devel] [PATCH 4/9] x86/vvmx: Remove unnecessary VMX operand reads X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP * vpid is never used in nvmx_handle_invept() so there is no point in reading it. * vmptrst's operand is the memory address to which to write the VMCS pointer. gpa is the pointer to write. Reading the address into gpa is meaningless. Signed-off-by: Euan Harris --- xen/arch/x86/hvm/vmx/vvmx.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/hvm/vmx/vvmx.c b/xen/arch/x86/hvm/vmx/vvmx.c index df84592490..32c07eca3d 100644 --- a/xen/arch/x86/hvm/vmx/vvmx.c +++ b/xen/arch/x86/hvm/vmx/vvmx.c @@ -1801,7 +1801,7 @@ int nvmx_handle_vmptrst(struct cpu_user_regs *regs) unsigned long gpa = 0; int rc; - rc = decode_vmx_inst(regs, &decode, &gpa, 0); + rc = decode_vmx_inst(regs, &decode, NULL, 0); if ( rc != X86EMUL_OKAY ) return rc; @@ -1992,10 +1992,9 @@ int nvmx_handle_invept(struct cpu_user_regs *regs) int nvmx_handle_invvpid(struct cpu_user_regs *regs) { struct vmx_inst_decoded decode; - unsigned long vpid; int ret; - if ( (ret = decode_vmx_inst(regs, &decode, &vpid, 0)) != X86EMUL_OKAY ) + if ( (ret = decode_vmx_inst(regs, &decode, NULL, 0)) != X86EMUL_OKAY ) return ret; switch ( reg_read(regs, decode.op[1].reg_idx) )