From patchwork Wed Nov 1 16:50:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joe Perches X-Patchwork-Id: 10036759 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2AD0A603B5 for ; Wed, 1 Nov 2017 16:52:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 67E42286D2 for ; Wed, 1 Nov 2017 16:52:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5BCA628938; Wed, 1 Nov 2017 16:52:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 138D7286D2 for ; Wed, 1 Nov 2017 16:52:47 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9wDU-0007zR-II; Wed, 01 Nov 2017 16:50:12 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9wDT-0007yp-3P for xen-devel@lists.xenproject.org; Wed, 01 Nov 2017 16:50:11 +0000 Received: from [193.109.254.147] by server-1.bemta-6.messagelabs.com id 8A/10-31121-24BF9F95; Wed, 01 Nov 2017 16:50:10 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrCIsWRWlGSWpSXmKPExsVyQ0OnStfx989 Ig7u7LCy+b5nM5MDocfjDFZYAxijWzLyk/IoE1ozO3ocsBZsFKr7dfc3UwHiWt4uRi0NIYC+j RM/2L+xdjJwcEgIGEnNWPGAFSUgI7GaVmDDnJnMXIweQIyfx54oQRI2UxOPt79kgmjczSsyYc I8ZJMErYCxxbeJWFhBbWMBVYvLbp2BxNgFlia5bi1lBbBEBF4nFr1uYQGxmgWCJvXNOs4HYLA KqEms/72AF2cUpYC3xazLYPUICVhIPDu1jhyjXk5hytYUR4gZZif45s1lAynkFBCX+7hCGKJG X2P52DvMERqFZSDpmIVTNQlK1gJF5FaNGcWpRWWqRrqGFXlJRZnpGSW5iZo6uoYGZXm5qcXFi empOYlKxXnJ+7iZGYCgzAMEOxpsbAw4xSnIwKYnyat7/GSnEl5SfUpmRWJwRX1Sak1p8iFGGg 0NJgtf5F1BOsCg1PbUiLTMHGFUwaQkOHiUR3hSQNG9xQWJucWY6ROoUoyXHsU2X/zBxdNy8Cy SfzXzdwCzEkpeflyolznvlJ1CDAEhDRmke3DhY5F9ilJUS5mUEOlCIpyC1KDezBFX+FaM4B6O SMK8lyFqezLwSuK2vgA5iAjrIS+IHyEEliQgpqQbGzBrTX+EP0uKmWRxdZbx3noDynt5b5XzC 99UXX99W8NVeqm7+S0apHVeWyW85pG7znfPR6ZWWjTczlOraEnknettnF6U/a1ycb5zWVNb0u 4C3TaLa3nf3pi9dAnf4f57KNfZ6v+DFvPXvPxa6Lbx5mKXEr55J5r5I8YVTgQvWHXS9cOHt8q pXSizFGYmGWsxFxYkAxFySrfcCAAA= X-Env-Sender: joe@perches.com X-Msg-Ref: server-7.tower-27.messagelabs.com!1509555009!109875995!1 X-Originating-IP: [216.40.44.122] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 28157 invoked from network); 1 Nov 2017 16:50:09 -0000 Received: from smtprelay0122.hostedemail.com (HELO smtprelay.hostedemail.com) (216.40.44.122) by server-7.tower-27.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 1 Nov 2017 16:50:09 -0000 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay03.hostedemail.com (Postfix) with ESMTP id A7D508368EEE; Wed, 1 Nov 2017 16:50:08 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: fifth13_1189d12c9d4c X-Filterd-Recvd-Size: 2967 Received: from XPS-9350 (unknown [47.151.150.235]) (Authenticated sender: joe@perches.com) by omf10.hostedemail.com (Postfix) with ESMTPA; Wed, 1 Nov 2017 16:50:07 +0000 (UTC) Message-ID: <1509555005.31043.43.camel@perches.com> From: Joe Perches To: Tom Saeger , linux-kernel@vger.kernel.org Date: Wed, 01 Nov 2017 09:50:05 -0700 In-Reply-To: <20171031213740.25510-1-tom.saeger@oracle.com> References: <20171031213740.25510-1-tom.saeger@oracle.com> X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Cc: xen-devel , mercurial-devel@mercurial-scm.org Subject: Re: [Xen-devel] [PATCH] scripts: warn about invalid MAINTAINERS patterns X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP (add mercurial-devel and xen-devel to cc's) On Tue, 2017-10-31 at 16:37 -0500, Tom Saeger wrote: > Add "--pattern-checks" option to get_maintainer.pl to warn about invalid > "F" and "X" patterns found in MAINTAINERS file(s). Hey again Tom. About mercurial/hg. While as far as I know there hasn't been a mercurial tree for the linux kernel sources in many years, I believe the mercurial command to list files should be different. > my %VCS_cmds_hg = ( > @@ -167,6 +169,7 @@ my %VCS_cmds_hg = ( > "subject_pattern" => "^HgSubject: (.*)", > "stat_pattern" => "^(\\d+)\t(\\d+)\t\$file\$", > "file_exists_cmd" => "hg files \$file", > + "list_files_cmd" => "hg files \$file", I think this should be "list_files_cmd" => "hg manifest -R \$file", It seems to work on a XEN test branch but does anyone really care about hg support in get_maintainers? btw: to the XEN maintainers The XEN mercurial branch for MAINTAINERS has a few odd entries and a few missing file patterns I think the XEN MAINTAINERS file should be updated to: --- --- After the patch above is applied, --self-test shows: $ ~/linux/next/scripts/get_maintainer.pl --self-test ./MAINTAINERS:403: warning: no matches F: drivers/xen/usb*/ ./MAINTAINERS:415: warning: no matches F: xen/arch/x88/hvm/vm_event.c ./MAINTAINERS:429: warning: no matches F: extras/mini-os/tpm* ./MAINTAINERS:430: warning: no matches F: extras/mini-os/include/tpm* diff -r c60f04b73240 MAINTAINERS --- a/MAINTAINERS Mon Oct 16 15:24:44 2017 +0100 +++ b/MAINTAINERS Wed Nov 01 09:39:34 2017 -0700 @@ -246,7 +246,8 @@ KCONFIG M: Doug Goldstein S: Supported -F: docs/misc/kconfig{,-language}.txt +F: docs/misc/kconfig.txt +F: docs/misc/kconfig-language.txt F: xen/tools/kconfig/ KDD DEBUGGER @@ -257,8 +258,8 @@ KEXEC M: Andrew Cooper S: Supported -F: xen/common/{kexec,kimage}.c -F: xen/include/{kexec,kimage}.h +F: xen/common/kexec.[ch] +F: xen/common/kimage.[ch] F: xen/arch/x86/machine_kexec.c F: xen/arch/x86/x86_64/kexec_reloc.S